Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support identifying explain queries #44

Open
MasterOdin opened this issue Oct 6, 2021 · 1 comment
Open

support identifying explain queries #44

MasterOdin opened this issue Oct 6, 2021 · 1 comment

Comments

@MasterOdin
Copy link
Member

MasterOdin commented Oct 6, 2021

For example, EXPLAIN SELECT 1, where this is currently identified as UNKNOWN. We should probably support this as it's somewhat common, and easy to support (just detect if first word in EXPLAIN.

Support for it would probably be adding a new command type (EXPLAIN) and execution type (EXPLAIN) as it doesn't really make sense to call it a LISTING or MODIFICATION.

This would improve the state of things for consumers where while the pg npm package will return EXPLAIN as a command type which we can leverage, sqlite on the other hand would just have UNKNOWN.

Any reason not to do this @rathboma, other than perhaps that different databases have different outputs for explain (e.g. sqlite vs postgresql).

@rathboma
Copy link
Contributor

rathboma commented Oct 6, 2021

Seems like a grand idea. Especially as we want new statement types for ddl modifications too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants