Skip to content

Commit e1972c2

Browse files
committed
fix: fix user view routing, refactor users view
1 parent b9d9b6a commit e1972c2

File tree

4 files changed

+61
-68
lines changed

4 files changed

+61
-68
lines changed

Diff for: src/views/users/User.vue

+11-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,16 @@
2626
import usersData from './UsersData'
2727
export default {
2828
name: 'User',
29+
beforeRouteEnter(to, from, next) {
30+
next(vm => {
31+
vm.usersOpened = from.fullPath.includes('users')
32+
})
33+
},
34+
data () {
35+
return {
36+
usersOpened: null
37+
}
38+
},
2939
computed: {
3040
fields () {
3141
return [
@@ -48,7 +58,7 @@ export default {
4858
},
4959
methods: {
5060
goBack() {
51-
this.$router.go(-1)
61+
this.usersOpened ? this.$router.go(-1) : this.$router.push({path: '/users'})
5262
}
5363
}
5464
}

Diff for: src/views/users/Users.vue

+27-34
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,33 @@
11
<template>
22
<CRow>
33
<CCol col="12" xl="8">
4-
<transition name="slide">
5-
<CCard>
6-
<CCardHeader>
7-
Users
8-
</CCardHeader>
9-
<CCardBody>
10-
<CDataTable
11-
hover
12-
striped
13-
:items="items"
14-
:fields="fields"
15-
:items-per-page="5"
16-
clickable-rows
17-
:active-page="activePage"
18-
@row-clicked="rowClicked"
19-
>
20-
<template #status="data">
21-
<td>
22-
<CBadge :color="getBadge(data.item.status)">
23-
{{data.item.status}}
24-
</CBadge>
25-
</td>
26-
</template>
27-
</CDataTable>
28-
<CPagination
29-
align="center"
30-
:double-arrows="false"
31-
:active-page="activePage"
32-
:pages="5"
33-
@update:activePage="pageChange"
34-
/>
35-
</CCardBody>
36-
</CCard>
37-
</transition>
4+
<CCard>
5+
<CCardHeader>
6+
Users
7+
</CCardHeader>
8+
<CCardBody>
9+
<CDataTable
10+
hover
11+
striped
12+
:items="items"
13+
:fields="fields"
14+
:items-per-page="5"
15+
clickable-rows
16+
:active-page="activePage"
17+
@row-clicked="rowClicked"
18+
:pagination="{ doubleArrows: false, align: center}"
19+
@page-change="pageChange"
20+
>
21+
<template #status="data">
22+
<td>
23+
<CBadge :color="getBadge(data.item.status)">
24+
{{data.item.status}}
25+
</CBadge>
26+
</td>
27+
</template>
28+
</CDataTable>
29+
</CCardBody>
30+
</CCard>
3831
</CCol>
3932
</CRow>
4033
</template>

Diff for: tests/unit/views/users/__snapshots__/User.spec.js.snap

+19-19
Original file line numberDiff line numberDiff line change
@@ -22,45 +22,45 @@ exports[`User.vue renders correctly 1`] = `
2222
class="card-body"
2323
>
2424
<div
25-
data-v-31168812=""
25+
data-v-ceef3348=""
2626
small=""
2727
>
2828
<!---->
2929
<div
3030
class="position-relative table-responsive"
31-
data-v-31168812=""
31+
data-v-ceef3348=""
3232
>
3333
<table
3434
class="table table-striped b-table-fixed"
35-
data-v-31168812=""
35+
data-v-ceef3348=""
3636
>
3737
<thead
38-
data-v-31168812=""
38+
data-v-ceef3348=""
3939
>
4040
<tr
41-
data-v-31168812=""
41+
data-v-ceef3348=""
4242
>
4343
<th
4444
class=""
45-
data-v-31168812=""
45+
data-v-ceef3348=""
4646
style="width: 150px;"
4747
>
4848
<div
4949
class="d-inline"
50-
data-v-31168812=""
50+
data-v-ceef3348=""
5151
>
5252
Samppa Nori
5353
</div>
5454
<!---->
5555
</th>
5656
<th
5757
class=""
58-
data-v-31168812=""
58+
data-v-ceef3348=""
5959
style="width: 150px;"
6060
>
6161
<div
6262
class="d-inline"
63-
data-v-31168812=""
63+
data-v-ceef3348=""
6464
>
6565
6666
</div>
@@ -71,54 +71,54 @@ exports[`User.vue renders correctly 1`] = `
7171
</thead>
7272
<tbody
7373
class="position-relative"
74-
data-v-31168812=""
74+
data-v-ceef3348=""
7575
>
7676
<tr
77-
data-v-31168812=""
77+
data-v-ceef3348=""
7878
>
7979
<td
8080
class=""
81-
data-v-31168812=""
81+
data-v-ceef3348=""
8282
>
8383
registered
8484
</td>
8585
<td
8686
class=""
87-
data-v-31168812=""
87+
data-v-ceef3348=""
8888
>
8989
2012/01/01
9090
</td>
9191
</tr>
9292
<!---->
9393
<tr
94-
data-v-31168812=""
94+
data-v-ceef3348=""
9595
>
9696
<td
9797
class=""
98-
data-v-31168812=""
98+
data-v-ceef3348=""
9999
>
100100
role
101101
</td>
102102
<td
103103
class=""
104-
data-v-31168812=""
104+
data-v-ceef3348=""
105105
>
106106
Member
107107
</td>
108108
</tr>
109109
<!---->
110110
<tr
111-
data-v-31168812=""
111+
data-v-ceef3348=""
112112
>
113113
<td
114114
class=""
115-
data-v-31168812=""
115+
data-v-ceef3348=""
116116
>
117117
status
118118
</td>
119119
<td
120120
class=""
121-
data-v-31168812=""
121+
data-v-ceef3348=""
122122
>
123123
Active
124124
</td>

Diff for: tests/unit/views/users/__snapshots__/Users.spec.js.snap

+4-14
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,11 @@ exports[`Users.vue renders correctly 1`] = `
1010
tag="div"
1111
xl="8"
1212
>
13-
<ccard-stub
14-
name="slide"
15-
>
13+
<ccard-stub>
1614
<ccardheader-stub>
1715
18-
Users
19-
16+
Users
17+
2018
</ccardheader-stub>
2119
2220
<ccardbody-stub>
@@ -28,19 +26,11 @@ exports[`Users.vue renders correctly 1`] = `
2826
hover="true"
2927
items="[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]"
3028
itemsperpage="5"
29+
pagination="[object Object]"
3130
responsive="true"
3231
sortervalue="[object Object]"
3332
striped="true"
3433
/>
35-
36-
<cpagination-stub
37-
activepage="1"
38-
align="center"
39-
arrows="true"
40-
dots="true"
41-
limit="5"
42-
pages="5"
43-
/>
4434
</ccardbody-stub>
4535
</ccard-stub>
4636
</ccol-stub>

0 commit comments

Comments
 (0)