Skip to content

Commit e3b4ef8

Browse files
SungJin1212SungJin1212
authored
Change all max async concurrency (#6268)
1 parent 41d171d commit e3b4ef8

File tree

6 files changed

+22
-21
lines changed

6 files changed

+22
-21
lines changed

‎CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
## master / unreleased
44

5-
* [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency` from `50` to `3` #6265
5+
* [CHANGE] Change all max async concurrency default values `50` to `3` #6268
6+
* [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency` from `50` to `3` #6265
67
* [CHANGE] Enable Compactor and Alertmanager in target all. #6204
78
* [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527
89
* [FEATURE] Ruler: Experimental: Add `ruler.frontend-address` to allow query to query frontends instead of ingesters. #6151

‎docs/blocks-storage/querier.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ blocks_storage:
620620

621621
# The maximum number of concurrent asynchronous operations can occur.
622622
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency
623-
[max_async_concurrency: <int> | default = 50]
623+
[max_async_concurrency: <int> | default = 3]
624624

625625
# The maximum number of enqueued asynchronous operations allowed.
626626
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-buffer-size
@@ -726,7 +726,7 @@ blocks_storage:
726726

727727
# The maximum number of concurrent asynchronous operations can occur.
728728
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-concurrency
729-
[max_async_concurrency: <int> | default = 50]
729+
[max_async_concurrency: <int> | default = 3]
730730

731731
# The maximum number of enqueued asynchronous operations allowed.
732732
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-buffer-size
@@ -860,7 +860,7 @@ blocks_storage:
860860

861861
# The maximum number of concurrent asynchronous operations can occur.
862862
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency
863-
[max_async_concurrency: <int> | default = 50]
863+
[max_async_concurrency: <int> | default = 3]
864864

865865
# The maximum number of enqueued asynchronous operations allowed.
866866
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-buffer-size
@@ -961,7 +961,7 @@ blocks_storage:
961961

962962
# The maximum number of concurrent asynchronous operations can occur.
963963
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency
964-
[max_async_concurrency: <int> | default = 50]
964+
[max_async_concurrency: <int> | default = 3]
965965

966966
# The maximum number of enqueued asynchronous operations allowed.
967967
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-buffer-size
@@ -1101,7 +1101,7 @@ blocks_storage:
11011101

11021102
# The maximum number of concurrent asynchronous operations can occur.
11031103
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency
1104-
[max_async_concurrency: <int> | default = 50]
1104+
[max_async_concurrency: <int> | default = 3]
11051105

11061106
# The maximum number of enqueued asynchronous operations allowed.
11071107
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-buffer-size
@@ -1202,7 +1202,7 @@ blocks_storage:
12021202

12031203
# The maximum number of concurrent asynchronous operations can occur.
12041204
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-concurrency
1205-
[max_async_concurrency: <int> | default = 50]
1205+
[max_async_concurrency: <int> | default = 3]
12061206

12071207
# The maximum number of enqueued asynchronous operations allowed.
12081208
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-buffer-size

‎docs/blocks-storage/store-gateway.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,7 @@ blocks_storage:
711711

712712
# The maximum number of concurrent asynchronous operations can occur.
713713
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency
714-
[max_async_concurrency: <int> | default = 50]
714+
[max_async_concurrency: <int> | default = 3]
715715

716716
# The maximum number of enqueued asynchronous operations allowed.
717717
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-buffer-size
@@ -817,7 +817,7 @@ blocks_storage:
817817

818818
# The maximum number of concurrent asynchronous operations can occur.
819819
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-concurrency
820-
[max_async_concurrency: <int> | default = 50]
820+
[max_async_concurrency: <int> | default = 3]
821821

822822
# The maximum number of enqueued asynchronous operations allowed.
823823
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-buffer-size
@@ -951,7 +951,7 @@ blocks_storage:
951951

952952
# The maximum number of concurrent asynchronous operations can occur.
953953
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency
954-
[max_async_concurrency: <int> | default = 50]
954+
[max_async_concurrency: <int> | default = 3]
955955

956956
# The maximum number of enqueued asynchronous operations allowed.
957957
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-buffer-size
@@ -1052,7 +1052,7 @@ blocks_storage:
10521052

10531053
# The maximum number of concurrent asynchronous operations can occur.
10541054
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency
1055-
[max_async_concurrency: <int> | default = 50]
1055+
[max_async_concurrency: <int> | default = 3]
10561056

10571057
# The maximum number of enqueued asynchronous operations allowed.
10581058
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-buffer-size
@@ -1192,7 +1192,7 @@ blocks_storage:
11921192

11931193
# The maximum number of concurrent asynchronous operations can occur.
11941194
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency
1195-
[max_async_concurrency: <int> | default = 50]
1195+
[max_async_concurrency: <int> | default = 3]
11961196

11971197
# The maximum number of enqueued asynchronous operations allowed.
11981198
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-buffer-size
@@ -1293,7 +1293,7 @@ blocks_storage:
12931293

12941294
# The maximum number of concurrent asynchronous operations can occur.
12951295
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-concurrency
1296-
[max_async_concurrency: <int> | default = 50]
1296+
[max_async_concurrency: <int> | default = 3]
12971297

12981298
# The maximum number of enqueued asynchronous operations allowed.
12991299
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-buffer-size

‎docs/configuration/config-file-reference.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,7 @@ bucket_store:
11651165

11661166
# The maximum number of concurrent asynchronous operations can occur.
11671167
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency
1168-
[max_async_concurrency: <int> | default = 50]
1168+
[max_async_concurrency: <int> | default = 3]
11691169

11701170
# The maximum number of enqueued asynchronous operations allowed.
11711171
# CLI flag: -blocks-storage.bucket-store.index-cache.memcached.max-async-buffer-size
@@ -1270,7 +1270,7 @@ bucket_store:
12701270

12711271
# The maximum number of concurrent asynchronous operations can occur.
12721272
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-concurrency
1273-
[max_async_concurrency: <int> | default = 50]
1273+
[max_async_concurrency: <int> | default = 3]
12741274

12751275
# The maximum number of enqueued asynchronous operations allowed.
12761276
# CLI flag: -blocks-storage.bucket-store.index-cache.redis.max-async-buffer-size
@@ -1403,7 +1403,7 @@ bucket_store:
14031403

14041404
# The maximum number of concurrent asynchronous operations can occur.
14051405
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency
1406-
[max_async_concurrency: <int> | default = 50]
1406+
[max_async_concurrency: <int> | default = 3]
14071407

14081408
# The maximum number of enqueued asynchronous operations allowed.
14091409
# CLI flag: -blocks-storage.bucket-store.chunks-cache.memcached.max-async-buffer-size
@@ -1503,7 +1503,7 @@ bucket_store:
15031503

15041504
# The maximum number of concurrent asynchronous operations can occur.
15051505
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency
1506-
[max_async_concurrency: <int> | default = 50]
1506+
[max_async_concurrency: <int> | default = 3]
15071507

15081508
# The maximum number of enqueued asynchronous operations allowed.
15091509
# CLI flag: -blocks-storage.bucket-store.chunks-cache.redis.max-async-buffer-size
@@ -1641,7 +1641,7 @@ bucket_store:
16411641

16421642
# The maximum number of concurrent asynchronous operations can occur.
16431643
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency
1644-
[max_async_concurrency: <int> | default = 50]
1644+
[max_async_concurrency: <int> | default = 3]
16451645

16461646
# The maximum number of enqueued asynchronous operations allowed.
16471647
# CLI flag: -blocks-storage.bucket-store.metadata-cache.memcached.max-async-buffer-size
@@ -1741,7 +1741,7 @@ bucket_store:
17411741

17421742
# The maximum number of concurrent asynchronous operations can occur.
17431743
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-concurrency
1744-
[max_async_concurrency: <int> | default = 50]
1744+
[max_async_concurrency: <int> | default = 3]
17451745

17461746
# The maximum number of enqueued asynchronous operations allowed.
17471747
# CLI flag: -blocks-storage.bucket-store.metadata-cache.redis.max-async-buffer-size

‎pkg/storage/tsdb/memcache_client_config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func (cfg *MemcachedClientConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefi
2626
f.StringVar(&cfg.Addresses, prefix+"addresses", "", "Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that).")
2727
f.DurationVar(&cfg.Timeout, prefix+"timeout", 100*time.Millisecond, "The socket read/write timeout.")
2828
f.IntVar(&cfg.MaxIdleConnections, prefix+"max-idle-connections", 16, "The maximum number of idle connections that will be maintained per address.")
29-
f.IntVar(&cfg.MaxAsyncConcurrency, prefix+"max-async-concurrency", 50, "The maximum number of concurrent asynchronous operations can occur.")
29+
f.IntVar(&cfg.MaxAsyncConcurrency, prefix+"max-async-concurrency", 3, "The maximum number of concurrent asynchronous operations can occur.")
3030
f.IntVar(&cfg.MaxAsyncBufferSize, prefix+"max-async-buffer-size", 10000, "The maximum number of enqueued asynchronous operations allowed.")
3131
f.IntVar(&cfg.MaxGetMultiConcurrency, prefix+"max-get-multi-concurrency", 100, "The maximum number of concurrent connections running get operations. If set to 0, concurrency is unlimited.")
3232
f.IntVar(&cfg.MaxGetMultiBatchSize, prefix+"max-get-multi-batch-size", 0, "The maximum number of keys a single underlying get operation should run. If more keys are specified, internally keys are split into multiple batches and fetched concurrently, honoring the max concurrency. If set to 0, the max batch size is unlimited.")

‎pkg/storage/tsdb/redis_client_config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (cfg *RedisClientConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix st
5555
f.IntVar(&cfg.GetMultiBatchSize, prefix+"get-multi-batch-size", 100, "The maximum size per batch for mget.")
5656
f.IntVar(&cfg.MaxSetMultiConcurrency, prefix+"max-set-multi-concurrency", 100, "The maximum number of concurrent SetMulti() operations. If set to 0, concurrency is unlimited.")
5757
f.IntVar(&cfg.SetMultiBatchSize, prefix+"set-multi-batch-size", 100, "The maximum size per batch for pipeline set.")
58-
f.IntVar(&cfg.MaxAsyncConcurrency, prefix+"max-async-concurrency", 50, "The maximum number of concurrent asynchronous operations can occur.")
58+
f.IntVar(&cfg.MaxAsyncConcurrency, prefix+"max-async-concurrency", 3, "The maximum number of concurrent asynchronous operations can occur.")
5959
f.IntVar(&cfg.MaxAsyncBufferSize, prefix+"max-async-buffer-size", 10000, "The maximum number of enqueued asynchronous operations allowed.")
6060
f.StringVar(&cfg.MasterName, prefix+"master-name", "", "Specifies the master's name. Must be not empty for Redis Sentinel.")
6161
f.IntVar(&cfg.CacheSize, prefix+"cache-size", 0, "If not zero then client-side caching is enabled. Client-side caching is when data is stored in memory instead of fetching data each time. See https://redis.io/docs/manual/client-side-caching/ for more info.")

0 commit comments

Comments
 (0)