Skip to content

Commit fa8300a

Browse files
committed
using filesystem bucket on test
Signed-off-by: alanprot <[email protected]>
1 parent 4fa4df6 commit fa8300a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/parquetconverter/converter_test.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package parquetconverter
33
import (
44
"context"
55
"fmt"
6+
"github.com/thanos-io/objstore/providers/filesystem"
67
"math/rand"
78
"testing"
89
"time"
@@ -41,7 +42,8 @@ func TestConverter(t *testing.T) {
4142
cfg.Ring.InstanceID = "parquet-converter-1"
4243
cfg.Ring.InstanceAddr = "1.2.3.4"
4344
cfg.Ring.KVStore.Mock = ringStore
44-
bucketClient := objstore.NewInMemBucket()
45+
bucketClient, err := filesystem.NewBucket(t.TempDir())
46+
require.NoError(t, err)
4547
userBucket := bucket.NewPrefixedBucketClient(bucketClient, user)
4648

4749
c, logger, _ := prepare(t, cfg, objstore.WithNoopInstr(bucketClient), nil)
@@ -72,7 +74,7 @@ func TestConverter(t *testing.T) {
7274
}
7375

7476
// Try to start the compactor with a bad consul kv-store. The
75-
err := services.StartAndAwaitRunning(context.Background(), c)
77+
err = services.StartAndAwaitRunning(context.Background(), c)
7678
require.NoError(t, err)
7779
defer services.StopAndAwaitTerminated(ctx, c) // nolint:errcheck
7880

0 commit comments

Comments
 (0)