Skip to content

Commit ec66b11

Browse files
authored
add explicit test case (#7956)
1 parent 0177972 commit ec66b11

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

modules/apps/transfer/v2/ibc_module_test.go

+13-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package v2_test
22

33
import (
4+
"crypto/sha256"
5+
"fmt"
46
"testing"
57
"time"
68

@@ -94,6 +96,12 @@ func (suite *TransferTestSuite) TestOnSendPacket() {
9496
func() {},
9597
types.ErrInvalidDenomForTransfer,
9698
},
99+
{
100+
"transfer with slashes in ibc denom",
101+
fmt.Sprintf("ibc/%x", sha256.Sum256([]byte("coin"))),
102+
func() {},
103+
types.ErrInvalidDenomForTransfer,
104+
},
97105
}
98106

99107
for _, tc := range testCases {
@@ -106,8 +114,10 @@ func (suite *TransferTestSuite) TestOnSendPacket() {
106114
suite.Require().True(ok)
107115
originalCoin := sdk.NewCoin(tc.sourceDenomToTransfer, amount)
108116

109-
token, err := suite.chainA.GetSimApp().TransferKeeper.TokenFromCoin(suite.chainA.GetContext(), originalCoin)
110-
suite.Require().NoError(err)
117+
token := types.Token{
118+
Denom: types.Denom{Base: originalCoin.Denom},
119+
Amount: originalCoin.Amount.String(),
120+
}
111121

112122
transferData := types.NewFungibleTokenPacketData(
113123
token.Denom.Path(),
@@ -128,7 +138,7 @@ func (suite *TransferTestSuite) TestOnSendPacket() {
128138
ctx := suite.chainA.GetContext()
129139
cbs := suite.chainA.App.GetIBCKeeper().ChannelKeeperV2.Router.Route(ibctesting.TransferPort)
130140

131-
err = cbs.OnSendPacket(ctx, suite.pathAToB.EndpointA.ClientID, suite.pathAToB.EndpointB.ClientID, 1, payload, suite.chainA.SenderAccount.GetAddress())
141+
err := cbs.OnSendPacket(ctx, suite.pathAToB.EndpointA.ClientID, suite.pathAToB.EndpointB.ClientID, 1, payload, suite.chainA.SenderAccount.GetAddress())
132142

133143
if tc.expError != nil {
134144
suite.Require().Contains(err.Error(), tc.expError.Error())

0 commit comments

Comments
 (0)