Skip to content

Commit 6374d66

Browse files
committed
Address todos
1 parent 2926b5f commit 6374d66

File tree

6 files changed

+5
-6
lines changed

6 files changed

+5
-6
lines changed

tests/integration/changeover.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func (suite *CCVTestSuite) TestRecycleTransferChannel() {
2727
// Create transfer channel manually
2828
distrTransferMsg := channeltypes.NewMsgChannelOpenInit(
2929
transfertypes.PortID,
30-
transfertypes.V1, // TODO(wllmshao): check if this is correct
30+
transfertypes.V1,
3131
channeltypes.UNORDERED,
3232
[]string{suite.path.EndpointA.ConnectionID},
3333
transfertypes.PortID,

tests/integration/distribution.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,6 @@ func (s *CCVTestSuite) TestIBCTransferMiddleware() {
690690
s.Require().NoError(err)
691691

692692
// execute middleware OnRecvPacket logic
693-
// TODO(wllmshao): check if this version string is ok
694693
ack := cbs.OnRecvPacket(s.providerCtx(), transfertypes.V1, packet, sdk.AccAddress{})
695694

696695
// compute expected rewards with provider denom

x/ccv/consumer/ibc_module.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func (am AppModule) OnChanOpenAck(
162162

163163
distrTransferMsg := channeltypes.NewMsgChannelOpenInit(
164164
transfertypes.PortID,
165-
transfertypes.V1, // TODO(wllmshao): check if this is correct
165+
transfertypes.V1,
166166
channeltypes.UNORDERED,
167167
connHops,
168168
transfertypes.PortID,

x/ccv/consumer/ibc_module_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ func TestOnChanOpenAck(t *testing.T) {
220220
// Expected msg
221221
distrTransferMsg := channeltypes.NewMsgChannelOpenInit(
222222
transfertypes.PortID,
223-
transfertypes.V1, // TODO(wllmshao): check if this is correct
223+
transfertypes.V1,
224224
channeltypes.UNORDERED,
225225
[]string{"connectionID"},
226226
transfertypes.PortID,

x/ccv/consumer/keeper/genesis.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func (k Keeper) InitGenesis(ctx sdk.Context, state *types.GenesisState) []abci.V
7171
panic(err)
7272
}
7373

74-
// TODO(wllmshao): this forces the client to be tendermint, unsure if this is ok
74+
// this means the client must be tendermint
7575
cid, err := k.clientKeeper.CreateClient(ctx, ibchost.Tendermint, clientStateBytes, consensusStateBytes)
7676
if err != nil {
7777
// If the client creation fails, the chain MUST NOT start

x/ccv/provider/keeper/consumer_lifecycle.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ func (k Keeper) CreateConsumerClient(
343343
return err
344344
}
345345

346-
// TODO(wllmshao): this forces the client to be tendermint, unsure if this is ok
346+
// this means the client must be tendermint
347347
clientID, err := k.clientKeeper.CreateClient(ctx, ibchost.Tendermint, clientStateBytes, consensusStateBytes)
348348
if err != nil {
349349
return err

0 commit comments

Comments
 (0)