You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* feat: first iteration on Permissionless ICS (#2117)
* (partially) renamed chain ids to consumer ids
* renamed proposal messages
* removed global slash entry
* fixed unit tests
* added new messages
* introduced new state
* added functionality for the register and initialize messages
* renamed (partially) chainIds to consumerIds
* set consumerId to chainId association during registration
* added extra check in the initialization so unknokwn, launched, or stopped chains cannot re-initialize
* added initial work on traversing initialized chains that are to-be-launched
* fixed rebase issues after bringing the VSCMaturedPackets work in
* made it so we traverse initialization records instead of addition proposals (+ additional changes so the unit tests pass)
* renamed more chainIDs to consumerIds
* removed ClientIdToChainId state because chainId already resides on the registration record
* nit fixes in go docs
* removed MsgConsumerAddition
* added CLI commands for new messages
* removed consumer modification proposal
* removed (partially) consumer removal proposal
* rebased to pick up the inactive-validators work (PR #2079)
* introduced consumerId in the equivocation messages (and a useful query for Hermes to get the consumerId)
* added safeguard so that a validator cannot opt-in to two different chains with the same chain id
* renamed some chainIDs to consumerIds
* updated based on comments
Co-authored-by: bernd-m <[email protected]>
* fixed integration tests
* rebased to pick up the removal of legacy proposals (#2130) and re-introduced old messages so that existing proposals can deserialize
* changes messages to only have MsgCreateConsumer and MsgUpdateConsumer and modified protos so that we are backward-compatible
* cleaned up slightly a few things (mostly committing & pushing) so people can pick up the latest changes
* fixed the CreateConsumer and UpdateConsumer logic and made most of the fields optional
* fixed hooks and the code around proposalId to consumerId
* feat: extend consumer validator query to return commission rate (backport #2162) (#2165)
* adapt #2162 changes for permissionless ICS
* nits
---------
Co-authored-by: kirdatatjana <[email protected]>
* renamed some chainIds to consumerIds
* took into account comments and also added safeguard to reject new proposals that still use deprecated messages (e.g., MsgConsumerAddition, etc.)
* Update x/ccv/provider/types/msg.go
Co-authored-by: bernd-m <[email protected]>
* removed double-gas charge on MsgCreateConsumer and imroved the logic of MsgUpdateConsumer
* added PopulateMinimumPowerInTopN tested
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* feat: add fields to consumer validators query (#2167)
* extend consumer validators query
* nit
* nits
* fix msg order
* deprecate power for consumer_power
* modified the way we verify the new owner address, as well as nit refactoring on the ConsumerIds
* fixed some rebase issues and changed a proto to be backward-compatible
---------
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* fixed bug on removing previous spawn time & added tests
* added some additional tests
* added tests on the hooks
* removed check that spawn time is in the future
* feat: refactor consumer validator set computation (#2175)
* add UT
* nits
* address comments
* Update x/ccv/provider/keeper/partial_set_security.go
Co-authored-by: insumity <[email protected]>
* fix tests
---------
Co-authored-by: insumity <[email protected]>
* fix!: ConsumerModificationProposal is needed in Gaia upgrade handler (#2176)
ConsumerModificationProposal is needed in Gaia upgrade handler
* fix: allow the owner of a chain to remove the chain (#2178)
fixed access in RemoveConsumer
* refactor: add proto enum for ConsumerPhase (#2182)
* feat: extend `consumer_validators` query to return consumer valset before launch (#2164)
* (partially) renamed chain ids to consumer ids
* renamed proposal messages
* removed global slash entry
* fixed unit tests
* added new messages
* introduced new state
* added functionality for the register and initialize messages
* renamed (partially) chainIds to consumerIds
* set consumerId to chainId association during registration
* added extra check in the initialization so unknokwn, launched, or stopped chains cannot re-initialize
* added initial work on traversing initialized chains that are to-be-launched
* fixed rebase issues after bringing the VSCMaturedPackets work in
* made it so we traverse initialization records instead of addition proposals (+ additional changes so the unit tests pass)
* renamed more chainIDs to consumerIds
* removed ClientIdToChainId state because chainId already resides on the registration record
* nit fixes in go docs
* removed MsgConsumerAddition
* added CLI commands for new messages
* removed consumer modification proposal
* removed (partially) consumer removal proposal
* rebased to pick up the inactive-validators work (PR #2079)
* introduced consumerId in the equivocation messages (and a useful query for Hermes to get the consumerId)
* added safeguard so that a validator cannot opt-in to two different chains with the same chain id
* renamed some chainIDs to consumerIds
* updated based on comments
Co-authored-by: bernd-m <[email protected]>
* fixed integration tests
* rebased to pick up the removal of legacy proposals (#2130) and re-introduced old messages so that existing proposals can deserialize
* changes messages to only have MsgCreateConsumer and MsgUpdateConsumer and modified protos so that we are backward-compatible
* cleaned up slightly a few things (mostly committing & pushing) so people can pick up the latest changes
* fixed the CreateConsumer and UpdateConsumer logic and made most of the fields optional
* fixed hooks and the code around proposalId to consumerId
* pre-spawn query
* rebase
* nits
* feat: extend consumer validator query to return commission rate (backport #2162) (#2165)
* adapt #2162 changes for permissionless ICS
* nits
---------
Co-authored-by: kirdatatjana <[email protected]>
* remove panics
* renamed some chainIds to consumerIds
* took into account comments and also added safeguard to reject new proposals that still use deprecated messages (e.g., MsgConsumerAddition, etc.)
* Update x/ccv/provider/types/msg.go
Co-authored-by: bernd-m <[email protected]>
* removed double-gas charge on MsgCreateConsumer and imroved the logic of MsgUpdateConsumer
* added PopulateMinimumPowerInTopN tested
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* update logic
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* feat: add fields to consumer validators query (#2167)
* extend consumer validators query
* nit
* nits
* fix msg order
* deprecate power for consumer_power
* nits
* feat: first iteration on Permissionless ICS (#2117)
* (partially) renamed chain ids to consumer ids
* renamed proposal messages
* removed global slash entry
* fixed unit tests
* added new messages
* introduced new state
* added functionality for the register and initialize messages
* renamed (partially) chainIds to consumerIds
* set consumerId to chainId association during registration
* added extra check in the initialization so unknokwn, launched, or stopped chains cannot re-initialize
* added initial work on traversing initialized chains that are to-be-launched
* fixed rebase issues after bringing the VSCMaturedPackets work in
* made it so we traverse initialization records instead of addition proposals (+ additional changes so the unit tests pass)
* renamed more chainIDs to consumerIds
* removed ClientIdToChainId state because chainId already resides on the registration record
* nit fixes in go docs
* removed MsgConsumerAddition
* added CLI commands for new messages
* removed consumer modification proposal
* removed (partially) consumer removal proposal
* rebased to pick up the inactive-validators work (PR #2079)
* introduced consumerId in the equivocation messages (and a useful query for Hermes to get the consumerId)
* added safeguard so that a validator cannot opt-in to two different chains with the same chain id
* renamed some chainIDs to consumerIds
* updated based on comments
Co-authored-by: bernd-m <[email protected]>
* fixed integration tests
* rebased to pick up the removal of legacy proposals (#2130) and re-introduced old messages so that existing proposals can deserialize
* changes messages to only have MsgCreateConsumer and MsgUpdateConsumer and modified protos so that we are backward-compatible
* cleaned up slightly a few things (mostly committing & pushing) so people can pick up the latest changes
* fixed the CreateConsumer and UpdateConsumer logic and made most of the fields optional
* fixed hooks and the code around proposalId to consumerId
* feat: extend consumer validator query to return commission rate (backport #2162) (#2165)
* adapt #2162 changes for permissionless ICS
* nits
---------
Co-authored-by: kirdatatjana <[email protected]>
* renamed some chainIds to consumerIds
* took into account comments and also added safeguard to reject new proposals that still use deprecated messages (e.g., MsgConsumerAddition, etc.)
* Update x/ccv/provider/types/msg.go
Co-authored-by: bernd-m <[email protected]>
* removed double-gas charge on MsgCreateConsumer and imroved the logic of MsgUpdateConsumer
* added PopulateMinimumPowerInTopN tested
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* feat: add fields to consumer validators query (#2167)
* extend consumer validators query
* nit
* nits
* fix msg order
* deprecate power for consumer_power
* modified the way we verify the new owner address, as well as nit refactoring on the ConsumerIds
* fixed some rebase issues and changed a proto to be backward-compatible
---------
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* cover stopped phase case
* fixed bug on removing previous spawn time & added tests
* added some additional tests
* added tests on the hooks
* removed check that spawn time is in the future
* feat: refactor consumer validator set computation (#2175)
* add UT
* nits
* address comments
* Update x/ccv/provider/keeper/partial_set_security.go
Co-authored-by: insumity <[email protected]>
* fix tests
---------
Co-authored-by: insumity <[email protected]>
* nit
* nits
* nit
---------
Co-authored-by: insumity <[email protected]>
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* fix build
* tests: fix integration test setup (#2183)
* fix integration test setup
* fix integration tests
* feat: add consumer chain query (#2179)
* feat: first iteration on Permissionless ICS (#2117)
* (partially) renamed chain ids to consumer ids
* renamed proposal messages
* removed global slash entry
* fixed unit tests
* added new messages
* introduced new state
* added functionality for the register and initialize messages
* renamed (partially) chainIds to consumerIds
* set consumerId to chainId association during registration
* added extra check in the initialization so unknokwn, launched, or stopped chains cannot re-initialize
* added initial work on traversing initialized chains that are to-be-launched
* fixed rebase issues after bringing the VSCMaturedPackets work in
* made it so we traverse initialization records instead of addition proposals (+ additional changes so the unit tests pass)
* renamed more chainIDs to consumerIds
* removed ClientIdToChainId state because chainId already resides on the registration record
* nit fixes in go docs
* removed MsgConsumerAddition
* added CLI commands for new messages
* removed consumer modification proposal
* removed (partially) consumer removal proposal
* rebased to pick up the inactive-validators work (PR #2079)
* introduced consumerId in the equivocation messages (and a useful query for Hermes to get the consumerId)
* added safeguard so that a validator cannot opt-in to two different chains with the same chain id
* renamed some chainIDs to consumerIds
* updated based on comments
Co-authored-by: bernd-m <[email protected]>
* fixed integration tests
* rebased to pick up the removal of legacy proposals (#2130) and re-introduced old messages so that existing proposals can deserialize
* changes messages to only have MsgCreateConsumer and MsgUpdateConsumer and modified protos so that we are backward-compatible
* cleaned up slightly a few things (mostly committing & pushing) so people can pick up the latest changes
* fixed the CreateConsumer and UpdateConsumer logic and made most of the fields optional
* fixed hooks and the code around proposalId to consumerId
* feat: extend consumer validator query to return commission rate (backport #2162) (#2165)
* adapt #2162 changes for permissionless ICS
* nits
---------
Co-authored-by: kirdatatjana <[email protected]>
* renamed some chainIds to consumerIds
* took into account comments and also added safeguard to reject new proposals that still use deprecated messages (e.g., MsgConsumerAddition, etc.)
* Update x/ccv/provider/types/msg.go
Co-authored-by: bernd-m <[email protected]>
* removed double-gas charge on MsgCreateConsumer and imroved the logic of MsgUpdateConsumer
* added PopulateMinimumPowerInTopN tested
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* feat: add fields to consumer validators query (#2167)
* extend consumer validators query
* nit
* nits
* fix msg order
* deprecate power for consumer_power
* modified the way we verify the new owner address, as well as nit refactoring on the ConsumerIds
* fixed some rebase issues and changed a proto to be backward-compatible
---------
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* fixed bug on removing previous spawn time & added tests
* added some additional tests
* added tests on the hooks
* removed check that spawn time is in the future
* feat: refactor consumer validator set computation (#2175)
* add UT
* nits
* address comments
* Update x/ccv/provider/keeper/partial_set_security.go
Co-authored-by: insumity <[email protected]>
* fix tests
---------
Co-authored-by: insumity <[email protected]>
* add UT
* nits
* nits
* revert legacy prop funcs
* fix UT
---------
Co-authored-by: insumity <[email protected]>
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* feat: extend consumer chains query (#2172)
* feat: first iteration on Permissionless ICS (#2117)
* (partially) renamed chain ids to consumer ids
* renamed proposal messages
* removed global slash entry
* fixed unit tests
* added new messages
* introduced new state
* added functionality for the register and initialize messages
* renamed (partially) chainIds to consumerIds
* set consumerId to chainId association during registration
* added extra check in the initialization so unknokwn, launched, or stopped chains cannot re-initialize
* added initial work on traversing initialized chains that are to-be-launched
* fixed rebase issues after bringing the VSCMaturedPackets work in
* made it so we traverse initialization records instead of addition proposals (+ additional changes so the unit tests pass)
* renamed more chainIDs to consumerIds
* removed ClientIdToChainId state because chainId already resides on the registration record
* nit fixes in go docs
* removed MsgConsumerAddition
* added CLI commands for new messages
* removed consumer modification proposal
* removed (partially) consumer removal proposal
* rebased to pick up the inactive-validators work (PR #2079)
* introduced consumerId in the equivocation messages (and a useful query for Hermes to get the consumerId)
* added safeguard so that a validator cannot opt-in to two different chains with the same chain id
* renamed some chainIDs to consumerIds
* updated based on comments
Co-authored-by: bernd-m <[email protected]>
* fixed integration tests
* rebased to pick up the removal of legacy proposals (#2130) and re-introduced old messages so that existing proposals can deserialize
* changes messages to only have MsgCreateConsumer and MsgUpdateConsumer and modified protos so that we are backward-compatible
* cleaned up slightly a few things (mostly committing & pushing) so people can pick up the latest changes
* fixed the CreateConsumer and UpdateConsumer logic and made most of the fields optional
* fixed hooks and the code around proposalId to consumerId
* feat: extend consumer validator query to return commission rate (backport #2162) (#2165)
* adapt #2162 changes for permissionless ICS
* nits
---------
Co-authored-by: kirdatatjana <[email protected]>
* renamed some chainIds to consumerIds
* took into account comments and also added safeguard to reject new proposals that still use deprecated messages (e.g., MsgConsumerAddition, etc.)
* Update x/ccv/provider/types/msg.go
Co-authored-by: bernd-m <[email protected]>
* removed double-gas charge on MsgCreateConsumer and imroved the logic of MsgUpdateConsumer
* added PopulateMinimumPowerInTopN tested
* took into account comments (using protos for marshalling string slice, fixed issues in the UpdateConsumer logic, added extra check to abort spurious proposals)
* feat: add fields to consumer validators query (#2167)
* extend consumer validators query
* nit
* nits
* fix msg order
* deprecate power for consumer_power
* modified the way we verify the new owner address, as well as nit refactoring on the ConsumerIds
* fixed some rebase issues and changed a proto to be backward-compatible
---------
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* add phase + metadata
* first logic draft
* add filter
* reformat test
* nits
* nit
* address comments
* update tests
* nits
* update logic
* update CLI
* revert unwanted changes
* remove filter field
* nit
* fix bad int conversion
* update cli
---------
Co-authored-by: insumity <[email protected]>
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
* feat!: migrations for permissionless (#2174)
* migrations for permissionless -- wip
* feat!: migrations for permissionless (#2177)
* initial commit
* took into account comments
* removed deprecated queries
* fix error due to rebase
* remove fields from provider genesis
* remove commented code
---------
Co-authored-by: insumity <[email protected]>
* feat: update `consumer_chains` REST endpoint (#2188)
update consumer chains REST endpoint
* fix: permissionless added event + cli changes (#2185)
* add consumer registration event
* fix some queries, CLI and permissionless logic
* cli changes
* addressed review comments
* fix!: several permissionless changes (#2189)
* minor fixes in tests
* replace IsConsumerProposedOrRegistered with IsConsumerActive
* remove param from createStakingValidator
* handle error in GetTopN
* remove aux methods for getting PowerShapingParameters
* remove default PowerShapingParameters
* fix tests
* handle error messages
* fix: fix consumer chain query CLI (#2190)
* fix consumer chains query cli
* add consumer-chain cli command
* fix consumer chains cli bug
* fix!: fix store.set nil values (#2193)
fix store.set nil values
* fix!: msgs validation (#2195)
* add testing for ValidateStringField
* ValidateInitializationParameters
* ValidatePowerShapingParameters
* validate NewOwnerAddress
* apply review suggestions
* fix: fix queries' API REST endpoint path (#2196)
* clean uw files
* doc
* Revert "doc"
This reverts commit efc2718.
* Revert "clean uw files"
This reverts commit 5773cf3.
* remove deprecated REST endpoints
* update REST endpoint
* fix broken UT by previous PR (#2195)
* fix: permissionless query (#2191)
* fix implementation
* addressed comments
* cleanup
* keep metadata and powershaping data for stopped consumer chains
* addressed comments
* adapt unit-tests
* refactor: mostly refactors (#2194)
* handle errors
* set the reverse index in SetConsumerClientId
* rename method
* create consumer_lifecycle.go with launch/stop logic
* move methods around
* move methods around
* handle ChangeRewardDenoms
* add TODOs
* remove proposal_test
* remove todos
* apply review suggestions
* apply review suggestions
* fix UTs
* fix!: provider msg validation (#2197)
* validate MsgAssignConsumerKey
* validate MsgSubmitConsumerMisbehaviour and MsgSubmitConsumerDoubleVoting
* move RemoveConsumer
* refactor: rearrange messages in msg.go
* validate MsgOptIn and MsgOptOut
* validate MsgSetConsumerCommissionRate
* remove ValidateBasic for deprecated msgs
* remove deprecated GetSigners
* remove deprecated GetSignBytes
* remove deprecated govv1beta1 validation
* remove Route and Type
* Update x/ccv/provider/keeper/msg_server.go
Co-authored-by: insumity <[email protected]>
* apply review suggestions
* apply review suggestions
---------
Co-authored-by: insumity <[email protected]>
* test: fix e2e tests + PSS e2e tests use permissionless (#2192)
Fix e2e tests + make PSS e2e tests use Permissionless ICS
* refactor: power shaping (#2207)
* update allowlist and denylist power shaping update
* fix tests
* refactor: move power shaping params to power_shaping.go
* rename record to parameters
* fix merge conflicts
* feat: fix queries (#2209)
* remove chain ID from all-pairs-valconsensus-address
* add consumer_id to Chain
* add GetAllLaunchedConsumerIds
* fix UT
* apply review suggestions
* fix!: remove `stopTime` from `MsgRemoveConsumer` (#2208)
* init commit
* renamed stop time to removal time
* fix errors in tests
* add GetAllConsumerWithIBCClients
* use GetAllConsumerWithIBCClients for efficiency
* fix UTs
* remove GetAllLaunchedConsumerIds as not needed
* typo in GetAllConsumersWithIBCClients
* improve comment
* Apply suggestions from code review
Co-authored-by: Marius Poke <[email protected]>
* took into account comments
---------
Co-authored-by: mpoke <[email protected]>
* feat: remove provider migration for CV 3 to 6 (#2211)
* remove migrations to CV < 7
* add changelog entry
* fix version name
* fix!: fix migration issue (#2214)
* init commit
* took into account comments
* fix!: register `ConsumerModificationProposal` and others (#2215)
init commit
* fix: fix misbehaviour and equivocation evidence CLI commands (#2213)
* silent errors in MBT driver
* fix misbehaviour and double-signing CLI cmds + few nits
* revert changes
* nit: remove type prefix from consumer phase enum (#2220)
remove type prefix in consumer phase enum
* refactor: stop using signer field in messages (#2219)
* remove error check
* stop using signer field in messages
* expand TODO comment
* replace signer with submitter
* fix UTs
* chore: update TX CLI help (#2222)
* update CLI help
* apply review suggestions
* feat!: add events for provider messages (#2221)
* add events for CreateConsumer
* add events for UpdateConsumer
* add events for RemoveConsumer
* add events for the rest of the messages
* apply review suggestions
* Id instead of ID
* fix events
* fix UT
* remove duplicate AttributeSubmitterAddress
* fix: fix queries' API endpoints (#2226)
* endpoint fixes
* Update proto/interchain_security/ccv/provider/v1/query.proto
Co-authored-by: MSalopek <[email protected]>
* Update proto/interchain_security/ccv/provider/v1/query.proto
Co-authored-by: MSalopek <[email protected]>
* generate proto
---------
Co-authored-by: MSalopek <[email protected]>
* fix!: replace CanLaunch with InitializeConsumer (#2224)
replace CanLaunch with InitializeConsumer
* fix: improve commands' description (#2227)
init commit
---------
Co-authored-by: insumity <[email protected]>
Co-authored-by: bernd-m <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: kirdatatjana <[email protected]>
Co-authored-by: MSalopek <[email protected]>
Copy file name to clipboardExpand all lines: docs/docs/adrs/adr-019-permissionless-ics.md
+7-5
Original file line number
Diff line number
Diff line change
@@ -95,8 +95,7 @@ consumer chains with the exact same `chainId`, and it is the responsibility of t
95
95
to interact with by providing the right `consumerId`.
96
96
97
97
Note that with Permissionless ICS, all interactions on a consumer chain have to use the `consumerId` instead of the `chainId`.
98
-
For example, if a validator opts in on a chain using `MsgOptIn`, the validator has to provide the `consumerId`. To also
99
-
provide the `consumerId` for Top N consumers chains, we store a mapping between `proposalID` to `consumerId`. This storing
98
+
For example, if a validator opts in on a chain using `MsgOptIn`, the validator has to provide the `consumerId`. To also provide the `consumerId` for Top N consumers chains, we store a mapping between `proposalID` to `consumerId`. This storing
100
99
takes place in the [`AfterProposalSubmission`](https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/x/gov/types/hooks.go#L19) hook.
101
100
Specifically, for the equivocation evidence, we update the `MsgSubmitConsumerMisbehaviour` and `MsgSubmitConsumerDoubleVoting` messages to include the `consumerId`,
102
101
and change [Hermes](https://github.com/informalsystems/hermes) to include `consumerId` in those constructed messages as well.
@@ -161,9 +160,9 @@ where `ConsumerRegistrationRecord` contains information about the to-be-launched
161
160
162
161
```protobuf
163
162
message ConsumerRegistrationRecord {
164
-
// the title of the chain to-be-launched
163
+
// the title of the chain to-be-registered
165
164
string title;
166
-
// the description of the chain to-be-launched
165
+
// the description of the chain to-be-registered
167
166
string description;
168
167
// the chain id of the new consumer chain
169
168
string chain_id;
@@ -183,7 +182,7 @@ To move an Opt In consumer chain to its initialized phase, we issue a `MsgInitia
183
182
184
183
```protobuf
185
184
message MsgInitializeConsumer {
186
-
// consumer id of the to-be-updated consumer chain
185
+
// consumer id of the to-be-initialized consumer chain
187
186
string consumer_id;
188
187
// the initialization record that contains initialization parameters for the upcoming chain
0 commit comments