MB-68926: subdoc_max_multi_paths is now a tunable via REST

This was increased as part of MB-63734, but this slipped through
as all unit tests run with the environment variable set

Change-Id: Ia383c24ad928a4e5da69ada954f00070317fb93e
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/236618
Reviewed-by: Jim Walker <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: trondn

daemon/settings.cc

@@ -1372,15 +1372,7 @@ void Settings::setMaxConcurrentCommandsPerConnection(size_t num) {
 }
 
 void Settings::setSubdocMultiMaxPaths(size_t val) {
-    // Can only change this for internal R&D, SDKs are generally hardcoded with
-    // the default so this would be pointless/dangerous to change outside of a
-    // controlled test.
-    if (getenv("MEMCACHED_UNIT_TESTS") != nullptr) {
-        subdoc_multi_max_paths.store(val, std::memory_order_release);
-        has.subdoc_multi_max_paths = true;
-        notify_changed("subdoc_multi_max_paths");
-    } else {
-        LOG_WARNING_RAW(
-                "Settings::setSubdocMultiMaxPaths: ignoring request to change");
-    }
-}
+    subdoc_multi_max_paths.store(val, std::memory_order_release);
+    has.subdoc_multi_max_paths = true;
+    notify_changed("subdoc_multi_max_paths");
+}