Skip to content

Commit 2ef81a1

Browse files
fix(cli): org:search:dump issues when dump is fetched across multiple queries (#1474)
https://coveord.atlassian.net/browse/KIT-3321
1 parent 6187375 commit 2ef81a1

File tree

10 files changed

+163
-22
lines changed

10 files changed

+163
-22
lines changed

package-lock.json

Lines changed: 140 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@actions/github": "5.1.1",
1414
"@commitlint/config-conventional": "17.6.1",
1515
"@commitlint/lint": "17.6.1",
16-
"@coveo/platform-client": "52.1.0",
16+
"@coveo/platform-client": "54.9.3",
1717
"@coveo/semantic-monorepo-tools": "2.4.28",
1818
"@coveord/release": "1.0.0",
1919
"@npmcli/arborist": "6.2.8",

packages/cli-e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"@babel/preset-env": "7.21.5",
6363
"@babel/preset-typescript": "7.21.5",
6464
"@coveo/cli": "3.2.6",
65-
"@coveo/platform-client": "52.1.0",
65+
"@coveo/platform-client": "54.9.3",
6666
"abortcontroller-polyfill": "1.7.5",
6767
"async-retry": "1.3.3",
6868
"babel-jest": "29.5.0",

packages/cli/commons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"dependencies": {
2727
"@amplitude/analytics-node": "^1.3.3",
2828
"@amplitude/analytics-types": "^2.1.2",
29-
"@coveo/platform-client": "52.1.0",
29+
"@coveo/platform-client": "54.9.3",
3030
"@oclif/core": "1.24.0",
3131
"abortcontroller-polyfill": "1.7.5",
3232
"chalk": "4.1.2",

packages/cli/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"@amplitude/identify": "^1.9.0",
1212
"@coveo/cli-commons": "2.9.3",
1313
"@coveo/cli-plugin-source": "2.3.3",
14-
"@coveo/platform-client": "52.1.0",
14+
"@coveo/platform-client": "54.9.3",
1515
"@oclif/core": "1.24.0",
1616
"@oclif/plugin-help": "5.1.23",
1717
"@oclif/plugin-plugins": "2.1.12",

packages/cli/core/src/commands/org/search/dump.spec.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,21 @@ describe('org:search:dump', () => {
7676
mockedSearch.mockReset();
7777
});
7878

79+
test
80+
.do(() => {
81+
mockReturnNumberOfResults(0);
82+
})
83+
.stdout()
84+
.stderr()
85+
.command(['org:search:dump', '-s', 'the_source_1'])
86+
.it('should pass maximumAge 0 as a search parameter', () =>
87+
expect(mockedSearch).toHaveBeenCalledWith(
88+
expect.objectContaining({
89+
maximumAge: 0,
90+
})
91+
)
92+
);
93+
7994
test
8095
.do(() => {
8196
mockReturnNumberOfResults(0);

packages/cli/core/src/commands/org/search/dump.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ export default class Dump extends CLICommand {
261261
const results = (await params.client.search.query({
262262
aq: this.getFilter(params, rowId),
263263
debug: true,
264+
maximumAge: 0,
264265
organizationId: params.organizationId,
265266
numberOfResults: this.numberOfResultPerQuery,
266267
sortCriteria: '@rowid ascending',

packages/cli/source/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
],
1616
"dependencies": {
1717
"@coveo/cli-commons": "2.9.3",
18-
"@coveo/platform-client": "52.1.0",
18+
"@coveo/platform-client": "54.9.3",
1919
"@coveo/push-api-client": "4.0.1",
2020
"@oclif/core": "1.24.0",
2121
"@oclif/plugin-help": "5.1.23",

packages/ui/atomic/create-atomic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"access": "public"
3131
},
3232
"dependencies": {
33-
"@coveo/platform-client": "52.1.0",
33+
"@coveo/platform-client": "54.9.3",
3434
"abortcontroller-polyfill": "1.7.5",
3535
"detect-indent": "7.0.1",
3636
"https-proxy-agent": "5.0.1",

packages/ui/vue/create-headless-vue/template/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"zod": "^3.19.1"
2222
},
2323
"devDependencies": {
24-
"@coveo/platform-client": "^52.1.0",
24+
"@coveo/platform-client": "54.9.3",
2525
"@rushstack/eslint-patch": "^1.1.4",
2626
"@types/node": "18.16.3",
2727
"@vitejs/plugin-vue": "^4.0.0",

0 commit comments

Comments
 (0)