Skip to content

Commit 7ab3dae

Browse files
fpbraultfpbrault
authored
test(atomic): add tests for generated answer tab support (#4447)
This PR adds tests for disabling/enabled atomic-generated-answer depending on the active tab https://coveord.atlassian.net/browse/CDX-1557
1 parent 0882dbc commit 7ab3dae

File tree

4 files changed

+255
-63
lines changed

4 files changed

+255
-63
lines changed

Diff for: ‎packages/atomic/src/components/search/tabs/atomic-tab-manager/atomic-tab-manager.new.stories.tsx

+171-61
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import {html} from 'lit/static-html.js';
66

77
const {decorator, play} = wrapInSearchInterface({
88
search: {
9+
// eslint-disable-next-line @cspell/spellchecker
10+
pipeline: 'genqatest',
911
preprocessSearchResponseMiddleware: (r) => {
1012
const [result] = r.body.results;
1113
result.title = 'Manage the Coveo In-Product Experiences (IPX)';
@@ -68,118 +70,226 @@ export const Default: Story = {
6870
<atomic-layout-section section="facets">
6971
<atomic-facets>
7072
<atomic-facet field="objecttype" label="Object type"></atomic-facet>
71-
<atomic-facet aria-label="included-facet" tabs-included='["article"]' field="filetype"
72-
label="File type (included facet)"></atomic-facet>
73-
<atomic-facet aria-label="excluded-facet" tabs-excluded='["article"]' field="source"
74-
label="Source (excluded facet)"></atomic-facet>
75-
<atomic-category-facet aria-label="included-facet" tabs-included='["article"]' field="geographicalhierarchy"
76-
label="World Atlas" with-search></atomic-category-facet>
77-
<atomic-category-facet aria-label="excluded-facet" tabs-excluded='["article"]' field="geographicalhierarchy"
78-
label="World Atlas"></atomic-category-facet>
79-
<atomic-color-facet aria-label="included-facet" tabs-included='["article"]' field="filetype" label="Files"
80-
number-of-values="6" sort-criteria="occurrences"></atomic-color-facet>
81-
<atomic-color-facet aria-label="excluded-facet" tabs-excluded='["article"]' field="filetype" label="Files"
82-
number-of-values="6" sort-criteria="occurrences"></atomic-color-facet>
83-
<atomic-rating-facet aria-label="included-facet" tabs-included='["article"]' field="snrating" label="Rating"
84-
number-of-intervals="5"></atomic-rating-facet>
85-
<atomic-rating-facet aria-label="excluded-facet" tabs-excluded='["article"]' field="snrating" label="Rating"
86-
number-of-intervals="5"></atomic-rating-facet>
87-
<atomic-rating-range-facet aria-label="included-facet" tabs-included='["article"]' facet-id="snrating_range"
88-
field="snrating" label="Rating Range (auto)" number-of-intervals="5"></atomic-rating-range-facet>
89-
<atomic-rating-range-facet aria-label="excluded-facet" tabs-excluded='["article"]'
90-
facet-id="snrating_range_2" field="snrating" label="Rating Range (auto)"
91-
number-of-intervals="5"></atomic-rating-range-facet>
92-
<atomic-timeframe-facet aria-label="included-facet" tabs-included='["article"]' label="Timeframe"
93-
with-date-picker>
73+
<atomic-facet
74+
aria-label="included-facet"
75+
tabs-included='["article"]'
76+
field="filetype"
77+
label="File type (included facet)"
78+
></atomic-facet>
79+
<atomic-facet
80+
aria-label="excluded-facet"
81+
tabs-excluded='["article"]'
82+
field="source"
83+
label="Source (excluded facet)"
84+
></atomic-facet>
85+
<atomic-category-facet
86+
aria-label="included-facet"
87+
tabs-included='["article"]'
88+
field="geographicalhierarchy"
89+
label="World Atlas"
90+
with-search
91+
></atomic-category-facet>
92+
<atomic-category-facet
93+
aria-label="excluded-facet"
94+
tabs-excluded='["article"]'
95+
field="geographicalhierarchy"
96+
label="World Atlas"
97+
></atomic-category-facet>
98+
<atomic-color-facet
99+
aria-label="included-facet"
100+
tabs-included='["article"]'
101+
field="filetype"
102+
label="Files"
103+
number-of-values="6"
104+
sort-criteria="occurrences"
105+
></atomic-color-facet>
106+
<atomic-color-facet
107+
aria-label="excluded-facet"
108+
tabs-excluded='["article"]'
109+
field="filetype"
110+
label="Files"
111+
number-of-values="6"
112+
sort-criteria="occurrences"
113+
></atomic-color-facet>
114+
<atomic-rating-facet
115+
aria-label="included-facet"
116+
tabs-included='["article"]'
117+
field="snrating"
118+
label="Rating"
119+
number-of-intervals="5"
120+
></atomic-rating-facet>
121+
<atomic-rating-facet
122+
aria-label="excluded-facet"
123+
tabs-excluded='["article"]'
124+
field="snrating"
125+
label="Rating"
126+
number-of-intervals="5"
127+
></atomic-rating-facet>
128+
<atomic-rating-range-facet
129+
aria-label="included-facet"
130+
tabs-included='["article"]'
131+
facet-id="snrating_range"
132+
field="snrating"
133+
label="Rating Range (auto)"
134+
number-of-intervals="5"
135+
></atomic-rating-range-facet>
136+
<atomic-rating-range-facet
137+
aria-label="excluded-facet"
138+
tabs-excluded='["article"]'
139+
facet-id="snrating_range_2"
140+
field="snrating"
141+
label="Rating Range (auto)"
142+
number-of-intervals="5"
143+
></atomic-rating-range-facet>
144+
<atomic-timeframe-facet
145+
aria-label="included-facet"
146+
tabs-included='["article"]'
147+
label="Timeframe"
148+
with-date-picker
149+
>
94150
<atomic-timeframe unit="hour"></atomic-timeframe>
95151
<atomic-timeframe unit="day"></atomic-timeframe>
96152
<atomic-timeframe unit="week"></atomic-timeframe>
97153
<atomic-timeframe unit="month"></atomic-timeframe>
98154
<atomic-timeframe unit="quarter"></atomic-timeframe>
99155
<atomic-timeframe unit="year"></atomic-timeframe>
100-
<atomic-timeframe unit="year" amount="10" period="next"></atomic-timeframe></atomic-timeframe-facet>
101-
<atomic-timeframe-facet aria-label="excluded-facet" tabs-excluded='["article"]' label="Timeframe"
102-
with-date-picker>
156+
<atomic-timeframe
157+
unit="year"
158+
amount="10"
159+
period="next"
160+
></atomic-timeframe
161+
></atomic-timeframe-facet>
162+
<atomic-timeframe-facet
163+
aria-label="excluded-facet"
164+
tabs-excluded='["article"]'
165+
label="Timeframe"
166+
with-date-picker
167+
>
103168
<atomic-timeframe unit="hour"></atomic-timeframe>
104169
<atomic-timeframe unit="day"></atomic-timeframe>
105170
<atomic-timeframe unit="week"></atomic-timeframe>
106171
<atomic-timeframe unit="month"></atomic-timeframe>
107172
<atomic-timeframe unit="quarter"></atomic-timeframe>
108173
<atomic-timeframe unit="year"></atomic-timeframe>
109-
<atomic-timeframe unit="year" amount="10" period="next"></atomic-timeframe></atomic-timeframe-facet>
174+
<atomic-timeframe
175+
unit="year"
176+
amount="10"
177+
period="next"
178+
></atomic-timeframe
179+
></atomic-timeframe-facet>
110180
</atomic-facets>
111181
</atomic-layout-section>
112182
<atomic-layout-section section="main">
113183
${story()}
114184
<atomic-layout-section section="horizontal-facets">
115185
<atomic-segmented-facet-scrollable>
116-
<atomic-segmented-facet aria-label="included-facet" tabs-included='["article"]' field="inat_kingdom"
117-
label="Kingdom"></atomic-segmented-facet>
186+
<atomic-segmented-facet
187+
aria-label="included-facet"
188+
tabs-included='["article"]'
189+
field="inat_kingdom"
190+
label="Kingdom"
191+
></atomic-segmented-facet>
118192
</atomic-segmented-facet-scrollable>
119193
<atomic-segmented-facet-scrollable>
120-
<atomic-segmented-facet aria-label="excluded-facet" tabs-excluded='["article"]' field="inat_kingdom"
121-
label="Kingdom"></atomic-segmented-facet>
194+
<atomic-segmented-facet
195+
aria-label="excluded-facet"
196+
tabs-excluded='["article"]'
197+
field="inat_kingdom"
198+
label="Kingdom"
199+
></atomic-segmented-facet>
122200
</atomic-segmented-facet-scrollable>
123201
</atomic-layout-section>
124202
<atomic-layout-section section="status">
125203
<atomic-breadbox></atomic-breadbox>
126204
<atomic-query-summary></atomic-query-summary>
127205
<atomic-refine-toggle></atomic-refine-toggle>
128206
<atomic-sort-dropdown>
129-
<atomic-sort-expression tabs-excluded='["article"]' label="Name descending"
130-
expression="name descending"></atomic-sort-expression>
131-
<atomic-sort-expression tabs-excluded='["article"]' label="Name ascending"
132-
expression="name ascending"></atomic-sort-expression>
133-
<atomic-sort-expression tabs-included='["article"]' label="Most Recent"
134-
expression="date descending"></atomic-sort-expression>
135-
<atomic-sort-expression tabs-included='["article"]' label="Least Recent"
136-
expression="date ascending"></atomic-sort-expression>
137-
<atomic-sort-expression label="relevance" expression="relevancy"></atomic-sort-expression>
207+
<atomic-sort-expression
208+
tabs-excluded='["article"]'
209+
label="Name descending"
210+
expression="name descending"
211+
></atomic-sort-expression>
212+
<atomic-sort-expression
213+
tabs-excluded='["article"]'
214+
label="Name ascending"
215+
expression="name ascending"
216+
></atomic-sort-expression>
217+
<atomic-sort-expression
218+
tabs-included='["article"]'
219+
label="Most Recent"
220+
expression="date descending"
221+
></atomic-sort-expression>
222+
<atomic-sort-expression
223+
tabs-included='["article"]'
224+
label="Least Recent"
225+
expression="date ascending"
226+
></atomic-sort-expression>
227+
<atomic-sort-expression
228+
label="relevance"
229+
expression="relevancy"
230+
></atomic-sort-expression>
138231
</atomic-sort-dropdown>
139232
</atomic-layout-section>
140233
<atomic-layout-section section="results">
141-
<atomic-smart-snippet tabs-included='["article", "documentation"]'
142-
style="padding: 10px;"></atomic-smart-snippet>
143-
<atomic-result-list tabs-included='["article"]' display="list" density="compact" image-size="small"
144-
data-testid="included-result-list">
234+
<atomic-generated-answer tabs-included='["article", "documentation"]'></atomic-generated-answer>
235+
<atomic-smart-snippet
236+
tabs-included='["article", "documentation"]'
237+
style="padding: 10px"
238+
></atomic-smart-snippet>
239+
<atomic-result-list
240+
tabs-included='["article"]'
241+
display="list"
242+
density="compact"
243+
image-size="small"
244+
data-testid="included-result-list"
245+
>
145246
<atomic-result-template>
146-
147247
<template>
148-
149-
<atomic-result-section-actions><atomic-quickview></atomic-quickview></atomic-result-section-actions>
248+
<atomic-result-section-actions
249+
><atomic-quickview></atomic-quickview
250+
></atomic-result-section-actions>
150251
<atomic-result-section-visual>
151-
152252
<img src="https://picsum.photos/350" class="thumbnail" />
153253
</atomic-result-section-visual>
154-
<atomic-result-section-title><atomic-result-link></atomic-result-link></atomic-result-section-title>
254+
<atomic-result-section-title
255+
><atomic-result-link></atomic-result-link
256+
></atomic-result-section-title>
155257
<atomic-result-section-excerpt>
156258
"included result list"
157-
<atomic-result-text field="excerpt"></atomic-result-text></atomic-result-section-excerpt>
259+
<atomic-result-text field="excerpt"></atomic-result-text
260+
></atomic-result-section-excerpt>
158261
</template>
159262
</atomic-result-template>
160263
</atomic-result-list>
161-
<atomic-result-list tabs-excluded='["article"]' display="grid" density="normal" image-size="icon"
162-
data-testid="excluded-result-list">
163-
264+
<atomic-result-list
265+
tabs-excluded='["article"]'
266+
display="grid"
267+
density="normal"
268+
image-size="icon"
269+
data-testid="excluded-result-list"
270+
>
164271
<atomic-result-template>
165272
<template>
166-
167-
<atomic-result-section-actions><atomic-quickview></atomic-quickview></atomic-result-section-actions>
168-
<atomic-result-section-visual>
169-
273+
<atomic-result-section-actions
274+
><atomic-quickview></atomic-quickview
275+
></atomic-result-section-actions>
276+
<atomic-result-section-visual>
170277
<img src="https://picsum.photos/400" class="thumbnail" />
171278
</atomic-result-section-visual>
172-
<atomic-result-section-title><atomic-result-link></atomic-result-link></atomic-result-section-title>
279+
<atomic-result-section-title
280+
><atomic-result-link></atomic-result-link
281+
></atomic-result-section-title>
173282
<atomic-result-section-excerpt>
174283
"excluded result list"
175-
<atomic-result-text field="excerpt"></atomic-result-text></atomic-result-section-excerpt>
284+
<atomic-result-text field="excerpt"></atomic-result-text
285+
></atomic-result-section-excerpt>
176286
</template>
177287
</atomic-result-template>
178288
</atomic-result-list>
179-
<atomic-query-error></atomic-commerce-query-error>
289+
<atomic-query-error></atomic-query-error>
180290
</atomic-layout-section>
181291
<atomic-layout-section section="pagination"></atomic-layout-section>
182-
</atomic-layout-section>
292+
183293
</atomic-search-layout>
184294
`,
185295
],

0 commit comments

Comments
 (0)