Skip to content

Commit 827a1de

Browse files
alexprudhommefpbrault
alexprudhomme
authored and
fpbrault
committed
chore(atomic): replace lit-html with lit (#4985)
https://coveord.atlassian.net/browse/KIT-3977 Since `lit-html` was in devDependencies (for storybook initially) and since it serves the same purpose as `lit/html.js`, the IDE would suggest imports from `lit-html` in `src/` files which would have caused problems when npm users would install Atomic. This PR removes every mention of lit-html and replaces it with lit/html. This PR also addresses another refactor I came across with a file in `src/components/common/types.ts` that was exporting random interfaces from headless search. I removed that file and adjusted the imports across the repo.
1 parent c9ddcc6 commit 827a1de

File tree

60 files changed

+77
-119
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+77
-119
lines changed

Diff for: ‎package-lock.json

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎packages/atomic/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@
131131
"jest-environment-node": "29.7.0",
132132
"jest-localstorage-mock": "2.4.26",
133133
"lightningcss": "1.29.1",
134-
"lit-html": "3.2.1",
135134
"local-web-server": "5.4.0",
136135
"natural-orderby": "5.0.0",
137136
"ora": "8.2.0",

Diff for: ‎packages/atomic/src/components.d.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* It contains typing information for all components that exist in this project.
66
*/
77
import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
8-
import { AutomaticFacet, CategoryFacetSortCriterion, DateFilterRange, DateRangeRequest, FacetResultsMustMatch, FacetSortCriterion, FoldedResult, GeneratedAnswer, GeneratedAnswerCitation, InlineLink, InteractiveCitation, InteractiveResult, LogLevel as LogLevel1, RangeFacetRangeAlgorithm, RangeFacetSortCriterion, Result, ResultTemplate, ResultTemplateCondition, SearchEngine, SearchStatus } from "@coveo/headless";
8+
import { AutomaticFacet, CategoryFacetSortCriterion, DateFilterRange, DateRangeRequest, FacetResultsMustMatch, FacetSortCriterion, FoldedResult, GeneratedAnswer, GeneratedAnswerCitation, InlineLink, InteractiveCitation, InteractiveResult, LogLevel as LogLevel1, NumericFilter, NumericFilterState, RangeFacetRangeAlgorithm, RangeFacetSortCriterion, RelativeDateUnit, Result, ResultTemplate, ResultTemplateCondition, SearchEngine, SearchStatus } from "@coveo/headless";
99
import { CategoryFacet, CommerceEngine, DateFacet, InteractiveProduct, LogLevel, NumericFacet, Product, ProductListing, ProductListingSummaryState, ProductTemplate, ProductTemplateCondition, RegularFacet, Search, SearchSummaryState, Summary } from "@coveo/headless/commerce";
1010
import { CommerceBindings as Bindings, CommerceInitializationOptions } from "./components/commerce/atomic-commerce-interface/atomic-commerce-interface";
1111
import { Range } from "./components/commerce/facets/facet-number-input/atomic-commerce-facet-number-input";
@@ -18,7 +18,6 @@ import { AriaLabelGenerator } from "./components/commerce/search-box-suggestions
1818
import { AtomicInterface } from "./utils/initialization-utils";
1919
import { AnyBindings } from "./components/common/interface/bindings";
2020
import { NumberInputType } from "./components/common/facets/facet-number-input/number-input-type";
21-
import { NumericFilter, NumericFilterState, RelativeDateUnit } from "./components/common/types";
2221
import { InsightEngine, FacetSortCriterion as InsightFacetSortCriterion, FoldedResult as InsightFoldedResult, InteractiveResult as InsightInteractiveResult, LogLevel as InsightLogLevel, RangeFacetRangeAlgorithm as InsightRangeFacetRangeAlgorithm, RangeFacetSortCriterion as InsightRangeFacetSortCriterion, Result as InsightResult, ResultTemplate as InsightResultTemplate, ResultTemplateCondition as InsightResultTemplateCondition, UserAction as IUserAction } from "@coveo/headless/insight";
2322
import { InsightInitializationOptions } from "./components/insight/atomic-insight-interface/atomic-insight-interface";
2423
import { InsightStore } from "./components/insight/atomic-insight-interface/store";
@@ -36,7 +35,7 @@ import { Bindings as Bindings1 } from "./components/search/atomic-search-interfa
3635
import { SearchStore } from "./components/search/atomic-search-interface/store";
3736
import { AriaLabelGenerator as AriaLabelGenerator1 } from "./components/search/search-box-suggestions/atomic-search-box-instant-results/atomic-search-box-instant-results";
3837
import { InitializationOptions } from "./components/search/atomic-search-interface/atomic-search-interface";
39-
export { AutomaticFacet, CategoryFacetSortCriterion, DateFilterRange, DateRangeRequest, FacetResultsMustMatch, FacetSortCriterion, FoldedResult, GeneratedAnswer, GeneratedAnswerCitation, InlineLink, InteractiveCitation, InteractiveResult, LogLevel as LogLevel1, RangeFacetRangeAlgorithm, RangeFacetSortCriterion, Result, ResultTemplate, ResultTemplateCondition, SearchEngine, SearchStatus } from "@coveo/headless";
38+
export { AutomaticFacet, CategoryFacetSortCriterion, DateFilterRange, DateRangeRequest, FacetResultsMustMatch, FacetSortCriterion, FoldedResult, GeneratedAnswer, GeneratedAnswerCitation, InlineLink, InteractiveCitation, InteractiveResult, LogLevel as LogLevel1, NumericFilter, NumericFilterState, RangeFacetRangeAlgorithm, RangeFacetSortCriterion, RelativeDateUnit, Result, ResultTemplate, ResultTemplateCondition, SearchEngine, SearchStatus } from "@coveo/headless";
4039
export { CategoryFacet, CommerceEngine, DateFacet, InteractiveProduct, LogLevel, NumericFacet, Product, ProductListing, ProductListingSummaryState, ProductTemplate, ProductTemplateCondition, RegularFacet, Search, SearchSummaryState, Summary } from "@coveo/headless/commerce";
4140
export { CommerceBindings as Bindings, CommerceInitializationOptions } from "./components/commerce/atomic-commerce-interface/atomic-commerce-interface";
4241
export { Range } from "./components/commerce/facets/facet-number-input/atomic-commerce-facet-number-input";
@@ -49,7 +48,6 @@ export { AriaLabelGenerator } from "./components/commerce/search-box-suggestions
4948
export { AtomicInterface } from "./utils/initialization-utils";
5049
export { AnyBindings } from "./components/common/interface/bindings";
5150
export { NumberInputType } from "./components/common/facets/facet-number-input/number-input-type";
52-
export { NumericFilter, NumericFilterState, RelativeDateUnit } from "./components/common/types";
5351
export { InsightEngine, FacetSortCriterion as InsightFacetSortCriterion, FoldedResult as InsightFoldedResult, InteractiveResult as InsightInteractiveResult, LogLevel as InsightLogLevel, RangeFacetRangeAlgorithm as InsightRangeFacetRangeAlgorithm, RangeFacetSortCriterion as InsightRangeFacetSortCriterion, Result as InsightResult, ResultTemplate as InsightResultTemplate, ResultTemplateCondition as InsightResultTemplateCondition, UserAction as IUserAction } from "@coveo/headless/insight";
5452
export { InsightInitializationOptions } from "./components/insight/atomic-insight-interface/atomic-insight-interface";
5553
export { InsightStore } from "./components/insight/atomic-insight-interface/store";

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-breadbox/atomic-commerce-breadbox.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
getSampleCommerceEngineConfiguration,
1010
} from '@coveo/headless/commerce';
1111
import type {Meta, StoryObj as Story} from '@storybook/web-components';
12-
import {html} from 'lit/static-html.js';
12+
import {html} from 'lit';
1313

1414
const {context, ...restOfConfiguration} =
1515
getSampleCommerceEngineConfiguration();

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-load-more-products/atomic-commerce-load-more-products.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
66
import {renderComponent} from '@/storybook-utils/common/render-component';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit/static-html.js';
8+
import {html} from 'lit';
99

1010
const {decorator, play} = wrapInCommerceInterface({skipFirstSearch: true});
1111

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-no-products/atomic-commerce-no-products.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
66
import {renderComponent} from '@/storybook-utils/common/render-component';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit/static-html.js';
8+
import {html} from 'lit';
99

1010
const {play} = wrapInCommerceInterface({skipFirstSearch: true});
1111
const {decorator, play: preprocessedPlayed} = wrapInCommerceInterface({

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-product-list/atomic-commerce-product-list.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
66
import {renderComponent} from '@/storybook-utils/common/render-component';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit-html/static.js';
8+
import {html} from 'lit';
99

1010
// TODO KIT-3640 - Add stories for table display
1111

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-products-per-page/atomic-commerce-products-per-page.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {wrapInCommerceInterface} from '@/storybook-utils/commerce/commerce-inter
22
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
33
import {renderComponent} from '@/storybook-utils/common/render-component';
44
import type {Meta, StoryObj as Story} from '@storybook/web-components';
5-
import {html} from 'lit/static-html.js';
5+
import {html} from 'lit';
66

77
const {decorator, play} = wrapInCommerceInterface({});
88

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-query-summary/atomic-commerce-query-summary.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
33
import {renderComponent} from '@/storybook-utils/common/render-component';
44
import {CommerceEngineConfiguration} from '@coveo/headless/commerce';
55
import type {Meta, StoryObj as Story} from '@storybook/web-components';
6-
import {html} from 'lit/static-html.js';
6+
import {html} from 'lit';
77

88
const {decorator, play} = wrapInCommerceInterface({
99
skipFirstSearch: false,

Diff for: ‎packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
66
import {renderComponent} from '@/storybook-utils/common/render-component';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit/static-html.js';
8+
import {html} from 'lit';
99

1010
const {decorator, play} = wrapInCommerceInterface({skipFirstSearch: true});
1111

Diff for: ‎packages/atomic/src/components/commerce/facets/atomic-commerce-category-facet/atomic-commerce-category-facet.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
77
import {renderComponent} from '@/storybook-utils/common/render-component';
88
import type {Meta, StoryObj as Story} from '@storybook/web-components';
9-
import {html} from 'lit-html';
9+
import {html} from 'lit';
1010

1111
const {play, decorator} = wrapInCommerceInterface({skipFirstSearch: true});
1212

Diff for: ‎packages/atomic/src/components/commerce/facets/atomic-commerce-facet/atomic-commerce-facet.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
77
import {renderComponent} from '@/storybook-utils/common/render-component';
88
import type {Meta, StoryObj as Story} from '@storybook/web-components';
9-
import {html} from 'lit-html';
9+
import {html} from 'lit';
1010

1111
const {play, decorator} = wrapInCommerceInterface({skipFirstSearch: true});
1212

Diff for: ‎packages/atomic/src/components/commerce/facets/atomic-commerce-facets/atomic-commerce-facets.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
66
import {renderComponent} from '@/storybook-utils/common/render-component';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit/static-html.js';
8+
import {html} from 'lit';
99

1010
const {decorator, play} = wrapInCommerceInterface({skipFirstSearch: true});
1111

Diff for: ‎packages/atomic/src/components/commerce/facets/atomic-commerce-numeric-facet/atomic-commerce-numeric-facet.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
77
import {renderComponent} from '@/storybook-utils/common/render-component';
88
import type {Meta, StoryObj as Story} from '@storybook/web-components';
9-
import {html} from 'lit-html';
9+
import {html} from 'lit';
1010

1111
const {play, decorator} = wrapInCommerceInterface({skipFirstSearch: true});
1212

Diff for: ‎packages/atomic/src/components/commerce/product-template-components/atomic-product-image/atomic-product-image.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
55
import {renderComponent} from '@/storybook-utils/common/render-component';
66
import type {Meta, StoryObj as Story} from '@storybook/web-components';
77
import type {Decorator} from '@storybook/web-components';
8-
import {html} from 'lit-html';
8+
import {html} from 'lit';
99

1010
const styledDivDecorator: Decorator = (story) => {
1111
return html`<div style="max-width: 700px">${story()}</div>`;

Diff for: ‎packages/atomic/src/components/commerce/product-template-components/atomic-product-link/atomic-product-link.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {wrapInProductTemplate} from '@/storybook-utils/commerce/commerce-product
44
import {parameters} from '@/storybook-utils/common/common-meta-parameters';
55
import {renderComponent} from '@/storybook-utils/common/render-component';
66
import type {Meta, StoryObj as Story} from '@storybook/web-components';
7-
import {html} from 'lit-html';
7+
import {html} from 'lit';
88

99
const {
1010
decorator: commerceInterfaceDecorator,

Diff for: ‎packages/atomic/src/components/commerce/product-template-components/atomic-product-multi-value-text/atomic-product-multi-value-text.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
55
import {renderComponent} from '@/storybook-utils/common/render-component';
66
import {getSampleCommerceEngineConfiguration} from '@coveo/headless/commerce';
77
import type {Meta, StoryObj as Story} from '@storybook/web-components';
8-
import {html} from 'lit/static-html.js';
8+
import {html} from 'lit';
99

1010
const baseConfiguration = getSampleCommerceEngineConfiguration();
1111

Diff for: ‎packages/atomic/src/components/commerce/search-box-suggestions/atomic-commerce-search-box-instant-products/atomic-commerce-search-box-instant-products.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type {
66
Meta,
77
StoryObj as Story,
88
} from '@storybook/web-components';
9-
import {html} from 'lit/static-html.js';
9+
import {html} from 'lit';
1010

1111
const {decorator, play} = wrapInCommerceInterface({skipFirstSearch: true});
1212

Diff for: ‎packages/atomic/src/components/common/atomic-icon/atomic-icon.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {wrapInSearchInterface} from '@/storybook-utils/search/search-interface-w
44
import bgIcons from '@salesforce-ux/design-system/design-tokens/dist/bg-standard.common';
55
import {userEvent, waitFor, expect} from '@storybook/test';
66
import type {Meta, StoryObj as Story} from '@storybook/web-components';
7-
import {html} from 'lit/static-html.js';
7+
import {html} from 'lit';
88
import {within} from 'shadow-dom-testing-library';
99
import AssetsList from '../../../../docs/assets.json';
1010

Diff for: ‎packages/atomic/src/components/common/atomic-numeric-range/atomic-numeric-range.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
22
import {renderComponent} from '@/storybook-utils/common/render-component';
33
import {wrapInSearchInterface} from '@/storybook-utils/search/search-interface-wrapper';
44
import type {Meta, StoryObj as Story} from '@storybook/web-components';
5-
import {html} from 'lit/static-html.js';
5+
import {html} from 'lit';
66

77
const {decorator, play} = wrapInSearchInterface();
88

Diff for: ‎packages/atomic/src/components/common/atomic-timeframe/atomic-timeframe.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
22
import {renderComponent} from '@/storybook-utils/common/render-component';
33
import {wrapInSearchInterface} from '@/storybook-utils/search/search-interface-wrapper';
44
import type {Meta, StoryObj as Story} from '@storybook/web-components';
5-
import {html} from 'lit/static-html.js';
5+
import {html} from 'lit';
66

77
const {decorator, play} = wrapInSearchInterface();
88

Diff for: ‎packages/atomic/src/components/common/atomic-timeframe/atomic-timeframe.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
import {RelativeDateUnit} from '@coveo/headless';
12
import {Component, Prop} from '@stencil/core';
23
import {Timeframe} from '../facets/timeframe-facet-common';
3-
import {RelativeDateUnit} from '../types';
44

55
/**
66
* The `atomic-timeframe` component defines a timeframe of an `atomic-timeframe-facet`, and therefore must be defined within an `atomic-timeframe-facet` component.

Diff for: ‎packages/atomic/src/components/common/button.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import {html} from 'lit-html';
2-
import {ifDefined} from 'lit-html/directives/if-defined.js';
1+
import {html} from 'lit';
2+
import {ifDefined} from 'lit/directives/if-defined.js';
33
import {createRipple} from '../../utils/ripple';
44
import {
55
getRippleColorForButtonStyle,

Diff for: ‎packages/atomic/src/components/common/facets/facet-common.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import {FacetValue, SearchStatusState} from '@coveo/headless';
12
import {i18n} from 'i18next';
2-
import {FacetValue, SearchStatusState} from '../types';
33

44
export interface FacetValueProps {
55
i18n: i18n;

Diff for: ‎packages/atomic/src/components/common/facets/facet-number-input/facet-number-input.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import {NumericFilter, NumericFilterState} from '@coveo/headless';
12
import {Component, h, State, Prop, Event, EventEmitter} from '@stencil/core';
23
import {AnyBindings} from '../../interface/bindings';
34
import {Button} from '../../stencil-button';
4-
import {NumericFilter, NumericFilterState} from '../../types';
55
import {NumberInputType} from './number-input-type';
66

77
/**

Diff for: ‎packages/atomic/src/components/common/facets/facet-search/facet-search-aria-live.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import {Facet, FacetSearchState} from '@coveo/headless';
12
import {i18n} from 'i18next';
2-
import {Facet, FacetSearchState} from '../../types';
33
import {shouldUpdateFacetSearchComponent} from './facet-search-utils';
44

55
export function announceFacetSearchResultsWithAriaLive(

Diff for: ‎packages/atomic/src/components/common/facets/timeframe-facet-common.tsx

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
1-
import {h, VNode} from '@stencil/core';
2-
import {FocusTargetController} from '../../../utils/accessibility-utils';
3-
import {parseDate} from '../../../utils/date-utils';
4-
import {getFieldValueCaption} from '../../../utils/field-utils';
5-
import {randomID} from '../../../utils/utils';
6-
import {InsightBindings} from '../../insight/atomic-insight-interface/atomic-insight-interface';
7-
import {Bindings as SearchBindings} from '../../search/atomic-search-interface/atomic-search-interface';
8-
import {Hidden} from '../stencil-hidden';
1+
import {FocusTargetController} from '@/src/utils/accessibility-utils';
92
import {
103
DateFacet,
114
DateFacetValue,
@@ -18,7 +11,14 @@ import {
1811
RelativeDatePeriod,
1912
RelativeDateUnit,
2013
SearchStatusState,
21-
} from '../types';
14+
} from '@coveo/headless';
15+
import {h, VNode} from '@stencil/core';
16+
import {parseDate} from '../../../utils/date-utils';
17+
import {getFieldValueCaption} from '../../../utils/field-utils';
18+
import {randomID} from '../../../utils/utils';
19+
import {InsightBindings} from '../../insight/atomic-insight-interface/atomic-insight-interface';
20+
import {Bindings as SearchBindings} from '../../search/atomic-search-interface/atomic-search-interface';
21+
import {Hidden} from '../stencil-hidden';
2222
import {shouldDisplayInputForFacetRange} from './facet-common';
2323
import {FacetInfo} from './facet-common-store';
2424
import {FacetContainer} from './facet-container/facet-container';

Diff for: ‎packages/atomic/src/components/common/heading.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ifDefined} from 'lit-html/directives/if-defined.js';
1+
import {ifDefined} from 'lit/directives/if-defined.js';
22
import {html, literal, unsafeStatic} from 'lit/static-html.js';
33

44
export interface HeadingProps {

Diff for: ‎packages/atomic/src/components/common/interface/interface-common.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export interface BaseAtomicInterface<EngineType extends AnyEngineType>
2525
host: HTMLElement;
2626
bindings: AnyBindings;
2727
error?: Error;
28-
2928
updateIconAssetsPath(): void;
3029
registerFieldsToInclude?: () => void; // Fix: Removed the question mark and added a semicolon.
3130
}

Diff for: ‎packages/atomic/src/components/common/radio-button.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {html, TemplateResult} from 'lit';
2-
import {ifDefined} from 'lit-html/directives/if-defined.js';
32
import {classMap} from 'lit/directives/class-map.js';
3+
import {ifDefined} from 'lit/directives/if-defined.js';
44
import {ref, RefOrCallback} from 'lit/directives/ref.js';
55
import {createRipple} from '../../utils/ripple';
66
import {

Diff for: ‎packages/atomic/src/components/common/types.ts

-42
This file was deleted.

Diff for: ‎packages/atomic/src/components/insight/atomic-insight-interface/store.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import {DEFAULT_MOBILE_BREAKPOINT} from '@/src/utils/replace-breakpoint';
2-
import {InsightEngine} from '@coveo/headless/insight';
2+
import {
3+
DateFacetValue,
4+
InsightEngine,
5+
NumericFacetValue,
6+
} from '@coveo/headless/insight';
37
import {
48
FacetInfo,
59
FacetStore,
@@ -16,7 +20,6 @@ import {
1620
unsetLoadingFlag,
1721
waitUntilAppLoaded,
1822
} from '../../common/interface/store';
19-
import {DateFacetValue, NumericFacetValue} from '../../common/types';
2023
import {makeDesktopQuery} from '../atomic-insight-layout/insight-layout';
2124

2225
interface Data {

Diff for: ‎packages/atomic/src/components/ipx/atomic-ipx-recs-list/atomic-recs-list/atomic-ipx-recs-list.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import recsStory from 'atomic-storybook/recommendation/recs-story';
2-
import {html} from 'lit-html';
2+
import {html} from 'lit';
33

44
const {defaultModuleExport, exportedStory} = recsStory(
55
'atomic-ipx-recs-list',

Diff for: ‎packages/atomic/src/components/recommendations/atomic-recs-list/atomic-recs-list.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {parameters} from '@/storybook-utils/common/common-meta-parameters';
22
import {renderComponent} from '@/storybook-utils/common/render-component';
33
import {wrapInRecommendationInterface} from '@/storybook-utils/search/recs-interface-wrapper';
44
import type {Meta, StoryObj as Story} from '@storybook/web-components';
5-
import {html} from 'lit-html/static.js';
5+
import {html} from 'lit';
66

77
const {decorator, play} = wrapInRecommendationInterface();
88

Diff for: ‎packages/atomic/src/components/search/atomic-external/atomic-external.new.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {Meta, StoryObj} from '@storybook/web-components';
2-
import {html} from 'lit-html';
2+
import {html} from 'lit';
33

44
const meta: Meta = {
55
component: 'atomic-external',

0 commit comments

Comments
 (0)