Skip to content

Commit ddce004

Browse files
fix(atomic, headless): use next as default value for queryCorrectionMode (#4495)
https://coveord.atlassian.net/browse/KIT-3630 This was also not done in headless during our sprints. We never looked for V3 mentions in comments.
1 parent 1cc5aee commit ddce004

File tree

18 files changed

+218
-309
lines changed

18 files changed

+218
-309
lines changed

packages/atomic/cypress/e2e/did-you-mean-actions.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

packages/atomic/cypress/e2e/did-you-mean-assertions.ts

Lines changed: 0 additions & 99 deletions
This file was deleted.

packages/atomic/cypress/e2e/did-you-mean-selectors.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

packages/atomic/cypress/e2e/did-you-mean.cypress.ts

Lines changed: 0 additions & 119 deletions
This file was deleted.

packages/atomic/src/components.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -805,7 +805,7 @@ export namespace Components {
805805
*/
806806
"automaticallyCorrectQuery": boolean;
807807
/**
808-
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `legacy`. In the next major version of Atomic, the default value will be `next`.
808+
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `next`.
809809
*/
810810
"queryCorrectionMode": 'legacy' | 'next';
811811
}
@@ -6732,7 +6732,7 @@ declare namespace LocalJSX {
67326732
*/
67336733
"automaticallyCorrectQuery"?: boolean;
67346734
/**
6735-
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `legacy`. In the next major version of Atomic, the default value will be `next`.
6735+
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `next`.
67366736
*/
67376737
"queryCorrectionMode"?: 'legacy' | 'next';
67386738
}

packages/atomic/src/components/common/atomic-modal/atomic-modal.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export class AtomicModal implements InitializableComponent<AnyBindings> {
7474

7575
if (isOpen) {
7676
this.wasEverOpened = true;
77-
//TODO: remove the addition of a class to the body in atomicV3
7877
document.body.classList.add(modalOpenedClass);
7978
this.bindings.interfaceElement.classList.add(modalOpenedClass);
8079
await this.waitForAnimationEnded();
@@ -83,7 +82,6 @@ export class AtomicModal implements InitializableComponent<AnyBindings> {
8382
}
8483
this.focusTrap!.active = true;
8584
} else {
86-
//TODO: remove the removal of a class to the body in atomicV3
8785
document.body.classList.remove(modalOpenedClass);
8886
this.bindings.interfaceElement.classList.remove(modalOpenedClass);
8987
if (isIOS()) {

packages/atomic/src/components/ipx/atomic-ipx-modal/atomic-ipx-modal.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,10 @@ export class AtomicIPXModal implements InitializableComponent<AnyBindings> {
4949
const modalOpenedClass = 'atomic-ipx-modal-opened';
5050

5151
if (isOpen) {
52-
//TODO: remove the addition of a class to the body in atomicV3
5352
document.body.classList.add(modalOpenedClass);
5453
this.bindings.interfaceElement.classList.add(modalOpenedClass);
5554
return;
5655
}
57-
//TODO: remove the removal of a class to the body in atomicV3
5856
document.body.classList.remove(modalOpenedClass);
5957
this.bindings.interfaceElement.classList.remove(modalOpenedClass);
6058
}

0 commit comments

Comments
 (0)