Skip to content

Commit

Permalink
fix(atomic, headless): use next as default value for queryCorrectio…
Browse files Browse the repository at this point in the history
…nMode (#4495)

https://coveord.atlassian.net/browse/KIT-3630

This was also not done in headless during our sprints. We never looked
for V3 mentions in comments.
  • Loading branch information
alexprudhomme authored Oct 9, 2024
1 parent 1cc5aee commit ddce004
Show file tree
Hide file tree
Showing 18 changed files with 218 additions and 309 deletions.
29 changes: 0 additions & 29 deletions packages/atomic/cypress/e2e/did-you-mean-actions.ts

This file was deleted.

99 changes: 0 additions & 99 deletions packages/atomic/cypress/e2e/did-you-mean-assertions.ts

This file was deleted.

21 changes: 0 additions & 21 deletions packages/atomic/cypress/e2e/did-you-mean-selectors.ts

This file was deleted.

119 changes: 0 additions & 119 deletions packages/atomic/cypress/e2e/did-you-mean.cypress.ts

This file was deleted.

4 changes: 2 additions & 2 deletions packages/atomic/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ export namespace Components {
*/
"automaticallyCorrectQuery": boolean;
/**
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `legacy`. In the next major version of Atomic, the default value will be `next`.
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `next`.
*/
"queryCorrectionMode": 'legacy' | 'next';
}
Expand Down Expand Up @@ -6732,7 +6732,7 @@ declare namespace LocalJSX {
*/
"automaticallyCorrectQuery"?: boolean;
/**
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `legacy`. In the next major version of Atomic, the default value will be `next`.
* Define which query correction system to use `legacy`: Query correction is powered by the legacy index system. This system relies on an algorithm using solely the index content to compute the suggested terms. `next`: Query correction is powered by a machine learning system, requiring a valid query suggestion model configured in your Coveo environment to function properly. This system relies on machine learning algorithms to compute the suggested terms. Default value is `next`.
*/
"queryCorrectionMode"?: 'legacy' | 'next';
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export class AtomicModal implements InitializableComponent<AnyBindings> {

if (isOpen) {
this.wasEverOpened = true;
//TODO: remove the addition of a class to the body in atomicV3
document.body.classList.add(modalOpenedClass);
this.bindings.interfaceElement.classList.add(modalOpenedClass);
await this.waitForAnimationEnded();
Expand All @@ -83,7 +82,6 @@ export class AtomicModal implements InitializableComponent<AnyBindings> {
}
this.focusTrap!.active = true;
} else {
//TODO: remove the removal of a class to the body in atomicV3
document.body.classList.remove(modalOpenedClass);
this.bindings.interfaceElement.classList.remove(modalOpenedClass);
if (isIOS()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,10 @@ export class AtomicIPXModal implements InitializableComponent<AnyBindings> {
const modalOpenedClass = 'atomic-ipx-modal-opened';

if (isOpen) {
//TODO: remove the addition of a class to the body in atomicV3
document.body.classList.add(modalOpenedClass);
this.bindings.interfaceElement.classList.add(modalOpenedClass);
return;
}
//TODO: remove the removal of a class to the body in atomicV3
document.body.classList.remove(modalOpenedClass);
this.bindings.interfaceElement.classList.remove(modalOpenedClass);
}
Expand Down
Loading

0 comments on commit ddce004

Please sign in to comment.