Added few test cases to do code coverage for validator and gen

Author: Abhilash Joseph C

py3resttest/generators.py

@@ -232,16 +232,8 @@ def parse_generator(configuration):
     elif gen_type == 'env_string':
         return factory_env_string(configuration['string'])()
     elif gen_type == 'number_sequence':
-        start = configuration.get('start')
-        increment = configuration.get('increment')
-        if not start:
-            start = 1
-        else:
-            start = int(start)
-        if not increment:
-            increment = 1
-        else:
-            increment = int(increment)
+        start = int(configuration.get('start', 1))
+        increment = int(configuration.get('increment', 1))
         return factory_generate_ids(start, increment)()
     elif gen_type == 'random_int':
         return generator_random_int32()

tests/test_generators.py

@@ -3,6 +3,8 @@
 import types
 import unittest
 
+import pytest
+
 from py3resttest import generators
 from py3resttest.binding import Context
 
@@ -140,6 +142,8 @@ def test_parse_fixed_sequence(self):
                   'values': vals}
         gen = generators.parse_generator(config)
         self.generator_basic_test(gen, lambda x: x in vals)
+        self.assertRaises(ValueError, generators.parse_generator, {'type': 'fixed_sequence', 'values': []})
+        self.assertRaises(ValueError, generators.parse_generator, {'type': 'fixed_sequence', 'values': {'x': 1}})
 
     def test_factory_choice(self):
         """ Tests linear sequences """
@@ -155,6 +159,17 @@ def test_factory_choice(self):
         gen = generators.factory_choice_generator(vals)()
         self.generator_basic_test(gen, lambda x: x in vals)
 
+        with pytest.raises(ValueError) as e:
+            gen = generators.parse_choice_generator({'values': []})()
+
+    def test_register_generator(self):
+
+        with pytest.raises(TypeError) as e:
+            gen = generators.register_generator(1, lambda x: x)
+
+        with pytest.raises(ValueError) as e:
+            gen = generators.register_generator('env_string', lambda x: x)
+
     def test_parse_choice_generatpr(self):
         vals = ['moobie', 'moby', 'moo']
         config = {'type': 'choice',