Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add gnu based static binary support #592

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[feat] Add gnu based static binary support #592

wants to merge 8 commits into from

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Jan 28, 2025 •
edited
Loading

What does this PR do?

  • Add gnu based static binary support, fix Optional GNU C Library support #376
  • Add CentOS 7.x doctor command support
  • Add env override file config/env.custom.ini
  • Fix openssl extension sanity check

Basic usage:

# run as CentOS 7 based docker image
bin/spc-gnu-docker --libc=glibc <command> ...

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added new feature New feature or request os/linux Things only for Linux OS mixed PR This PR contains multiple updates labels Jan 28, 2025
@crazywhalecc crazywhalecc marked this pull request as draft January 28, 2025 11:41
@crazywhalecc crazywhalecc changed the title Add gnu based static binary support [feat] Add gnu based static binary support Jan 28, 2025
@crazywhalecc crazywhalecc marked this pull request as ready for review February 4, 2025 08:19
@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Feb 4, 2025 •
edited
Loading

@dunglas Building some extension combinations with glibc is pretty smooth at the moment, but I'm not sure there are any hidden issues I haven't discovered yet. Docs are also in this PR.

It would be great if you'd like to provide some suggestions or feedback, and I'll merge to the main branch later.

@dunglas
Copy link
Contributor

dunglas commented Feb 4, 2025

Thank you for this!!

I had a (very) quick look and the patch looks good to me.

I'll try to build FrankenPHP with it to see if it works, but as I'll be in vacation for 10 days, it may take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mixed PR This PR contains multiple updates new feature New feature or request os/linux Things only for Linux OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional GNU C Library support
2 participants
@crazywhalecc @dunglas