Skip to content

Favicon and app icons not present on website #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Lakshay-Pruthi opened this issue Mar 21, 2023 · 4 comments · Fixed by #49
Closed
1 task done

Favicon and app icons not present on website #6

Lakshay-Pruthi opened this issue Mar 21, 2023 · 4 comments · Fixed by #49
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@Lakshay-Pruthi
Copy link

Description

Favicon not present on website.

Reproduction

  1. Go to website
  2. See error.

Expectation

There should be a favicon.

Resolution

  • I would be interested in resolving this bug.
@Lakshay-Pruthi Lakshay-Pruthi added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Mar 21, 2023
@TimidRobot
Copy link
Member

The required files can be found in the creativecommons/search repository. See:

@Lakshay-Pruthi Lakshay-Pruthi mentioned this issue Mar 24, 2023
7 tasks
@possumbilities possumbilities added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 24, 2023
@possumbilities
Copy link
Contributor

possumbilities commented Mar 24, 2023

@Lakshay-Pruthi The favicons and app Icons are currently missing intentionally while it's sorted out the best way to utilize them going forward. A lot of the existing use-cases need to be vetted before we go forward rather than continuing with what we've done in existing repositories.

One way you could help move this forward would be to see what the current recommended standards are for this area of implementation and list them here as a comment. (Also anyone else in the community can do the same if you see this!) As with anything I would assume there's some variation and it's worth listing any variations and their merits so a decision can be reached about their use.

Moving to a status: blocked until a route is outlined and agreed upon forward.

It's good that this Issue was added, because it documents that this is missing and gives us a place to discuss how it'll be implemented going forward.

If in the end the results are that what we've been doing is fine to continue with then we'll move to to status: ready for work and proceed, which is why I'm leaving #8 open for now :)

@possumbilities possumbilities changed the title Favicon not present on website Favicon and app icons not present on website Mar 24, 2023
@Lakshay-Pruthi
Copy link
Author

@possumbilitiesI I don't think there are any kind of fixed standards for the usage. I would recommend using multiple sizes of the app icon so that it looks good on all devices and a transparent background for the icon to ensure it looks good on different backgrounds as well.

@possumbilities
Copy link
Contributor

Completed by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work
Projects
None yet
3 participants