feat(wafv2): add webacl [WIP] #2152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teeverr
force-pushed
the
feature/wafv2-webacl
branch
from
407e11f to
44ba5bf
Compare
|
Needs rebase on #2154 (or master if it is merged). |
MisterMX
reviewed
Feb 3, 2025
Comment on lines
1
to
9
| # NOTE(teeverr): this config file was used for generation of types WAFV2 API(make services SERVICES=wafv2) via ack-code-generator v0.38.1, | ||
| # then these types where backported to v0.28.1(current version in January 2025), and then the controller code was generated(make generate) by ack-code-generator v0.28.1. | ||
| # The reason is that ack-code-generator support specific options(which are needed) like empty shapes and set[].ignore only since version v0.38.0, but this version | ||
| # requires rigs.k8s.io/controller-runtime v0.18.4(current version is v0.17.0) and controller-runtime in turn requires | ||
| # crossplane-runtime(>=1.17). But newer versions of crossplane-runtime bring a new additinal method `Disconnect()` to `external` | ||
| # object, Delete method also has been changed(probably something else). But ack-code-generator doesn't generate it for crossplane. | ||
| # It means ack-code-generator should be enhanced to generate relevant controller code for newer versions of crossplane-runtime | ||
| # In addition, it is required that all manually written controllers be updated to accommodate these new methods. | ||
| # This far away from my current story - add support for wafv2 webacl. |
There was a problem hiding this comment.
Is the ACK update necessary to include custom status update? If yes, this can be done with #2161 already.
There was a problem hiding this comment.
No, it is totally redundant. Thanks for noticing. I removed the custom status fields.
Originally I used this config as an example/tip when I was looking for how to implement wafv2, but then I forgot about output fields.
Needs rebase on #2154 (or master if it is merged).
Done.
teeverr
force-pushed
the
feature/wafv2-webacl
branch
from
d41170e to
8de059e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings wafv2 WebACL.
https://docs.aws.amazon.com/waf/latest/APIReference/API_WebACL.html
The resource works but testing is still in progress. It would be nice to get some feedback, that's why the PR is open.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Testing in progress, it takes time due to a massive combination of parameters and infinite recursion for some fields. The unit tests will be extended soon.