Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Notification Service 'update' Toasts Use Incorrect Class Name #2997

Open
1 task done
phroggster opened this issue Feb 15, 2025 · 0 comments
Open
1 task done
Labels
Bug A defect in the app Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.

Comments

@phroggster
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Update notification alerts use a toastClass of "warn" when "warning" was likely intended.

ngToast docs (unversioned)
Bootstrap 3.4 docs

Expected Behavior

Not to waste an hour and a half of my time to file a virtually meaningless bug report for an unreleased feature that no one has ever seen, when it takes 20 seconds to submit a 3-letter PR.

The smell of toast without the associated ever-increasing-in-frequency stroke.

Steps To Reproduce

  1. Start the Firebot nightly or run from source in the v5 branch.
  2. Add and commit an "update" message to the metadata branch in notifications/notifications.json.
  3. Wait for the toast to cook.

Version

5.64-sources

What operating system are you using Firebot on?

Windows 10

Relevant log output

Contact Details (Optional)

No response

@phroggster phroggster added the Bug A defect in the app label Feb 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in Firebot Feb 15, 2025
phroggster added a commit to phroggster/Firebot that referenced this issue Feb 15, 2025
@phroggster phroggster added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.
Projects
Status: Todo
Development

No branches or pull requests

1 participant