perf: Make recheck not re-run validate basic (cosmos#20208) (#871)

mmsqe · ValarDragon · yihuang · web-flow · commit d9bb1b6d4ee8 · 2025-01-09T10:06:15.000+08:00
Signed-off-by: yihuang &lt;huang@crypto.com&gt;
Co-authored-by: Dev Ojha &lt;ValarDragon@users.noreply.github.com&gt;
Co-authored-by: yihuang &lt;huang@crypto.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -68,6 +68,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (server) [#21941](https://github.com/cosmos/cosmos-sdk/pull/21941) Regenerate addrbook.json for in place testnet.
 * (store) [#923](https://github.com/crypto-org-chain/cosmos-sdk/pull/923) Enable iavl async pruning.
 * (store) [#934](https://github.com/crypto-org-chain/cosmos-sdk/pull/934) Add pause pruning.
+* (baseapp) [#20208](https://github.com/cosmos/cosmos-sdk/pull/20208) Skip running validateBasic for rechecking txs.
 
 ### Bug Fixes
 
diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go
@@ -915,8 +915,12 @@ func (app *BaseApp) runTxWithMultiStore(
 	}
 
 	msgs := tx.GetMsgs()
-	if err := validateBasicTxMsgs(msgs); err != nil {
-		return sdk.GasInfo{}, nil, nil, err
+	// run validate basic if mode != recheck.
+	// as validate basic is stateless, it is guaranteed to pass recheck, given that its passed checkTx.
+	if mode != execModeReCheck {
+		if err := validateBasicTxMsgs(msgs); err != nil {
+			return sdk.GasInfo{}, nil, nil, err
+		}
 	}
 
 	for _, msg := range msgs {

Original file line number	Diff line number	Diff line change
`@@ -915,8 +915,12 @@ func (app *BaseApp) runTxWithMultiStore(`
`915`	`915`	`}`
`916`	`916`
`917`	`917`	`msgs := tx.GetMsgs()`
`918`		`- if err := validateBasicTxMsgs(msgs); err != nil {`
`919`		`- return sdk.GasInfo{}, nil, nil, err`
	`918`	`+ // run validate basic if mode != recheck.`
	`919`	`+ // as validate basic is stateless, it is guaranteed to pass recheck, given that its passed checkTx.`
	`920`	`+ if mode != execModeReCheck {`
	`921`	`+ if err := validateBasicTxMsgs(msgs); err != nil {`
	`922`	`+ return sdk.GasInfo{}, nil, nil, err`
	`923`	`+ }`
`920`	`924`	`}`
`921`	`925`
`922`	`926`	`for _, msg := range msgs {`