Skip to content

coverage report ideas #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xalpharush opened this issue Mar 11, 2024 · 6 comments
Open

coverage report ideas #325

0xalpharush opened this issue Mar 11, 2024 · 6 comments

Comments

@0xalpharush
Copy link
Contributor

  • Show conditions that have only take success case in yellow instead of green (related Calculate and show branch coverage per file  #285)
  • Right now all coverage files are expanded by default and I have to minimize each one to be able to find the one I'm interested in. We should minimize all of them by default and maybe have a search bar for filename and maybe contract name (eventually function but not priority)
  • Create a toggle for "stateful" coverage and exclude external, view/pure functions from coverage calculations and do not show them in red if they're not hit
@0xicingdeath
Copy link

0xicingdeath commented Mar 12, 2024

There is a branch somewhere to collapse all the files and expand all of them that @Xenomega was working on; as well as a file tree for easier parsing / access!

Edit: #302

@aviggiano
Copy link

Another idea is to filter all library files by default (e.g. OpenZeppelin files, etc)

@PoeAudits
Copy link

Or allow users to specify which files to include in the report, or at least sort them by test > src > lib. They are currently sorted alphabetically, even just reversing the order would be a significant improvement since it starts with lib.

@simon-something
Copy link

simon-something commented Feb 4, 2025

Is #302 still actively worked on? A simple collapse all button would be a huge improvement in quality-of-life :D
I (or someone from @defi_wonderland ) can try to take it over if needed (yeah, that desperate about it, html is sometime more readable than cov gutter imo)

@anishnaik
Copy link
Collaborator

@simon-something thanks for bringing this to my attention :) We'll go ahead and merge the PR as-is so that y'all have what you need. The reason we didn't originally merge it is because we wanted to add a few more features but never got back to it.

We'll try to add those features in the future but hopefully the new buttons should help.

@simon-something
Copy link

@anishnaik thanks for the quick follow-up, I just tried it and it's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants