Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'textDecoration2' needs to use a different font #31

Open
carlosame opened this issue Jun 5, 2021 · 1 comment
Open

Test 'textDecoration2' needs to use a different font #31

carlosame opened this issue Jun 5, 2021 · 1 comment
Labels
good first issue Good for newcomers tests Related to tests

Comments

@carlosame
Copy link
Member

The test SamplesRenderingTest.testTextDecoration2() (which renders samples/tests/spec/text/textDecoration2.svg) fails. The expected result is on the left:

textDecoration2_cmp

The reason of the failure is that the two images are rendering a different font: the original (on the left) uses the non-free Lucida Sans Typewriter while the current test (on the right) uses NotCourierSans. The font faces are obviously different and that was expected, but a few decorations are lost and the problem is clearly related to the new font (when the old font is used, the test passes).

Either a new free font has to be used, or go back to the old test which uses the non-free font Lucida Sans Typewriter.

@carlosame carlosame added the tests Related to tests label Jun 5, 2021
@carlosame carlosame added the good first issue Good for newcomers label Apr 2, 2022
carlosame added a commit that referenced this issue Jul 31, 2023
A non-free font is better than a disabled test, see #31 for details.
@carlosame
Copy link
Member Author

The test currently uses the non-free font Lucida Sans Typewriter, if anyone is aware of a free equivalent font please comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests Related to tests
Projects
None yet
Development

No branches or pull requests

1 participant