Skip to content

Commit ff40fc9

Browse files
authored
Update Thrift to eac4d0c79a5f (osquery#84)
Fix breaking changes with socket timeouts Fixes osquery#81
1 parent a74aa86 commit ff40fc9

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

go.mod

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@ module github.com/kolide/osquery-go
22

33
require (
44
github.com/Microsoft/go-winio v0.4.9
5-
github.com/apache/thrift v0.12.0
5+
github.com/apache/thrift v0.13.1-0.20200603211036-eac4d0c79a5f
66
github.com/davecgh/go-spew v1.1.0 // indirect
77
github.com/pkg/errors v0.8.0
88
github.com/pmezard/go-difflib v1.0.0 // indirect
99
github.com/stretchr/testify v1.2.2
1010
golang.org/x/sys v0.0.0-20180815093151-14742f9018cd // indirect
1111
)
12+
13+
go 1.13

go.sum

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
github.com/Microsoft/go-winio v0.4.9 h1:3RbgqgGVqmcpbOiwrjbVtDHLlJBGF6aE+yHmNtBNsFQ=
22
github.com/Microsoft/go-winio v0.4.9/go.mod h1:VhR8bwka0BXejwEJY73c50VrPtXAaKcyvVC4A4RozmA=
3-
github.com/apache/thrift v0.12.0 h1:pODnxUFNcjP9UTLZGTdeh+j16A8lJbRvD3rOtrk/7bs=
4-
github.com/apache/thrift v0.12.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
3+
github.com/apache/thrift v0.13.0 h1:5hryIiq9gtn+MiLVn0wP37kb/uTeRZgN08WoCsAhIhI=
4+
github.com/apache/thrift v0.13.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
5+
github.com/apache/thrift v0.13.1-0.20200603211036-eac4d0c79a5f h1:33BV5v3u8I6dA2dEoPuXWCsAaHHOJfPtdxZhAMQV4uo=
6+
github.com/apache/thrift v0.13.1-0.20200603211036-eac4d0c79a5f/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
57
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
68
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
79
github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw=

server_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func testShutdownDeadlock(t *testing.T) {
124124
addr, err := net.ResolveUnixAddr("unix", listenPath)
125125
require.Nil(t, err)
126126
timeout := 500 * time.Millisecond
127-
trans := thrift.NewTSocketFromAddrTimeout(addr, timeout)
127+
trans := thrift.NewTSocketFromAddrTimeout(addr, timeout, timeout)
128128
err = trans.Open()
129129
require.Nil(t, err)
130130
client := osquery.NewExtensionManagerClientFactory(trans,

transport/transport.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func Open(sockPath string, timeout time.Duration) (*thrift.TSocket, error) {
2828
return nil, errors.Wrapf(err, "waiting for unix socket to be available: %s", sockPath)
2929
}
3030

31-
trans := thrift.NewTSocketFromAddrTimeout(addr, timeout)
31+
trans := thrift.NewTSocketFromAddrTimeout(addr, timeout, timeout)
3232
if err := trans.Open(); err != nil {
3333
return nil, errors.Wrap(err, "opening socket transport")
3434
}

0 commit comments

Comments
 (0)