Merge tag 'v0.14.1' into Jorge_TriggerReader

test last version of ctlearn

Author: jbuces

.zenodo.json

@@ -1,6 +1,12 @@
 {
     "license": "MIT", 
     "contributors": [
+        {
+            "affiliation": "Instituto de F\u00edsica de Part\u00edculas y del Cosmos, Departamento de EMFTEL, Universidad Complutense de Madrid, Madrid, Spain ",
+            "name": "Cervi\u00f1o Cort\u00ednez, Alexander",
+            "type": "Researcher",
+            "orcid": "0009-0007-1566-9507"
+        },
         {
             "orcid": "0000-0002-5686-2078", 
             "affiliation": "Laboratoire d'Annecy de Physique des Particules, CNRS, Universit\u00e9 Savoie Mont-Blanc, Annecy, France", 
@@ -12,12 +18,6 @@
             "affiliation": "Instituto de F\u00edsica de Part\u00edculas y del Cosmos and Departamento de EMFTEL, Universidad Complutense de Madrid, Madrid, Spain", 
             "type": "Researcher", 
             "name": "Jos\u00e9 Luis Contreras"
-        },
-        {
-            "orcid": "0009-0007-1566-9507", 
-            "affiliation": "Instituto de F\u00edsica de Part\u00edculas y del Cosmos and Departamento de EMFTEL, Universidad Complutense de Madrid, Madrid, Spain", 
-            "type": "Researcher", 
-            "name": "Alexander Cervi\u00f1o"
         }
     ], 
     "language": "eng", 
@@ -31,7 +31,7 @@
     ], 
      "creators": [
         {
-            "orcid": "0000-0003-1821-7964"
+            "orcid": "0000-0003-1821-7964",
             "affiliation": "Universit\u00e9 de Gen\u00e8ve, D\u00e9partement de physique nucl\u00e9aire et corpusculaire, Gen\u00e8ve, Suisse", 
             "name": "Tjark Miener"
         }, 

README.rst

@@ -43,7 +43,7 @@ necessary package channels, and install dl1-data-handler specified version and i
 
 .. code-block:: bash
 
-   DL1DH_VER=0.14.0
+   DL1DH_VER=0.14.1
    wget https://raw.githubusercontent.com/cta-observatory/dl1-data-handler/v$DL1DH_VER/environment.yml
    conda env create -n [ENVIRONMENT_NAME] -f environment.yml
    conda activate [ENVIRONMENT_NAME]
@@ -56,7 +56,7 @@ Links
 -----
 
 
-* `Cherenkov Telescope Array (CTA) <https://www.ctao.org/>`_ - Homepage of the CTA Observatory 
+* `Cherenkov Telescope Array Observatory (CTAO) <https://www.ctao.org/>`_ - Homepage of the CTA Observatory
 * `CTLearn <https://github.com/ctlearn-project/ctlearn/>`_ and `GammaLearn <https://gitlab.lapp.in2p3.fr/GammaLearn/GammaLearn>`_ - Repository of code for studies on applying deep learning to IACT analysis tasks. Maintained by groups at Universidad Complutense de Madrid, University of Geneva (CTLearn) and LAPP (GammaLearn).
 * `ctapipe <https://cta-observatory.github.io/ctapipe/>`_ - Official documentation for the ctapipe analysis package (in development)
 

dl1_data_handler/reader.py

@@ -295,6 +295,15 @@ def __init__(
         if selected_tel_ids is not None:
             self.subarray = self.subarray.select_subarray(selected_tel_ids)
         self.tel_ids = self.subarray.tel_ids
+        # Copy the pixel rotation of the camera geometry for each telescope of the subarray
+        # in a variable since the ImageMapper will derotate the pixels. The pixel rotation
+        # is needed to create a rotated camera frame in order to transform the true Alt/Az
+        # coordinates to correct camera coordinate offsets.
+        self.pix_rotation = {}
+        for tel_id in self.tel_ids:
+            self.pix_rotation[tel_id] = self.subarray.tel[
+                tel_id
+            ].camera.geometry.pix_rotation
         self.selected_telescopes = {}
         for tel_type in self.subarray.telescope_types:
             # If is needed here for some sims where the same tel_type is stored twice
@@ -836,7 +845,7 @@ def _transform_to_cam_coord_offsets(self, table) -> Table:
         # Set the camera frame with the focal length and rotation of the camera
         camera_frame = CameraFrame(
             focal_length=self.subarray.tel[tel_id].optics.equivalent_focal_length,
-            rotation=self.subarray.tel[tel_id].camera.geometry.pix_rotation,
+            rotation=self.pix_rotation[tel_id],
             telescope_pointing=fix_tel_pointing,
         )
         # Transform the true Alt/Az coordinates to camera coordinates