Choose LightNectarCAMEventSource or not in BaseNectarCAMCalibrationTool (#299)

* add boolean to choose the NectarCAMEventSource (instead of the Light one) in the BaseNectarCAMCalibrationTool

* More modifications to allow the choice

* Clarification in method description

* Clarification in method description

* Fix bug in case  is provided

---------

Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr>

Author: frnbrun

src/nectarchain/makers/core.py

@@ -20,7 +20,7 @@
 )
 from ctapipe.io import HDF5TableWriter
 from ctapipe.io.datawriter import DATA_MODEL_VERSION
-from ctapipe_io_nectarcam import LightNectarCAMEventSource
+from ctapipe_io_nectarcam import LightNectarCAMEventSource, NectarCAMEventSource
 from ctapipe_io_nectarcam.containers import NectarCAMDataContainer
 from tables.exceptions import HDF5ExtError
 from tqdm.auto import tqdm
@@ -77,7 +77,8 @@ def load_run(
         max_events: int = None,
         run_file: str = None,
         camera: int = [camera for camera in ALLOWED_CAMERAS if "QM" in camera][0],
-    ) -> LightNectarCAMEventSource:
+        use_lightevtsource: bool = True,
+    ) -> LightNectarCAMEventSource | NectarCAMEventSource:
         """Static method to load from $NECTARCAMDATA directory data for specified run
         with max_events.
 
@@ -91,24 +92,38 @@ def load_run(
             if provided, will load this run file
         camera : str
             camera for which data are processed. (Default: NectarCAMQM)
+        use_lightevtsource : bool, optional
+            if False the NectarCAMEventSource will be used (Default :
+            LightNectarCAMEventSource), allowing to load the FEB data
 
         Returns
         -------
-        List[ctapipe_io_nectarcam.LightNectarCAMEventSource]
+        List[ctapipe_io_nectarcam.(Light)NectarCAMEventSource]
             List of EventSource for each run files.
         """
         # Load the data from the run file.
         if run_file is None:
             generic_filename, _ = DataManagement.findrun(run_number, camera=camera)
             log.info(f"{str(generic_filename)} will be loaded")
-            eventsource = LightNectarCAMEventSource(
-                input_url=generic_filename, max_events=max_events
-            )
+            if use_lightevtsource:
+                eventsource = LightNectarCAMEventSource(
+                    input_url=generic_filename, max_events=max_events
+                )
+            else:
+                eventsource = NectarCAMEventSource(
+                    input_url=generic_filename, max_events=max_events
+                )
         else:
             log.info(f"{run_file} will be loaded")
-            eventsource = LightNectarCAMEventSource(
-                input_url=run_file, max_events=max_events
-            )
+            if use_lightevtsource:
+                eventsource = LightNectarCAMEventSource(
+                    input_url=run_file, max_events=max_events
+                )
+            else:
+                eventsource = NectarCAMEventSource(
+                    input_url=run_file, max_events=max_events
+                )
+
         return eventsource
 
 
@@ -122,6 +137,8 @@ class EventsLoopNectarCAMCalibrationTool(BaseNectarCAMCalibrationTool):
         max_events (int, optional): The maximum number of events to be loaded.
         Defaults to None.
         run_file (optional): The specific run file to be loaded.
+        use_lightevtsource (bool, optional): Whether or not use the
+        LightNectarCAMEventSource. Defaults to True.
 
     Example Usage:
         maker = EventsLoopMaker(run_number=1234, max_events=1000)
@@ -144,6 +161,7 @@ class EventsLoopNectarCAMCalibrationTool(BaseNectarCAMCalibrationTool):
         ("m", "max-events"): "EventsLoopNectarCAMCalibrationTool.max_events",
         ("o", "output"): "EventsLoopNectarCAMCalibrationTool.output_path",
         "events-per-slice": "EventsLoopNectarCAMCalibrationTool.events_per_slice",
+        "use_lightevtsource": "EventsLoopNectarCAMCalibrationTool.use_lightevtsource",
     }
 
     flags = {
@@ -164,6 +182,7 @@ class EventsLoopNectarCAMCalibrationTool(BaseNectarCAMCalibrationTool):
             HDF5TableWriter,
         ]
         + classes_with_traits(LightNectarCAMEventSource)
+        + classes_with_traits(NectarCAMEventSource)
         + classes_with_traits(NectarCAMComponent)
     )
 
@@ -209,6 +228,13 @@ class EventsLoopNectarCAMCalibrationTool(BaseNectarCAMCalibrationTool):
         allow_none=True,
     ).tag(config=True)
 
+    use_lightevtsource = Bool(
+        help="Indicate to use the LightNectarCAMEventSource or not."
+        "If True, no FEB info is loaded (faster).",
+        default_value=True,
+        allow_none=True,
+    ).tag(config=True)
+
     def __new__(cls, *args, **kwargs):
         """This method is used to pass to the current instance of Tool the traits
         defined in the components provided in the componentsList trait.
@@ -255,6 +281,7 @@ def _load_eventsource(self, *args, **kwargs):
                 self.max_events,
                 run_file=self.run_file,
                 camera=self.camera,
+                use_lightevtsource=self.use_lightevtsource,
             )
         )
 
@@ -546,15 +573,21 @@ def event_source(self):
     @event_source.setter
     def event_source(self, value):
         """
-        Setter method to set a new LightNectarCAMEventSource to the _reader attribute.
+        Setter method to set a new LightNectarCAMEventSource or NectarCAMEventSource
+        to the _reader attribute.
 
         Args:
-            value: a LightNectarCAMEventSource instance.
+            value: a LightNectarCAMEventSource or NectarCAMEventSource instance.
         """
-        if isinstance(value, LightNectarCAMEventSource):
+        if isinstance(value, LightNectarCAMEventSource) or isinstance(
+            value, NectarCAMEventSource
+        ):
             self._event_source = value
         else:
-            raise TypeError("The reader must be a LightNectarCAMEventSource")
+            raise TypeError(
+                "The reader must be a LightNectarCAMEventSource"
+                "or a NectarCAMEventSource."
+            )
 
     @property
     def _npixels(self):