eslint: remove globals (#1023)

Author: charlierudolph

.eslintrc.yml

@@ -5,14 +5,6 @@ env:
 extends:
   - standard
   - prettier
-globals:
-  afterEach: false
-  beforeEach: false
-  createMock: false
-  describe: false
-  expect: false
-  it: false
-  sinon: false
 parser: babel-eslint
 parserOptions:
   sourceType: module

dependency-lint.yml

@@ -51,6 +51,7 @@ requiredModules:
       - '{features,scripts,test}/**/*'
       - '**/*_spec.js'
       - 'example/index.js'
+      - '**/test_helpers.js'
     ignore:
       - 'dist/**/*'
       - 'node_modules/**/*'

src/cli/configuration_builder_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import { promisify } from 'bluebird'
 import ConfigurationBuilder from './configuration_builder'
 import fsExtra from 'fs-extra'

src/cli/helpers_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import sinon from 'sinon'
 import { getTestCasesFromFilesystem } from './helpers'
 import { promisify } from 'bluebird'
 import EventEmitter from 'events'

src/cli/option_splitter_spec.js

@@ -1,3 +1,5 @@
+import { describe, it } from 'mocha'
+import { expect } from 'chai'
 import OptionSplitter from './option_splitter'
 
 describe('OptionSplitter', () => {

src/cli/profile_loader_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import { promisify } from 'bluebird'
 import fs from 'mz/fs'
 import path from 'path'

src/formatter/helpers/issue_helpers_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import { createMock } from '../test_helpers'
 import getColorFns from '../get_color_fns'
 import Status from '../../status'
 import { formatIssue } from './issue_helpers'

src/formatter/helpers/keyword_type_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import KeywordType, { getStepKeywordType } from './keyword_type'
 
 describe('KeywordType', () => {

src/formatter/helpers/summary_helpers_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import getColorFns from '../get_color_fns'
 import { formatSummary } from './summary_helpers'
 import Status from '../../status'

src/formatter/helpers/usage_helpers/index_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import { getUsage } from './'
 import EventEmitter from 'events'
 import Gherkin from 'gherkin'

src/formatter/json_formatter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import JsonFormatter from './json_formatter'
 import Status from '../status'
 import EventEmitter from 'events'

src/formatter/progress_bar_formatter_spec.js

@@ -1,3 +1,7 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import { createMock } from './test_helpers'
+import sinon from 'sinon'
 import getColorFns from './get_color_fns'
 import ProgressBarFormatter from './progress_bar_formatter'
 import Status from '../status'

src/formatter/progress_formatter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import getColorFns from './get_color_fns'
 import ProgressFormatter from './progress_formatter'
 import Status from '../status'

src/formatter/rerun_formatter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import _ from 'lodash'
 import path from 'path'
 import RerunFormatter from './rerun_formatter'

src/formatter/step_definition_snippet_builder/index_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import { createMock } from '../test_helpers'
 import { KeywordType } from '../helpers'
 import StepDefinitionSnippetBuilder from './'
 import TransformLookupBuilder from '../../support_code_library_builder/parameter_type_registry_builder'

src/formatter/step_definition_snippet_builder/javascript_snippet_syntax_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import JavascriptSnippetSyntax from './javascript_snippet_syntax'
 
 describe('JavascriptSnippetSyntax', () => {

src/formatter/summary_formatter_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import { createMock } from './test_helpers'
 import getColorFns from './get_color_fns'
 import Status from '../status'
 import SummaryFormatter from './summary_formatter'

src/formatter/test_helpers.js

@@ -0,0 +1,9 @@
+import _ from 'lodash'
+import sinon from 'sinon'
+
+export function createMock(input) {
+  if (_.isArray(input)) {
+    input = _.zipObject(input)
+  }
+  return _.mapValues(input, value => sinon.stub().returns(value))
+}

src/formatter/usage_formatter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import UsageFormatter from './usage_formatter'
 import EventEmitter from 'events'
 import Gherkin from 'gherkin'

src/formatter/usage_json_formatter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import UsageJsonFormatter from './usage_json_formatter'
 import EventEmitter from 'events'
 import Gherkin from 'gherkin'

src/models/data_table_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import DataTable from './data_table'
 
 describe('DataTable', () => {

src/models/test_case_hook_definition_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import TestCaseHookDefinition from './test_case_hook_definition'
 
 describe('TestCaseHookDefinition', () => {

src/pickle_filter_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import PickleFilter from './pickle_filter'
 
 describe('PickleFilter', () => {

src/runtime/attachment_manager/index_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import sinon from 'sinon'
 import AttachmentManager from './'
 import stream from 'stream'
 

src/runtime/helpers_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import { getAmbiguousStepException } from './helpers'
 
 describe('Helpers', () => {

src/runtime/test_case_runner_spec.js

@@ -1,3 +1,6 @@
+import { afterEach, beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import sinon from 'sinon'
 import TestCaseHookDefinition from '../models/test_case_hook_definition'
 import TestCaseRunner from './test_case_runner'
 import Status from '../status'

src/status_spec.js

@@ -1,3 +1,5 @@
+import { describe, it } from 'mocha'
+import { expect } from 'chai'
 import Status, { getStatusMapping } from './status'
 
 describe('Status', () => {

src/support_code_library_builder/index_spec.js

@@ -1,3 +1,6 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
+import sinon from 'sinon'
 import { ParameterTypeRegistry } from 'cucumber-expressions'
 import supportCodeLibraryBuilder from './'
 

src/user_code_runner_spec.js

@@ -1,3 +1,5 @@
+import { beforeEach, describe, it } from 'mocha'
+import { expect } from 'chai'
 import UserCodeRunner from './user_code_runner'
 import Promise from 'bluebird'
 

test/listener_helpers.js

@@ -1,3 +1,5 @@
+import { expect } from 'chai'
+
 export function expectToHearEvents(listener, expectedEvents) {
   let previousStub = null
   const callNumberMapping = {}

test/test_helper.js

@@ -1,21 +1,5 @@
-import _ from 'lodash'
 import 'regenerator-runtime/runtime'
 import chai from 'chai'
-import sinon from 'sinon'
 import sinonChai from 'sinon-chai'
 
 chai.use(sinonChai)
-
-function createMock(input) {
-  if (_.isArray(input)) {
-    input = _.zipObject(input)
-  }
-  return _.mapValues(input, value => sinon.stub().returns(value))
-}
-
-_.assign(global, {
-  chai,
-  createMock,
-  expect: chai.expect,
-  sinon
-})