Skip to content

Commit b7de87e

Browse files
charlierudolphcharlierudolph
authored
cleanup binaries (#1020)
1 parent 8eb3145 commit b7de87e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+159
-166
lines changed

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO
66

77
* cucumber now waits for the event loop to drain before exiting. To exit immediately when the tests finish running use `--exit`. Use of this flag is discouraged. See [here](/docs/cli.md#exiting) for more information
88
* remove `--compiler` option. See [here](/docs/cli.md#transpilers) for the new way to use transpilers
9+
* remove binaries `cucumber.js` and `cucumberjs`. Use `cucumber-js`
910

1011
#### New Features
1112

‎bin/cucumber.js renamed to ‎bin/cucumber-js

File renamed without changes.

‎docs/cli.md

+6-12
Original file line numberDiff line numberDiff line change
@@ -3,30 +3,24 @@
33
Cucumber.js includes a executable file to run the features. After installing Cucumber in your project, you can run it with:
44

55
``` shell
6-
$ ./node_modules/.bin/cucumber.js
6+
$ ./node_modules/.bin/cucumber-js
77
```
88

9-
The executable is also aliased as `cucumber-js` and `cucumberjs`.
10-
11-
**Note to Windows users:** Use `cucumber-js` or `cucumberjs` instead of `cucumber.js`.
12-
The latter is causing the operating system to invoke JScript instead of Node.js,
13-
because of the file extension.
14-
159
**Note on global installs:** Cucumber does not work when installed globally because cucumber
1610
needs to be required in your support files and globally installed modules cannot be required.
1711

1812
## Running specific features
1913

2014
* Specify a [glob](https://github.com/isaacs/node-glob) pattern
21-
* `$ cucumber.js features/**/*.feature`
15+
* `$ cucumber-js features/**/*.feature`
2216
* Specify a feature directory
23-
* `$ cucumber.js features/dir`
17+
* `$ cucumber-js features/dir`
2418
* Specify a feature file
25-
* `$ cucumber.js features/my_feature.feature`
19+
* `$ cucumber-js features/my_feature.feature`
2620
* Specify a scenario by its line number
27-
* `$ cucumber.js features/my_feature.feature:3`
21+
* `$ cucumber-js features/my_feature.feature:3`
2822
* Specify a scenario by its name matching a regular expression
29-
* `$ cucumber.js --name "topic 1"`
23+
* `$ cucumber-js --name "topic 1"`
3024
* If used multiple times, the scenario name needs to match only one of the names supplied
3125
* Use [Tags](#tags)
3226

‎features/ambiguous_step.feature

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Feature: Ambiguous Steps
1414
When(/^a ambiguous step$/, function() {});
1515
When(/^a (.*) step$/, function(status) {});
1616
"""
17-
When I run cucumber.js with `-f progress`
17+
When I run cucumber-js with `-f progress`
1818
Then it outputs the text:
1919
"""
2020
A

‎features/attachments.feature

+6-6
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Feature: Attachments
2323
this.attach(new Buffer([137, 80, 78, 71]), 'image/png')
2424
})
2525
"""
26-
When I run cucumber.js
26+
When I run cucumber-js
2727
Then the "Before" hook has the attachment
2828
| DATA | MIME TYPE |
2929
| iVBORw== | image/png |
@@ -42,7 +42,7 @@ Feature: Attachments
4242
passThroughStream.end()
4343
})
4444
"""
45-
When I run cucumber.js
45+
When I run cucumber-js
4646
Then the "Before" hook has the attachment
4747
| DATA | MIME TYPE |
4848
| iVBORw== | image/png |
@@ -62,7 +62,7 @@ Feature: Attachments
6262
return promise
6363
})
6464
"""
65-
When I run cucumber.js
65+
When I run cucumber-js
6666
Then the "Before" hook has the attachment
6767
| DATA | MIME TYPE |
6868
| iVBORw== | image/png |
@@ -76,7 +76,7 @@ Feature: Attachments
7676
this.attach("text")
7777
})
7878
"""
79-
When I run cucumber.js
79+
When I run cucumber-js
8080
Then the "Before" hook has the attachment
8181
| DATA | MIME TYPE |
8282
| text | text/plain |
@@ -90,7 +90,7 @@ Feature: Attachments
9090
this.attach("text")
9191
})
9292
"""
93-
When I run cucumber.js
93+
When I run cucumber-js
9494
Then the "After" hook has the attachment
9595
| DATA | MIME TYPE |
9696
| text | text/plain |
@@ -104,7 +104,7 @@ Feature: Attachments
104104
this.attach("text")
105105
})
106106
"""
107-
When I run cucumber.js
107+
When I run cucumber-js
108108
Then the step "a step" has the attachment
109109
| DATA | MIME TYPE |
110110
| text | text/plain |

‎features/background.feature

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Feature: Background
1616
Scenario: a scenario
1717
When a scenario step
1818
"""
19-
When I run cucumber.js
19+
When I run cucumber-js
2020
Then it fails
2121
And the scenario "a scenario" has the steps
2222
| IDENTIFIER |
@@ -36,7 +36,7 @@ Feature: Background
3636
Scenario: another scenario
3737
When another scenario step
3838
"""
39-
When I run cucumber.js
39+
When I run cucumber-js
4040
Then it fails
4141
And the scenario "a scenario" has the steps
4242
| IDENTIFIER |

‎features/before_after_all_hook_interfaces.feature

+10-10
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Feature: before / after all hook interfaces
2828
2929
<TYPE>(function() {})
3030
"""
31-
When I run cucumber.js
31+
When I run cucumber-js
3232
Then it passes
3333

3434
Examples:
@@ -45,7 +45,7 @@ Feature: before / after all hook interfaces
4545
throw new Error('my error')
4646
})
4747
"""
48-
When I run cucumber.js
48+
When I run cucumber-js
4949
Then it fails
5050

5151
Examples:
@@ -62,7 +62,7 @@ Feature: before / after all hook interfaces
6262
setTimeout(callback)
6363
})
6464
"""
65-
When I run cucumber.js
65+
When I run cucumber-js
6666
Then it passes
6767

6868
Examples:
@@ -81,7 +81,7 @@ Feature: before / after all hook interfaces
8181
})
8282
})
8383
"""
84-
When I run cucumber.js
84+
When I run cucumber-js
8585
Then it fails
8686
And the error output contains the text:
8787
"""
@@ -105,7 +105,7 @@ Feature: before / after all hook interfaces
105105
})
106106
})
107107
"""
108-
When I run cucumber.js
108+
When I run cucumber-js
109109
Then it fails
110110
And the error output contains the text:
111111
"""
@@ -127,7 +127,7 @@ Feature: before / after all hook interfaces
127127
return Promise.resolve()
128128
})
129129
"""
130-
When I run cucumber.js
130+
When I run cucumber-js
131131
Then it fails
132132
And the error output contains the text:
133133
"""
@@ -151,7 +151,7 @@ Feature: before / after all hook interfaces
151151
return Promise.resolve()
152152
})
153153
"""
154-
When I run cucumber.js
154+
When I run cucumber-js
155155
Then it passes
156156

157157
Examples:
@@ -169,7 +169,7 @@ Feature: before / after all hook interfaces
169169
return Promise.reject(new Error('my error'))
170170
})
171171
"""
172-
When I run cucumber.js
172+
When I run cucumber-js
173173
Then it fails
174174
And the error output contains the text:
175175
"""
@@ -191,7 +191,7 @@ Feature: before / after all hook interfaces
191191
return Promise.reject()
192192
})
193193
"""
194-
When I run cucumber.js
194+
When I run cucumber-js
195195
Then it fails
196196
And the error output contains the text:
197197
"""
@@ -218,7 +218,7 @@ Feature: before / after all hook interfaces
218218
})
219219
})
220220
"""
221-
When I run cucumber.js
221+
When I run cucumber-js
222222
Then it fails
223223
And the error output contains the text:
224224
"""

‎features/before_after_all_hook_timeouts.feature

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Feature: before / after all hook timeouts
2525
setTimeout(callback, 1000)
2626
})
2727
"""
28-
When I run cucumber.js
28+
When I run cucumber-js
2929
Then it fails
3030
And the error output contains the text snippets:
3131
| a handler errored, process exiting |
@@ -48,7 +48,7 @@ Feature: before / after all hook timeouts
4848
setTimeout(callback, 1000)
4949
})
5050
"""
51-
When I run cucumber.js
51+
When I run cucumber-js
5252
Then it passes
5353

5454
Examples:

‎features/before_after_all_hooks.feature

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Feature: Environment Hooks
4242
counter += counter
4343
})
4444
"""
45-
When I run cucumber.js
45+
When I run cucumber-js
4646
Then it passes
4747

4848
Scenario: Failing before all hook kills the suite
@@ -54,7 +54,7 @@ Feature: Environment Hooks
5454
callback(new Error('my error'))
5555
})
5656
"""
57-
When I run cucumber.js
57+
When I run cucumber-js
5858
Then it fails
5959
And the error output contains the text snippets:
6060
| a BeforeAll hook errored, process exiting |
@@ -70,7 +70,7 @@ Feature: Environment Hooks
7070
callback(new Error('my error'))
7171
})
7272
"""
73-
When I run cucumber.js
73+
When I run cucumber-js
7474
Then it fails
7575
And the error output contains the text snippets:
7676
| an AfterAll hook errored, process exiting |

‎features/cli.feature

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Feature: Command line interface
1616
1717
When(/^a step is passing$/, function() {})
1818
"""
19-
When I run cucumber.js with `-r step_definitions/cucumber_steps.js`
19+
When I run cucumber-js with `-r step_definitions/cucumber_steps.js`
2020

2121
Scenario: run feature with step definitions in required directory (-r option)
2222
Given a file named "features/a.feature" with:
@@ -31,14 +31,14 @@ Feature: Command line interface
3131
3232
When(/^a step is passing$/, function() {});
3333
"""
34-
When I run cucumber.js with `-r step_definitions`
34+
When I run cucumber-js with `-r step_definitions`
3535

3636
@spawn
3737
Scenario: display Cucumber version
38-
When I run cucumber.js with `--version`
38+
When I run cucumber-js with `--version`
3939
Then I see the version of Cucumber
4040

4141
@spawn
4242
Scenario: display help
43-
When I run cucumber.js with `--help`
43+
When I run cucumber-js with `--help`
4444
Then I see the help text for Cucumber

‎features/custom_stack_trace.feature

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ Feature: Custom stack trace
1818
1919
Error.prepareStackTrace = _prepareStackTrace
2020
"""
21-
When I run cucumber.js
21+
When I run cucumber-js
2222
Then it passes

‎features/data_tables.feature

+4-4
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Feature: Data Tables
2222
assert.deepEqual(table.raw(), expected)
2323
})
2424
"""
25-
When I run cucumber.js
25+
When I run cucumber-js
2626
Then it passes
2727

2828
Scenario: rows
@@ -50,7 +50,7 @@ Feature: Data Tables
5050
assert.deepEqual(table.rows(), expected)
5151
})
5252
"""
53-
When I run cucumber.js
53+
When I run cucumber-js
5454
Then it passes
5555

5656
Scenario: rowsHash
@@ -75,7 +75,7 @@ Feature: Data Tables
7575
assert.deepEqual(table.rowsHash(), expected)
7676
})
7777
"""
78-
When I run cucumber.js
78+
When I run cucumber-js
7979
Then it passes
8080

8181
Scenario: hashes
@@ -103,5 +103,5 @@ Feature: Data Tables
103103
assert.deepEqual(table.hashes(), expected)
104104
})
105105
"""
106-
When I run cucumber.js
106+
When I run cucumber-js
107107
Then it passes

‎features/dryrun_mode.feature

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Feature: Dryrun mode
1717
1818
Given('a step', function() {})
1919
"""
20-
When I run cucumber.js with `--dry-run`
20+
When I run cucumber-js with `--dry-run`
2121
Then all steps have status "skipped"
2222

2323
Scenario: ambiguous step
@@ -28,11 +28,11 @@ Feature: Dryrun mode
2828
Given('a step', function() {});
2929
Given('a(n) step', function() {});
3030
"""
31-
When I run cucumber.js with `--dry-run`
31+
When I run cucumber-js with `--dry-run`
3232
Then it fails
3333
And the step "a step" has status "ambiguous"
3434

3535
Scenario: undefined step
36-
When I run cucumber.js with `--dry-run`
36+
When I run cucumber-js with `--dry-run`
3737
Then it fails
3838
And the step "a step" has status "undefined"

‎features/error_formatting.feature

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Feature: Error formatting
1818
1919
Before(function(_, callback) { callback('Fail') })
2020
"""
21-
When I run cucumber.js
21+
When I run cucumber-js
2222
Then it fails
2323
And the output contains the text:
2424
"""
@@ -58,7 +58,7 @@ Feature: Error formatting
5858
Given(/^a step with a doc string$/, function(str) {})
5959
Given(/^a pending step$/, function() { return 'pending' })
6060
"""
61-
When I run cucumber.js
61+
When I run cucumber-js
6262
Then the output contains the text:
6363
"""
6464
Warnings:
@@ -92,7 +92,7 @@ Feature: Error formatting
9292
Given(/^a table:$/, function(table) {})
9393
Given(/^a pending step$/, function() { return 'pending' })
9494
"""
95-
When I run cucumber.js
95+
When I run cucumber-js
9696
Then the output contains the text:
9797
"""
9898
Warnings:

0 commit comments

Comments
 (0)