default to synchronous snippets (#1051)

Author: charlierudolph

features/custom_formatter.feature

@@ -112,9 +112,9 @@ Feature: custom formatter
          ? Given an undefined step
              Undefined. Implement with the following snippet:
 
-               Given('an undefined step', function (callback) {
+               Given('an undefined step', function () {
                  // Write code here that turns the phrase above into concrete actions
-                 callback(null, 'pending');
+                 return 'pending';
                });
 
 

features/snippets_formatter.feature

@@ -18,18 +18,18 @@ Feature: snippets formatter
     Then it fails
     And it outputs the text:
       """
-      Given('undefined step A', function (callback) {
+      Given('undefined step A', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
 
-      When('undefined step B', function (callback) {
+      When('undefined step B', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
 
-      Then('undefined step C', function (callback) {
+      Then('undefined step C', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """

features/step_definition_snippets.feature

@@ -11,9 +11,9 @@ Feature: step definition snippets
     Then it fails
     And the output contains the text:
       """
-      Given('a step numbered {int}', function (int, callback) {
+      Given('a step numbered {int}', function (int) {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """
 
@@ -28,9 +28,9 @@ Feature: step definition snippets
     Then it fails
     And the output contains the text:
       """
-      Given('a step with {string}', function (string, callback) {
+      Given('a step with {string}', function (string) {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """
 
@@ -45,9 +45,9 @@ Feature: step definition snippets
     Then it fails
     And the output contains the text:
       """
-      Given('a step with {string} and {string}', function (string, string2, callback) {
+      Given('a step with {string} and {string}', function (string, string2) {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """
 
@@ -64,8 +64,8 @@ Feature: step definition snippets
     Then it fails
     And the output contains the text:
       """
-      Given('a step with {string}', function (string, callback) {
+      Given('a step with {string}', function (string) {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """

features/step_definition_snippets_i18n.feature

@@ -19,22 +19,22 @@ Feature: step definition snippets i18n
     Then it fails
     And the output contains the text:
       """
-      Given('undefined step A', function (callback) {
+      Given('undefined step A', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """
     And the output contains the text:
       """
-      When('undefined step B', function (callback) {
+      When('undefined step B', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """
     And the output contains the text:
       """
-      Then('undefined step C', function (callback) {
+      Then('undefined step C', function () {
         // Write code here that turns the phrase above into concrete actions
-        callback(null, 'pending');
+        return 'pending';
       });
       """

src/formatter/builder.js

@@ -55,7 +55,7 @@ export default class FormatterBuilder {
     supportCodeLibrary,
   }) {
     if (!snippetInterface) {
-      snippetInterface = 'callback'
+      snippetInterface = 'synchronous'
     }
     let Syntax = JavascriptSnippetSyntax
     if (snippetSyntax) {