Skip to content

Commit a026ba8

Browse files
committed
chore: do not override getLocation for step definitions
See #401 for context
1 parent 6fc0a0e commit a026ba8

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

cucumber-scala/src/main/scala/io/cucumber/scala/ScalaStepDefinition.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ trait ScalaStepDefinition extends StepDefinition with AbstractGlueDefinition {
3535

3636
override def getPattern: String = stepDetails.pattern
3737

38-
// Easier to just print out fileName and lineNumber
39-
override def getLocation(): String =
40-
stepDetails.frame.getFileName + ":" + stepDetails.frame.getLineNumber
41-
4238
}
4339

4440
object ScalaStepDefinition {

cucumber-scala/src/test/scala-2/io/cucumber/scala/ScalaDslStepsTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ class ScalaDslStepsTest {
271271
check: => Boolean
272272
): Unit = {
273273
assertEquals(pattern, stepDefinition.getPattern)
274-
assertEquals(location, stepDefinition.getLocation)
274+
assertTrue(stepDefinition.getLocation.contains(location))
275275
stepDefinition.execute(args)
276276
assertTrue(check)
277277
}

cucumber-scala/src/test/scala-3/io/cucumber/scala/ScalaDslStepsTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ class ScalaDslStepsTest {
271271
check: => Boolean
272272
): Unit = {
273273
assertEquals(pattern, stepDefinition.getPattern)
274-
assertEquals(location, stepDefinition.getLocation)
274+
assertTrue(stepDefinition.getLocation.contains(location))
275275
stepDefinition.execute(args)
276276
assertTrue(check)
277277
}

0 commit comments

Comments
 (0)