Update Transferencia class to remove unnecessary validation checks

Author: gabino

CEP-20241108-BiB202411081016248360.pdf

@@ -1,7 +1,7 @@
 import datetime
 from dataclasses import asdict, dataclass
 from decimal import Decimal
-from typing import Optional, cast
+from typing import cast
 
 import clabe
 from lxml import etree
@@ -51,8 +51,6 @@ def validar(
         client = cls._validar(
             fecha, clave_rastreo, emisor, receptor, cuenta, monto, pago_a_banco
         )
-        if not client:
-            return None
 
         try:
             xml = cls._descargar(client, 'XML')
@@ -123,8 +121,6 @@ def descargar(self, formato: str = 'PDF') -> bytes:
                 self.monto,
                 self.pago_a_banco,
             )
-            if not client:
-                raise CepError
         return self._descargar(client, formato)
 
     def to_dict(self) -> dict:
@@ -139,7 +135,7 @@ def _validar(
         cuenta: str,
         monto: Decimal,
         pago_a_banco: bool = False,
-    ) -> Optional[Client]:
+    ) -> Client:
         assert emisor in clabe.BANKS.values()
         assert receptor in clabe.BANKS.values()
         client = Client()  # Use new client to ensure thread-safeness

cep/transferencia.py

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: tipoCriterio=T&receptorParticipante=0&captcha=c&tipoConsulta=1&fecha=01-01-2019&criterio=guey&emisor=90646&receptor=40012&cuenta=012180004643051249&monto=1111111.0
+    body: tipoCriterio=T&captcha=c&tipoConsulta=1&fecha=01-01-2019&criterio=invalid-clave&emisor=37166&receptor=90723&cuenta=012180004643051249&monto=1111111.0&receptorParticipante=0
     headers:
       Accept:
       - '*/*'
@@ -9,138 +9,74 @@ interactions:
       Connection:
       - keep-alive
       Content-Length:
-      - '163'
+      - '172'
       Content-Type:
       - application/x-www-form-urlencoded
       User-Agent:
       - Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML,
         like Gecko) Chrome/75.0.3770.142 Safari/537.36
     method: POST
-    uri: http://www.banxico.org.mx/cep/valida.do
+    uri: http://www.banxico.org.mx/cep-beta/valida.do
   response:
     body:
-      string: "\n<meta name=\"viewport\" content=\"width=device-width,initial-scale=1,maximum-scale=1.0,user-scalable=no\"
-        />\n<meta charset=\"utf-8\" /> \n<meta http-equiv=\"X-UA-Compatible\" content=\"IE=9;
-        IE=8; IE=7; IE=edge\" />\n<link rel=\"apple-touch-icon\" href=\"images/icon.png\"/>\n<link
-        rel=\"shortcut icon\" href=\"images/icon.png\">\n<!--Bootstrap-->\n<!--<link
-        href=\"//netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap-glyphicons.css\"
-        rel=\"stylesheet\">\n<link rel=stylesheet href=\"css/bootstrap/bootstrap.min.css\"
-        type=\"text/css\">\n<link rel=\"stylesheet\" href=\"css/bootstrap/dataTables.bootstrap.min.css\"
-        type=\"text/css\" >-->\n<link rel=stylesheet href=\"css/fuentes.css\" type=\"text/css\">\n\n
-        \   <link rel=stylesheet href=\"css/cep-min.css\" type=\"text/css\">\n\n<!--
-        JQuery -->\n<script type=\"text/javascript\" src=\"js/jquery-3.0.0.min.js\"></script>\n<script
-        type=\"text/javascript\" src=\"js/jquery-ui.min.js\"></script>\n<script type=\"text/javascript\"
-        src=\"js/jquery/jquery.dataTables.min.js\"></script>\n<script type=\"text/javascript\"
-        src=\"js/datepicker-es.js\"></script>\n\n<!-- Validations -->\n<script type=\"text/javascript\"
-        src=\"js/validations/validateInput.js\"></script>\n<script type=\"text/javascript\"
-        src=\"js/validations/validateEvents.js\"></script>\n<script type=\"text/javascript\"
-        src=\"js/validations/validateWriting.js\"></script>\n<script type=\"text/javascript\"
-        src=\"js/validations/validationBussines.js\"></script>\n\n<!--Bootstrap-->\n<!--<script
-        src=\"js/bootstrap/bootstrap.min.js\"></script>-->\n<!--Bootbox Alert-->\n<!--<script
-        type=\"text/javascript\" src=\"js/bootstrap/bootbox.min.js\"></script>-->\n<!--Bootstrap
-        Tables-->\n<!--<script type=\"text/javascript\" src=\"js/bootstrap/dataTables.bootstrap.min.js\"></script>-->\n\r\n<meta
-        http-equiv=\"Content-type\" content=\"text/html; charset=UTF-8\" /> \r\n<div
-        class=\"bg-banxico title-bar\">\r\n    <i class=\"icono-header icon-list\"></i>\r\n
-        \   Informaci&oacute;n del estado del pago\r\n</div>\r\n<div class=\"cuerpo-msg\"
-        style=\"width: 600px;\">\r\n    <div id=\"consultaMISPEI\" style=\"padding:
-        15px;box-sizing: border-box;overflow-x: auto;\">\r\n        <div class=\"info\"
-        style=\"margin-bottom: 10px;\"><center><strong>Lo sentimos, por el momento
-        no es posible generar el CEP. Operaci\xF3n no encontrada. El SPEI no ha recibido
-        una orden de pago que cumpla con el criterio de b\xFAsqueda especificado.
-        Se recomienda verificar la informaci\xF3n o consulte a su banco.</strong></center></div>\r\n
-        \                   \r\n        <br><br>\r\n        \r\n    </div>               \r\n
-        \          \r\n</div>\r\n\r\n<script>\r\n    $(function () {\r\n        $(\"#htmlCEP\").val($(\"#consultaMISPEI\").html());\r\n
-        \   });\r\n</script>"
+      string: ''
     headers:
-      Content-Language:
-      - es-MX
+      Connection:
+      - Keep-Alive
       Content-Length:
-      - '2573'
-      Content-Type:
-      - text/html; charset=UTF-8
-      Date:
-      - Wed, 31 Jul 2019 22:19:42 GMT
-      Set-Cookie:
-      - JSESSIONID=83VKHhmHhOhCaGk5yk5nzvCfnvQE63t9iro03PxjtKvH3te3AblR!-436816968;
-        path=/; HttpOnly
-      - ser29307111=709772970.50971.0000; path=/; Httponly
-      - TS014a759c=0189f484af94034651e412ada5540a7d6a8aeb988ef6a20b8b6d7cc6308e9f26cdfe4cec213451c440f3f58f598d41622ea859b099abe12ba4cb355c92fa26625cd3e33b347bef995315dc0964ffaaff7b38e2b816;
-        Path=/
+      - '0'
+      Location:
+      - https://www.banxico.org.mx/cep-beta/valida.do
+      Server:
+      - mxbanxico
     status:
-      code: 200
-      message: OK
+      code: 307
+      message: Temporary Redirect
 - request:
-    body: null
+    body: tipoCriterio=T&captcha=c&tipoConsulta=1&fecha=01-01-2019&criterio=invalid-clave&emisor=37166&receptor=90723&cuenta=012180004643051249&monto=1111111.0&receptorParticipante=0
     headers:
       Accept:
       - '*/*'
       Accept-Encoding:
       - gzip, deflate
       Connection:
       - keep-alive
-      Cookie:
-      - JSESSIONID=83VKHhmHhOhCaGk5yk5nzvCfnvQE63t9iro03PxjtKvH3te3AblR!-436816968;
-        TS014a759c=0189f484af94034651e412ada5540a7d6a8aeb988ef6a20b8b6d7cc6308e9f26cdfe4cec213451c440f3f58f598d41622ea859b099abe12ba4cb355c92fa26625cd3e33b347bef995315dc0964ffaaff7b38e2b816;
-        ser29307111=709772970.50971.0000
+      Content-Length:
+      - '172'
+      Content-Type:
+      - application/x-www-form-urlencoded
       User-Agent:
       - Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML,
         like Gecko) Chrome/75.0.3770.142 Safari/537.36
-    method: GET
-    uri: http://www.banxico.org.mx/cep/descarga.do?formato=XML
+    method: POST
+    uri: https://www.banxico.org.mx/cep-beta/valida.do
   response:
     body:
-      string: '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Draft//EN">
-
-        <HTML>
-
-        <HEAD>
-
-        <TITLE>Error 500--Internal Server Error</TITLE>
-
-        </HEAD>
-
-        <BODY bgcolor="white">
-
-        <FONT FACE=Helvetica><BR CLEAR=all>
-
-        <TABLE border=0 cellspacing=5><TR><TD><BR CLEAR=all>
-
-        <FONT FACE="Helvetica" COLOR="black" SIZE="3"><H2>Error 500--Internal Server
-        Error</H2>
-
-        </FONT></TD></TR>
-
-        </TABLE>
-
-        <TABLE border=0 width=100% cellpadding=10><TR><TD VALIGN=top WIDTH=100% BGCOLOR=white><FONT
-        FACE="Courier New"><FONT FACE="Helvetica" SIZE="3"><H3>From RFC 2068 <i>Hypertext
-        Transfer Protocol -- HTTP/1.1</i>:</H3>
-
-        </FONT><FONT FACE="Helvetica" SIZE="3"><H4>10.5.1 500 Internal Server Error</H4>
-
-        </FONT><P><FONT FACE="Courier New">The server encountered an unexpected condition
-        which prevented it from fulfilling the request.</FONT></P>
-
-        </FONT></TD></TR>
-
-        </TABLE>
-
-
-        </BODY>
-
-        </HTML>
-
-        '
+      string: "\r\n<div class=\"bg-banxico title-bar\">\r\n    <i class=\"icono-header
+        icon-warning3\"></i>\r\n    Error\r\n</div>\r\n<div id=\"#error_div\">\r\n
+        \   <div class=\"info\">\r\n        <p style=\"padding: 10px;max-width: 500px;
+        text-align: center;\">\r\n            [BE] No se encontr\xF3 ning\xFAn pago
+        con la informaci\xF3n proporcionada. Verifique e intente nuevamente.\r\n        </p>\r\n
+        \   </div>\r\n</div>\r\n<input type=\"hidden\" name=\"varHideCaptcha\" value=\"true\"/>\r\n"
     headers:
-      Connection:
-      - close
+      Content-Language:
+      - es-MX
       Content-Length:
-      - '833'
+      - '432'
       Content-Type:
       - text/html; charset=UTF-8
       Date:
-      - Wed, 31 Jul 2019 22:19:44 GMT
+      - Thu, 13 Feb 2025 16:25:34 GMT
+      Set-Cookie:
+      - JSESSIONID=L1QAIUBvfVoiIyEPtI_zYKtEVdTdxUKW6DURwUlxUrUf5j0buoTS!-2094109768;
+        path=/; secure; HttpOnly
+      - Hex39764011=!gAvSQWDwuCTFl1JFNVyFw/oTv40kxLg1HD4ls3vODi3yAy5Wm3BhzgxxulALXcz3KoRgQlInngLvSA==;
+        expires=Fri, 14-Feb-2025 00:25:34 GMT; path=/; Httponly
+      - 'TS012f422b=01ab44a5a81497a889d111c7c6b7a3089924f249dd3e785c8e18d629bf521efe70d62e81d052987707a4c517bd392afa6c339df4f68ee482fea560a8b88c923a2c40cad78199bbf43b8453c9e11dd62064f4a1e0dc;
+        Path=/; '
+      - TS604574e3027=083fd6a492ab2000610ffb96df3cc891ddf40e7adf2c7f4f53681407b649677c5f37ccd84082e3ea088ae78a5511300008172d082ec1c9a6ba5daced4ae245998f994aa81feace10acfa2583bbbccd3af9a668c3034f8883362e7467a2f0b9d7;
+        Path=/
     status:
-      code: 500
-      message: Internal Server Error
+      code: 200
+      message: OK
 version: 1

tests/CEP-20190412-CUENCA1555093850.pdf

@@ -12,7 +12,7 @@ interactions:
       - Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML,
         like Gecko) Chrome/75.0.3770.142 Safari/537.36
     method: GET
-    uri: http://www.banxico.org.mx/cep/no/existe
+    uri: http://www.banxico.org.mx/cep-beta/no/existe
   response:
     body:
       string: ''
@@ -22,12 +22,41 @@ interactions:
       Content-Length:
       - '0'
       Location:
-      - http://www.anterior.banxico.org.mx/cep/no/existe
+      - https://www.banxico.org.mx/cep-beta/no/existe
       Server:
-      - BigIP
+      - mxbanxico
+    status:
+      code: 307
+      message: Temporary Redirect
+- request:
+    body: null
+    headers:
+      Accept:
+      - '*/*'
+      Accept-Encoding:
+      - gzip, deflate
+      Connection:
+      - keep-alive
+      User-Agent:
+      - Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML,
+        like Gecko) Chrome/75.0.3770.142 Safari/537.36
+    method: GET
+    uri: https://www.banxico.org.mx/cep-beta/no/existe
+  response:
+    body:
+      string: ''
+    headers:
+      Connection:
+      - Keep-Alive
+      Content-Length:
+      - '0'
+      Location:
+      - https://anterior.banxico.org.mx/cep-beta/no/existe
+      Server:
+      - mxbanxico
     status:
       code: 302
-      message: Found
+      message: Moved Temporarily
 - request:
     body: null
     headers:
@@ -41,66 +70,25 @@ interactions:
       - Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML,
         like Gecko) Chrome/75.0.3770.142 Safari/537.36
     method: GET
-    uri: http://www.anterior.banxico.org.mx/cep/no/existe
+    uri: https://anterior.banxico.org.mx/cep-beta/no/existe
   response:
     body:
-      string: '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Draft//EN">
-
-        <HTML>
-
-        <HEAD>
-
-        <TITLE>Error 404--Not Found</TITLE>
-
-        </HEAD>
-
-        <BODY bgcolor="white">
-
-        <FONT FACE=Helvetica><BR CLEAR=all>
-
-        <TABLE border=0 cellspacing=5><TR><TD><BR CLEAR=all>
-
-        <FONT FACE="Helvetica" COLOR="black" SIZE="3"><H2>Error 404--Not Found</H2>
-
-        </FONT></TD></TR>
-
-        </TABLE>
-
-        <TABLE border=0 width=100% cellpadding=10><TR><TD VALIGN=top WIDTH=100% BGCOLOR=white><FONT
-        FACE="Courier New"><FONT FACE="Helvetica" SIZE="3"><H3>From RFC 2068 <i>Hypertext
-        Transfer Protocol -- HTTP/1.1</i>:</H3>
-
-        </FONT><FONT FACE="Helvetica" SIZE="3"><H4>10.4.5 404 Not Found</H4>
-
-        </FONT><P><FONT FACE="Courier New">The server has not found anything matching
-        the Request-URI. No indication is given of whether the condition is temporary
-        or permanent.</p><p>If the server does not wish to make this information available
-        to the client, the status code 403 (Forbidden) can be used instead. The 410
-        (Gone) status code SHOULD be used if the server knows, through some internally
-        configurable mechanism, that an old resource is permanently unavailable and
-        has no forwarding address.</FONT></P>
-
-        </FONT></TD></TR>
-
-        </TABLE>
-
-
-        </BODY>
-
-        </HTML>
-
-        '
+      string: The resource you are looking for has been removed, had its name changed,
+        or is temporarily unavailable.
     headers:
       Content-Length:
-      - '1164'
+      - '103'
       Content-Type:
-      - text/html; charset=UTF-8
+      - text/html
       Date:
-      - Wed, 31 Jul 2019 22:10:25 GMT
+      - Thu, 13 Feb 2025 16:29:05 GMT
       Set-Cookie:
-      - ser29307111=709772970.50971.0000; path=/; Httponly
-      - TS014a759c=0189f484af0dfe57a482b0397c7dfa4de3ec8dccb82bf88c7c60badfd116214ac8e976e9160aa3f01c58847e5567305109721675e798547f39f5e434af9c6fddd649ea7867;
+      - TS27080ada027=083fd6a492ab2000b680ccb1da004b5b4fdaa8484afdb7be4f778f6c1b99695c85df7ec0db406647089836ce1e1130000f24c8692fcbf30a82791dd1a64a58930c0ee5d9bd2646eb613c5a9e383a5019333abdba92c2cf7c77f10a2b5a0f0e8a;
         Path=/
+      Strict-Transport-Security:
+      - max-age=480; preload
+      X-Robots-Tag:
+      - noindex, nofollow
     status:
       code: 404
       message: Not Found