display search context consistently regardless of whether there is a single result (DLC-1161)

Author: barmintor

app/components/dcv/search_context/pagination_component.html.erb

@@ -1,9 +1,5 @@
 <div class="input-group-append p-0">
-  <% if @search_context[:prev] || @search_context[:next] %>
-      <%= helpers.link_back_to_catalog(label: "<span class=\"d-none d-md-inline\">#{item_page_entry_info} </span><i class=\"fa fa-reply-all\"></i>".html_safe, class: 'btn bg-body btn-outline-info rounded-md-left-0 rounded-right-0 align-content-center w-100 h-100', :"data-toggle" => 'tooltip', "aria-label": t('views.pagination.return_to_search'), title: t('views.pagination.return_to_search') ) %>
-      <%= link_to_previous_document @search_context[:prev], "btn bg-body btn-outline-info rounded-0 align-content-center flex-shrink-1" %>
-      <%= link_to_next_document @search_context[:next], "btn bg-body btn-outline-info rounded-right align-content-center flex-shrink-1" %>
-  <% else %>
-      <%= helpers.link_back_to_catalog(label: '<i class="fa fa-reply-all"></i> '.html_safe, class: 'btn bg-body btn-outline-info rounded-md-left-0 align-content-center flex-fill', :"data-toggle" => 'tooltip', "aria-label": t('views.pagination.return_to_search'), title: t('views.pagination.return_to_search') ) %>
-  <% end %>
+  <%= helpers.link_back_to_catalog(label: "<span class=\"d-none d-md-inline\">#{item_page_entry_info} </span><i class=\"fa fa-reply-all\"></i>".html_safe, class: 'btn bg-body btn-outline-info rounded-md-left-0 rounded-right-0 align-content-center w-100 h-100', :"data-toggle" => 'tooltip', "aria-label": t('views.pagination.return_to_search'), title: t('views.pagination.return_to_search') ) %>
+  <%= link_to_previous_document @search_context[:prev], "btn bg-body btn-outline-info rounded-0 align-content-center flex-shrink-1" %>
+  <%= link_to_next_document @search_context[:next], "btn bg-body btn-outline-info rounded-right align-content-center flex-shrink-1" %>
 </div>

app/components/dcv/search_context/pagination_component.rb

@@ -5,5 +5,9 @@ class PaginationComponent < Blacklight::SearchContextComponent
     def will_render?(**_args)
       render?
     end
+
+    def render?
+      ([:prev, :next] & @search_context.keys).present? if @search_context
+    end
   end
 end

app/views/kaminari/dcv_collapsible/_prev_page.html.erb

@@ -7,4 +7,4 @@
     remote:        data-remote
 -%>
 <% tag_class="btn bg-body btn-outline-info rounded-0 #{'disabled' if current_page.first?}" -%>
-<%= link_to '<i class="fa fa-arrow-left"></i>'.html_safe, url, :rel => 'next', :remote => remote, :"data-toggle" => 'tooltip', "aria-label": raw(t 'views.pagination.previous'), title: raw(t 'views.pagination.previous'), class: tag_class %>
+<%= link_to '<i class="fa fa-arrow-left"></i>'.html_safe, url, :rel => 'prev', :remote => remote, :"data-toggle" => 'tooltip', "aria-label": raw(t 'views.pagination.previous'), title: raw(t 'views.pagination.previous'), class: tag_class %>

app/views/kaminari/dcv_compact/_prev_page.html.erb

@@ -7,4 +7,4 @@
     remote:        data-remote
 -%>
 <% tag_class="btn bg-body btn-outline-info rounded-0 align-content-center #{'disabled' if current_page.first?}" -%>
-<%= link_to '<i class="fa fa-arrow-left"></i>'.html_safe, url, :rel => 'next', :remote => remote, :"data-toggle" => 'tooltip', "aria-label": raw(t 'views.pagination.previous'), title: raw(t 'views.pagination.previous'), class: tag_class %>
+<%= link_to '<i class="fa fa-arrow-left"></i>'.html_safe, url, :rel => 'prev', :remote => remote, :"data-toggle" => 'tooltip', "aria-label": raw(t 'views.pagination.previous'), title: raw(t 'views.pagination.previous'), class: tag_class %>

spec/components/dcv/search_context/pagination_component_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe Dcv::SearchContext::PaginationComponent, type: :component do
+  subject(:component) { described_class.new(search_context: search_context, search_session: search_session) }
+
+  # search_context may be nil or a hash of :prev and :next
+  let(:search_context) { nil }
+
+  # search_session may be nil or a hash of %w(id counter total)
+  let(:search_session) { nil }
+
+
+  let(:item_page_entry_info) { nil }
+
+  before do
+    allow(view_context).to receive(:item_page_entry_info).and_return(item_page_entry_info)
+    allow(view_context).to receive(:current_search_session).and_return({ query_params: {}})
+    allow(view_context).to receive(:link_back_to_catalog) { |arg| arg[:label] }
+  end
+
+  include_context "renderable view components"
+
+  context "with a single document in search" do
+    let(:item_page_entry_info) { "item_page_entry_info" }
+    let(:search_context) { { prev: nil, next: nil } }
+    let(:search_session) { { 'counter' => 1, 'id' => 'id', 'total' => 1 } }
+    it 'links to the facet and shows the number of hits' do
+      expect(rendered).to have_selector 'span.d-md-inline', text: item_page_entry_info
+    end
+  end
+
+  context "with a transformed value" do
+  end
+end