robots and noindex nofollow META tags on search actions (DLC-1164)

Author: barmintor

app/controllers/application_controller.rb

@@ -103,4 +103,20 @@ def on_page_not_found
   def has_search_parameters?
     false
   end
+
+  def meta_nofollow
+    @meta_nofollow
+  end
+
+  def meta_nofollow!
+    @meta_nofollow = true
+  end
+
+  def meta_noindex
+    @meta_noindex
+  end
+
+  def meta_noindex!
+    @meta_noindex = true
+  end
 end

app/controllers/browse_controller.rb

@@ -7,6 +7,9 @@ class BrowseController < ApplicationController
     controller.subsite_layout
   }
 
+  before_action :meta_nofollow!, only: [:list]
+  before_action :meta_noindex!, only: [:list]
+
   def initialize(*args)
     super(*args)
     # _prefixes are where view path lookups are attempted; probably unnecessary

app/controllers/repositories/catalog_controller.rb

@@ -5,6 +5,9 @@ class CatalogController < Sites::SearchController
 
     before_action :set_map_data_json, only: [:map_search]
 
+    before_action :meta_nofollow!, only: [:index, :map_search]
+    before_action :meta_noindex!, only: [:index, :map_search]
+
     delegate :blacklight_config, to: :@subsite
 
     def initialize(*args)

app/controllers/sites/search_controller.rb

@@ -17,6 +17,8 @@ class SearchController < ApplicationController
 		before_action :store_unless_user, except: [:update, :destroy, :api_info]
 		before_action :redirect_unless_local, only: :index
 		before_action :authorize_document, only: :show
+		before_action :meta_nofollow!, only: [:index, :map_search]
+		before_action :meta_noindex!, only: [:index, :map_search]
 
 		delegate :blacklight_config, to: :@subsite
 

app/controllers/subsites_controller.rb

@@ -16,6 +16,8 @@ class SubsitesController < ApplicationController
   before_action :default_search_mode_cookie, only: :index
   before_action :load_subsite, except: [:home, :page]
   before_action :load_page, only: [:home, :index, :page]
+  before_action :meta_nofollow!, only: [:index, :map_search]
+  before_action :meta_noindex!, only: [:index, :map_search]
   protect_from_forgery :except => [:update, :destroy, :api_info] # No CSRF token required for publishing actions
 
   helper_method :extract_map_data_from_document_list

app/views/shared/_head_includes.html.erb

@@ -5,9 +5,12 @@
 <meta name="viewport" content="width=device-width,initial-scale=1.0">
 
 <% # Do not index search result pages %>
-<% if query_has_constraints? || (params[:q] && params[:search_field]) %>
+<% if controller.meta_noindex %>
 <meta name="robots" content="noindex" />
 <% end %>
+<% if controller.meta_nofollow %>
+<meta name="robots" content="nofollow" />
+<% end %>
 
 <!--
 DLC VERSION: <%= IO.read(Rails.root.to_s+'/VERSION') %> -->

spec/controllers/browse_controller_spec.rb

@@ -52,6 +52,11 @@
         expect(response.status).to eq(200)
         expect(response.body).to include("#{format_link} (#{test_format_count})")
       end
+      it "has robots meta flag attributes" do
+        get :list, params: { list_id: 'formats' }
+        expect(controller.instance_variable_get(:@meta_noindex)).to be true
+        expect(controller.instance_variable_get(:@meta_nofollow)).to be true
+      end
     end
   end
 

spec/controllers/repositories/catalog_controller_spec.rb

@@ -28,5 +28,10 @@
       expect(response.status).to eq(200)
       expect(controller.load_subsite.palette).to eql 'monochrome'
     end
+    it "has robots meta flag attributes" do
+      get :index, params: { repository_id: 'NNC-RB' }
+      expect(controller.instance_variable_get(:@meta_nofollow)).to be true
+      expect(controller.instance_variable_get(:@meta_noindex)).to be true
+    end
   end
 end

spec/features/catalog_controller_spec.rb

@@ -10,6 +10,13 @@
       expect(page).to have_text('Perform a search')
     end
 
+    it "has robots meta tags" do
+      # <meta name="robots" content="nofollow">
+      # <meta name="robots" content="noindex">
+      expect(page).to have_xpath("/descendant::meta[@name='robots' and @content='nofollow']")
+      expect(page).to have_xpath("/descendant::meta[@name='robots' and @content='noindex']")
+    end
+
     it "shows concepts when performing a search with a relevant query" do
       find(:xpath, '//nav[@id="site-banner"]//input[@id="q"]').set('Internal')
       find(:xpath, '//nav[@id="site-banner"]//button[@type="submit"]').click