From 8c5f89d2a6b424332c81a8c15cdb92362d71f38b Mon Sep 17 00:00:00 2001 From: Benjamin Armintor Date: Fri, 26 Jul 2024 12:48:28 -0400 Subject: [PATCH] DLC-1143 WIP --- app/models/site/display_options.rb | 10 ++++++++-- .../sites/search_configuration_controller_spec.rb | 9 +++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/app/models/site/display_options.rb b/app/models/site/display_options.rb index 508abcf25..d73564667 100644 --- a/app/models/site/display_options.rb +++ b/app/models/site/display_options.rb @@ -18,12 +18,18 @@ def default_configuration def initialize(atts = {}) atts = default_configuration.merge(atts.symbolize_keys).with_indifferent_access - renamed_tombstone_fields = atts.delete(:tombstone_fields) - atts[:grid_field_types] = renamed_tombstone_fields if renamed_tombstone_fields.present? + correct_deprecated_att_names(atts) assign_attributes(atts) clear_changes_information end + # deletable after staging data is corrected for DLC-1143 + def correct_deprecated_att_names(atts) + # deletable after staging data is corrected + renamed_tombstone_fields = atts.delete(:tombstone_fields) + atts[:grid_field_types] = renamed_tombstone_fields if renamed_tombstone_fields.present? + end + def default_search_mode=(val) @default_search_mode = VALID_SEARCH_MODES.include?(val) ? val : 'grid' end diff --git a/spec/features/sites/search_configuration_controller_spec.rb b/spec/features/sites/search_configuration_controller_spec.rb index b2a2c463c..c45139af5 100644 --- a/spec/features/sites/search_configuration_controller_spec.rb +++ b/spec/features/sites/search_configuration_controller_spec.rb @@ -39,6 +39,15 @@ expect(find_field('site[search_configuration][facets][1][facet_fields_form_value]').value).to eq("level_one_field_sim,level_2_field_sim") expect(find_field('site[search_configuration][facets][1][label]').value).to eq("Levels") end + it 'updates grid display field configuration' do + expect(find_field('site[search_configuration][display_options][grid_field_types]').value).to eq("name") + page.fill_in('site[search_configuration][display_options][grid_field_types]', with: 'format, name') + click_button "Update Search Configuration" + # do a find to make sure page loaded + find('#site_search_configuration_display_options_grid_field_types') + visit(edit_link_href) + expect(find_field('site[search_configuration][display_options][grid_field_types]').value).to eq("format, name") + end end describe '#edit' do before do