Refactor logging

Author: fcd1

app/controllers/sword_controller.rb

@@ -22,20 +22,18 @@ def deposit
     @path_to_deposit_contents = Sword::Util::unzip_deposit_file request_body
 
     # log basic essential info. Keep it terse! Gonna use :warn level, though not a warning.
-    Rails.logger.warn("Received deposit POST. Collection slug: #{@collection_slug}, " \
-                      "Username: #{@depositor_user_id}, " \
-                      "Path to contents: #{@path_to_deposit_contents}"
-                     )
+    helpers.log_received_deposit_post(@collection_slug,
+                                      @depositor_user_id,
+                                      @path_to_deposit_contents)
 
     @endpoint.handle_deposit(@path_to_deposit_contents)
 
     # log basic essential info. Keep it terse! Gonna use :warn level, though not a warning.
-    Rails.logger.warn("Title: #{@endpoint.deposit_title.truncate_words(10)}, " \
-                      "Files: #{@endpoint.documents_to_deposit}, " \
-                      "Hyacinth item pid: #{@endpoint.adapter_item_identifier}, " \
-                      "Hyacinth asset pids: #{@endpoint.asset_pids}, " \
-                      "Path to SWORD contents: #{@path_to_deposit_contents}"
-                     )
+    helpers.log_deposit_result_info(@endpoint.deposit_title.truncate_words(10),
+                                    @endpoint.documents_to_deposit,
+                                    @endpoint.adapter_item_identifier,
+                                    @endpoint.asset_pids,
+                                    @path_to_deposit_contents)
 
     # create Deposit instance and store deposit info in database
     @deposit = helpers.create_deposit(@depositor_user_id,

app/helpers/logging_helper.rb

@@ -0,0 +1,21 @@
+module LoggingHelper
+  def log_received_deposit_post(collection_slug,
+                                depositor_user_id,
+                                path_to_deposit_contents)
+    Rails.logger.warn("Received deposit POST. Collection slug: #{collection_slug}, " \
+                      "Username: #{depositor_user_id}, " \
+                      "Path to contents: #{path_to_deposit_contents}")
+  end
+  def log_deposit_result_info(title,
+                              files,
+                              item_pid,
+                              asset_pids,
+                              path_content)
+    Rails.logger.warn("Title: #{title}, " \
+                      "Files: #{files}, " \
+                      "Hyacinth item pid: #{item_pid}, " \
+                      "Hyacinth asset pids: #{asset_pids}, " \
+                      "Path to SWORD contents: #{path_content}"
+                     )    
+  end
+end