Skip to content

Commit 63af135

Browse files
marlo-longleyelohanlon
authored andcommitted
Replace Harvard Van Gogh manifest due to failing tests
1 parent f6eace2 commit 63af135

File tree

14 files changed

+35
-23
lines changed

14 files changed

+35
-23
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export const PRIMARY_MANIFEST_FIXTURE_URL = 'https://dms-data.stanford.edu/data/manifests/Parker/nb647fd0133/manifest.json';
2+
export const PRIMARY_CANVAS_FIXTURE_URL = 'https://dms-data.stanford.edu/data/manifests/Parker/nb647fd0133/canvas/canvas-1';

__tests__/integration/mirador/mirador-configs/double-van-gogh.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
2+
13
/**
24
* Creates a Mirador config object with two windows:
35
* - One with a specific canvas index
@@ -14,7 +16,7 @@ export default function createConfig(id) {
1416
windows: [
1517
{
1618
canvasIndex: 2,
17-
loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
19+
loadedManifest: PRIMARY_MANIFEST_FIXTURE_URL,
1820
},
1921
{
2022
loadedManifest: 'https://media.nga.gov/public/manifests/nga_highlights.json',

__tests__/integration/mirador/mirador-configs/i18n.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
import { PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
2+
13
export default {
24
catalog: [
5+
{ manifestId: PRIMARY_MANIFEST_FIXTURE_URL },
36
{ manifestId: 'https://iiif.bodleian.ox.ac.uk/iiif/manifest/e32a277e-91e2-4a6d-8ba6-cc4bad230410.json' },
4-
{ manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843' },
57
{ manifestId: 'https://media.nga.gov/public/manifests/nga_highlights.json', provider: 'National Gallery of Art' },
68
{ manifestId: 'https://wellcomelibrary.org/iiif/b18035723/manifest', provider: 'Wellcome Library' },
79
{ manifestId: 'https://demos.biblissima.fr/iiif/metadata/florus-dispersus/manifest.json', provider: 'Biblissima' },

__tests__/integration/mirador/mirador-configs/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
import { PRIMARY_CANVAS_FIXTURE_URL, PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
2+
13
// has 2 windows, one gaugin and one bodleian
24
export default {
35
catalog: [
6+
{ manifestId: PRIMARY_MANIFEST_FIXTURE_URL },
47
{ manifestId: 'https://iiif.bodleian.ox.ac.uk/iiif/manifest/e32a277e-91e2-4a6d-8ba6-cc4bad230410.json' },
5-
{ manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843' },
68
{ manifestId: 'https://media.nga.gov/public/manifests/nga_highlights.json', provider: 'National Gallery of Art' },
79
{ manifestId: 'https://wellcomelibrary.org/iiif/b18035723/manifest', provider: 'Wellcome Library' },
810
{ manifestId: 'https://demos.biblissima.fr/iiif/metadata/florus-dispersus/manifest.json', provider: 'Biblissima' },
@@ -19,8 +21,8 @@ export default {
1921
transitions: {},
2022
},
2123
windows: [{
22-
canvasId: 'https://iiif.harvardartmuseums.org/manifests/object/299843/canvas/canvas-47174892',
23-
manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
24+
canvasId: PRIMARY_CANVAS_FIXTURE_URL,
25+
manifestId: PRIMARY_MANIFEST_FIXTURE_URL,
2426
},
2527
{
2628
canvasId: 'https://iiif.bodleian.ox.ac.uk/iiif/canvas/e58b8c60-005c-4c41-a22f-07d49cb25ede.json',
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
1+
import { PRIMARY_MANIFEST_FIXTURE_URL, PRIMARY_CANVAS_FIXTURE_URL } from '../constants';
2+
13
export default {
24
id: 'mirador',
35
windows: [{
4-
canvasId: 'https://iiif.harvardartmuseums.org/manifests/object/299843/canvas/canvas-47174892',
6+
canvasId: PRIMARY_CANVAS_FIXTURE_URL,
57
initialViewerConfig: {
68
thumbnailNavigationPosition: 'far-bottom',
79
x: 934,
810
y: 782,
911
// you need to specify zoom for this to look good
1012
zoom: 0.0007,
1113
},
12-
manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
14+
manifestId: PRIMARY_MANIFEST_FIXTURE_URL,
1315
}],
1416
};

__tests__/integration/mirador/mirador-configs/minimalist.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { PRIMARY_MANIFEST_FIXTURE_URL, PRIMARY_CANVAS_FIXTURE_URL } from '../constants';
2+
13
export default {
24
id: 'mirador',
35
theme: {
@@ -10,8 +12,8 @@ export default {
1012
},
1113
windows: [{
1214
allowClose: false,
13-
canvasId: 'https://iiif.harvardartmuseums.org/manifests/object/299843/canvas/canvas-47174892',
14-
manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
15+
canvasId: PRIMARY_CANVAS_FIXTURE_URL,
16+
manifestId: PRIMARY_MANIFEST_FIXTURE_URL,
1517
thumbnailNavigationPosition: 'far-bottom',
1618
}],
1719
workspace: {

__tests__/integration/mirador/mirador-configs/plugin-state.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import { stateDependentPlugin } from '../plugins/index';
2+
import { PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
23

34
export default {
45
config: {
56
id: 'mirador',
67
windows: [{
78
canvasIndex: 2,
8-
loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
9+
loadedManifest: PRIMARY_MANIFEST_FIXTURE_URL,
910
thumbnailNavigationPosition: 'far-bottom',
1011
}],
1112
},

__tests__/integration/mirador/mirador-configs/rtl.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
2+
13
export const rtl1 = {
24
createGenerateClassNameOptions: {
35
seed: 'one',
@@ -32,7 +34,7 @@ export const rtl3 = {
3234
id: 'instanceThree',
3335
windows: [
3436
{
35-
manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
37+
manifestId: PRIMARY_MANIFEST_FIXTURE_URL,
3638
},
3739
],
3840
};
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { PRIMARY_CANVAS_FIXTURE_URL, PRIMARY_MANIFEST_FIXTURE_URL } from '../constants';
2+
13
export default {
24
id: 'mirador',
35
theme: {
@@ -7,7 +9,7 @@ export default {
79
defaultPosition: 'far-bottom',
810
},
911
windows: [{
10-
canvasId: 'https://iiif.harvardartmuseums.org/manifests/object/299843/canvas/canvas-47174892',
11-
manifestId: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
12+
canvasId: PRIMARY_CANVAS_FIXTURE_URL,
13+
manifestId: PRIMARY_MANIFEST_FIXTURE_URL,
1214
}],
1315
};

__tests__/integration/mirador/tests/annotations.test.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ import config from '../mirador-configs/single-van-gogh';
1212
describe('Annotations in Mirador', () => {
1313
setupIntegrationTestViewer(config);
1414

15-
it('Loads the manifest', async () => {
16-
const element = await screen.findByRole('region', { name: /Window: Self-Portrait Dedicated to Paul Gauguin/i });
17-
expect(element).toBeInTheDocument();
18-
});
19-
2015
it('stores annotations in state by canvasId', async (context) => {
2116
// Open the sidebar
2217
const toggleButtons = await screen.findAllByLabelText(/toggle sidebar/i);

0 commit comments

Comments
 (0)