Skip to content

Commit f2d602b

Browse files
committed
Merge pull request rails#17798 from kamipo/refactor_visit_add_column
Refactor `SchemaCreation#visit_AddColumn`
2 parents 6c83d4b + 9e6733d commit f2d602b

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ def accept(o)
1515
end
1616

1717
def visit_AddColumn(o)
18-
sql_type = type_to_sql(o.type, o.limit, o.precision, o.scale)
19-
sql = "ADD #{quote_column_name(o.name)} #{sql_type}"
20-
add_column_options!(sql, column_options(o))
18+
"ADD #{accept(o)}"
2119
end
2220

2321
private

activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ module PostgreSQL
44
class SchemaCreation < AbstractAdapter::SchemaCreation
55
private
66

7-
def visit_AddColumn(o)
8-
sql_type = type_to_sql(o.type, o.limit, o.precision, o.scale)
9-
sql = "ADD COLUMN #{quote_column_name(o.name)} #{sql_type}"
10-
add_column_options!(sql, column_options(o))
11-
end
12-
137
def visit_ColumnDefinition(o)
148
sql = super
159
if o.primary_key? && o.type != :primary_key

0 commit comments

Comments
 (0)