Skip to content

Commit 4729ed6

Browse files
committed
use the term 'gnumake' instead of m32/Makefile.m32 [ci skip]
Of course both autotools and cmake uses (or can use) GNU Make. Within curl-for-win it means using raw/pure GNU Make without an extra generator layer like cmake/autotools (or something proprietary). This makes the term project agnostic. (E.g. curl uses `Makefile.m32`, awaiting [1] a rename to `Makefile.mk`, libssh2 uses `GNUMakefile`, etc.) It's also more greppable and less ambiguous than some alternatives ('make', 'gmake', 'mk'). [1] curl/curl#9764
1 parent ef8e8d0 commit 4729ed6

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

_build.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
8383
# - https://github.com/netwide-assembler/nasm
8484

8585
# Build times (2022-09-26):
86-
# - m32: 38 min 13 sec 2293s 100%
86+
# - gnumake: 38 min 13 sec 2293s 100%
8787
# - cmake: 45 min 48 sec 2748s 120% 100%
8888
# - autotools: 49 min 32 sec 2972s 130% 108%
8989
# - autotools w/o recv patch: 54 min 8 sec 3248s 142% 118%
@@ -111,7 +111,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
111111
# wolfssh autotools
112112
# libssh cmake
113113
# libssh2 autotools, cmake
114-
# curl cmake, autotools, Makefile.m32
114+
# curl cmake, autotools, gnumake
115115

116116
cd "$(dirname "$0")"
117117

@@ -285,14 +285,14 @@ _ori_path="${PATH}"
285285

286286
bld() {
287287
pkg="$1"
288-
if [ -z "${CW_BLD:-}" ] || echo " ${CW_BLD} " | grep -q -E " ${pkg}(-(cmake|autotools|make|m32))? "; then
288+
if [ -z "${CW_BLD:-}" ] || echo " ${CW_BLD} " | grep -q -E " ${pkg}(-(cmake|autotools|gnumake))? "; then
289289
shift
290290

291291
pkgori="${pkg}"
292292
[ -n "${2:-}" ] && pkg="$2"
293293
# allow selecting an alternate build tool
294294
withbuildtool="$(echo "${CW_BLD:-}" | \
295-
grep -a -o -E "${pkg}-(cmake|autotools|make|m32)" || true)"
295+
grep -a -o -E "${pkg}-(cmake|autotools|gnumake)" || true)"
296296
if [ -n "${withbuildtool}" ] && [ -f "${withbuildtool}.sh" ]; then
297297
pkg="${withbuildtool}"
298298
fi

curl-cmake.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,14 @@ _VER="$1"
190190
LIBS="${LIBS} -lbcrypt" # for auto-detection
191191

192192
if [ "${CW_DEV_CROSSMAKE_REPRO:-}" = '1' ]; then
193-
# By passing -lssh2 _before_ -lcrypto (of openssl/libressl) to the linker,
194-
# DLL size becomes closer/identical to autotools/m32-built DLLs. Otherwise
195-
# this is not necessary, and there should not be any functional difference.
196-
# Could not find the reason for it. File-offset-stripped-then-sorted .map
197-
# files are identical either way. It would be useful to have a linker
198-
# option to sort object/lib inputs to make output deterministic (these
199-
# builds do not rely on ordering side-effects.)
193+
# By passing -lssh2 _before_ -lcrypto (of openssl/libressl) to the
194+
# linker, DLL size becomes closer/identical to autotools/gnumake-built
195+
# DLLs. Otherwise this is not necessary, and there should not be any
196+
# functional difference. Could not find the reason for it.
197+
# File-offset-stripped-then-sorted .map files are identical either way.
198+
# It would be useful to have a linker option to sort object/lib inputs
199+
# to make output deterministic (these builds do not rely on ordering
200+
# side-effects.)
200201
LDFLAGS="${LDFLAGS} -L${_TOP}/libssh2/${_PP}/lib"
201202
LIBS="${LIBS} -lssh2"
202203
fi

curl-m32.sh renamed to curl-gnumake.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
88

99
export _NAM _VER _OUT _BAS _DST
1010

11-
_NAM="$(basename "$0" | cut -f 1 -d '.' | sed 's/-m32//')"
11+
_NAM="$(basename "$0" | cut -f 1 -d '.' | sed 's/-gnumake//')"
1212
_VER="$1"
1313

1414
(

curl.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
curl-m32.sh
1+
curl-gnumake.sh

0 commit comments

Comments
 (0)