log warning if user calls time.sleep(); replace with asyncio.sleep()

Author: craigbarratt

custom_components/pyscript/eval.py

@@ -11,6 +11,7 @@
 import keyword
 import logging
 import sys
+import time
 import weakref
 
 import yaml
@@ -1930,6 +1931,13 @@ async def call_func(self, func, func_name, *args, **kwargs):
         if asyncio.iscoroutinefunction(func):
             return await func(*args, **kwargs)
         if callable(func):
+            if func == time.sleep:  # pylint: disable=comparison-with-callable
+                _LOGGER.warning(
+                    "%s line %s calls blocking time.sleep(); replaced with asyncio.sleep()",
+                    self.filename,
+                    self.lineno,
+                )
+                return await asyncio.sleep(*args, **kwargs)
             return func(*args, **kwargs)
         raise TypeError(f"'{func_name}' is not callable (got {func})")
 

tests/test_function.py

@@ -1267,6 +1267,8 @@ async def test_service_call_blocking(hass, caplog):
         None,
         [dt(2020, 7, 1, 12, 0, 0, 0)],
         """
+import time
+
 seq_num = 0
 
 @time_trigger("startup")
@@ -1298,7 +1300,7 @@ def short_sleep():
     global long_sleep_id
 
     long_sleep_id = task.current_task()
-    task.sleep(0.0001)
+    time.sleep(0.0001)
     pyscript.var1 = int(pyscript.var1) + 1
 
 @service(supports_response = "optional")