Prevent double initialization of glog for <=0.5 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlinpe
added a commit
to colmap/colmap
that referenced
this pull request
Nov 26, 2024
Fixes #2895. We run a similar check in pyceres: cvg/pyceres#59
B1ueber2y
approved these changes
Nov 26, 2024
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
Fixes colmap#2895. We run a similar check in pyceres: cvg/pyceres#59
|
FYI, it seems that if I build both PyCeres and PyColmap from source (in this order), the double initialization of glog is still a problem on Ubuntu 20 which comes with glog 0.4, so the build of PyColmap fails at the last stage. This workaround helped me: google/glog#125 My setup: I know I should have built a newer glog from source but another project on my machine uses the installed one and they seem to clash at runtime :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.