Fix for Path Too Long Exception

* Fix for the issue
#1
* Renamed the SourceCodeReader.Web directory to Web
* Zipballs are extracted to the top level directory

Author: cvrajeesh

SourceCodeReader.sln

@@ -1,8 +1,6 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 2012
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SourceCodeReader.Web", "SourceCodeReader.Web\SourceCodeReader.Web.csproj", "{B80F76F9-73B8-472A-8592-3DCC46CBC29D}"
-EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{2F59898C-53FE-4396-878A-A949E0B59A97}"
 	ProjectSection(SolutionItems) = preProject
 		.nuget\NuGet.Config = .nuget\NuGet.Config
@@ -14,6 +12,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{07EA8E8F
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SourceCodeReader.Web.Tests", "Tests\SourceCodeReader.Web.Tests\SourceCodeReader.Web.Tests.csproj", "{23867FD0-DA89-44A7-ABF9-FADF4A2DF541}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SourceCodeReader.Web", "Web\SourceCodeReader.Web.csproj", "{B80F76F9-73B8-472A-8592-3DCC46CBC29D}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU

Tests/SourceCodeReader.Web.Tests/SourceCodeReader.Web.Tests.csproj

@@ -52,8 +52,8 @@
     <None Include="packages.config" />
   </ItemGroup>
   <ItemGroup>
-    <ProjectReference Include="..\..\SourceCodeReader.Web\SourceCodeReader.Web.csproj">
-      <Project>{B80F76F9-73B8-472A-8592-3DCC46CBC29D}</Project>
+    <ProjectReference Include="..\..\Web\SourceCodeReader.Web.csproj">
+      <Project>{b80f76f9-73b8-472a-8592-3dcc46cbc29d}</Project>
       <Name>SourceCodeReader.Web</Name>
     </ProjectReference>
   </ItemGroup>

SourceCodeReader.Web/App_Start/BootStrapper.cs renamed to Web/App_Start/BootStrapper.cs

@@ -31,7 +31,7 @@ public DotNetCodeEditorService(
 
         public string BuildNavigatableSourceCodeFromFile(string username, string project, string path)
         {
-            var projectCodeDirectory = this.GetProjectCodeDirectory(username, project);
+            var projectCodeDirectory = new DirectoryInfo(this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project));
             string fullPath = Path.Combine(projectCodeDirectory.FullName, path.Replace(@"/", @"\"));
             string fileExtension = Path.GetExtension(fullPath);
             string sourceCode = File.ReadAllText(fullPath);
@@ -124,7 +124,7 @@ private void TraverseThroughAllTheProjectFiles(TokenParameter parameter, IFindRe
         {
             findReferenceProgressListener.OnFindReferenceStarted();
 
-            var projectCodeDirectory = this.GetProjectCodeDirectory(parameter.Username, parameter.Project);
+            var projectCodeDirectory = new DirectoryInfo(this.applicationConfigurationProvider.GetProjectSourceCodePath(parameter.Username, parameter.Project));
 
             var solutionPath = FindSolutionPath(parameter.Username, parameter.Project);
             if (solutionPath == null)
@@ -182,7 +182,7 @@ private void TraverseThroughAllTheProjectFiles(TokenParameter parameter, IFindRe
 
         private string FindSolutionPath(string username, string project)
         {
-            var projectCodeDirectory = this.GetProjectCodeDirectory(username, project);
+            var projectCodeDirectory = new DirectoryInfo(this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project));
             var solutions = projectCodeDirectory.GetFiles("*.sln", SearchOption.AllDirectories);
 
             if (solutions.Length > 0)
@@ -200,16 +200,10 @@ private string FindSolutionPath(string username, string project)
             return null;
         }
 
-        private DirectoryInfo GetProjectCodeDirectory(string username, string project)
-        {
-            var projectSourceCodeDirectory = this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project);
-            return new DirectoryInfo(projectSourceCodeDirectory).GetDirectories()[0];
-        }
-
 
         public void RewriteExternalDependencies(string username, string project)
         {
-            var projectDirectory = this.GetProjectCodeDirectory(username, project);
+            var projectDirectory = new DirectoryInfo(this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project));
             var projectFiles = projectDirectory.GetFiles("*.csproj", SearchOption.AllDirectories);
             var msBuildExteionpath32 = Path.Combine(this.applicationConfigurationProvider.ApplicationRoot, "TargetFiles", "MSBuild-MS-VS");
             foreach (var projectFile in projectFiles)

SourceCodeReader.Web/App_Start/BundleConfig.cs renamed to Web/App_Start/BundleConfig.cs

@@ -87,7 +87,7 @@ private IndexSearcher Searcher
 
         public void IndexProject(string username, string projectName, string projectDirectory)
         {
-            var projectRoot = new DirectoryInfo(projectDirectory).GetDirectories()[0];
+            var projectRoot = new DirectoryInfo(projectDirectory);
             string projectIdentifier = string.Format("{0}_{1}", username, projectName).ToLower();
             string indexCreatedStatusCheckFilePath = Path.Combine(this.applicationConfigurationProvider.ApplicationDataRoot, string.Format("{0}.status", projectIdentifier));
 
@@ -216,7 +216,7 @@ public TokenResult FindExact(TokenParameter parameter)
                 string filePath = document.Get(ItemPath);
                 int location = Int32.Parse(document.Get(ItemLocation));
 
-                var projectCodeDirectory = this.GetProjectCodeDirectory(parameter.Username, parameter.Project);
+                var projectCodeDirectory = this.applicationConfigurationProvider.GetProjectSourceCodePath(parameter.Username, parameter.Project);
                 //string relativePath = filePath //projectCodeDirectory.MakeRelativePath(filePath);
                 return new Models.TokenResult
                 {
@@ -229,12 +229,6 @@ public TokenResult FindExact(TokenParameter parameter)
             return null;
         }
 
-        private DirectoryInfo GetProjectCodeDirectory(string username, string project)
-        {
-            var projectSourceCodeDirectory = this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project);
-            return new DirectoryInfo(projectSourceCodeDirectory).GetDirectories()[0];
-        }
-
         public Models.DocumentInfo GetFileDetails(string filePath)
         {
             var query = new TermQuery(new Term(ItemPath, filePath));

SourceCodeReader.Web/App_Start/FilterConfig.cs renamed to Web/App_Start/FilterConfig.cs

@@ -37,13 +37,13 @@ public GitHubSourceCodeProviderService(
         public ProjectItem GetContent(string username, string project, string path, ISourceCodeOpeningProgress openingProgressListener)
         {
             var projectSourceCodePath = this.applicationConfigurationProvider.GetProjectSourceCodePath(username, project);
+            string projectIdentifier = string.Format("{0}_{1}", username, project);
             try
             {
                 if (!Directory.Exists(projectSourceCodePath))
                 {
-                    string projectIdentifier = string.Format("{0}_{1}", username, project);
-                    object __projectSpecificLock = ProjectDownloadLock.GetOrAdd(projectIdentifier, new object());
-                    lock (__projectSpecificLock)
+                    bool projectExtracted = false;
+                    this.ExecuteWithInAProjectContext(projectIdentifier, () =>
                     {
                         if (!Directory.Exists(projectSourceCodePath))
                         {
@@ -55,16 +55,17 @@ public ProjectItem GetContent(string username, string project, string path, ISou
                                 if (projectSelected == null)
                                 {
                                     openingProgressListener.OnProjectNotFound();
-                                    return null;
+                                    this.logger.Info("Couldn't find the specified the Github project {0}/{1}", username, project);
                                 }
+
                                 openingProgressListener.OnProjectFound();
-                                
+
                                 openingProgressListener.OnProjectDownloadStarted();
                                 var downloadStatus = this.DownloadZipBall(packagePath, projectSelected.DownloadPackageUrl);
                                 if (!downloadStatus)
                                 {
                                     openingProgressListener.OnProjectDownloadFailed();
-                                    return null;
+                                    this.logger.Info("Failed to download Github project {0}/{1}", username, project);
                                 }
 
                                 openingProgressListener.OnProjectDownloadCompleted();
@@ -74,33 +75,63 @@ public ProjectItem GetContent(string username, string project, string path, ISou
                             this.ExtractZipBall(packagePath, projectSourceCodePath);
 
                             this.editorService.RewriteExternalDependencies(username, project);
+
+                            projectExtracted = true;
                         }
-                    }
+                    });
 
-                    // Try to remove the created lock object
-                    ProjectDownloadLock.TryRemove(projectIdentifier, out __projectSpecificLock);
+                    if (!projectExtracted)
+                    {
+                        return null;
+                    }
                 }
 
-                openingProgressListener.OnBuildingWorkspace();                
+                openingProgressListener.OnBuildingWorkspace();
                 this.sourceCodeIndexingService.IndexProject(username, project, projectSourceCodePath);
                 openingProgressListener.OnProjectLoaded();
 
                 var projectItem = GetContentFromPath(username, project, projectSourceCodePath, path);
                 projectItem.DownloadedDate = Directory.GetCreationTimeUtc(projectSourceCodePath).ToString("dd MMM yyyy hh:mm:ss UTC");
                 return projectItem;
             }
+            catch (PathTooLongException ex)
+            {
+                this.ExecuteWithInAProjectContext(projectIdentifier, () =>
+                {
+                    // Cleanup the extracted project directory
+                    if (Directory.Exists(projectSourceCodePath))
+                    {
+                        Directory.Delete(projectSourceCodePath, true);
+                    }
+                });
+
+                openingProgressListener.OnProjectLoadingError();
+                this.logger.Error(ex, "Path too long exception {0} from project {1}/{2} ", path, username, project);
+            }
             catch (Exception ex)
             {
                 openingProgressListener.OnProjectLoadingError();
-                this.logger.Error(ex, "An error has occured while getting the content for path {0} from project {1}/{2}", path, username, project);
-                return null;
+                this.logger.Error(ex, "An error has occured while getting the content for path {0} from project {1}/{2} ", path, username, project);
+            }            
+
+            return null;
+        }
+
+        private void ExecuteWithInAProjectContext(string projectIdentifier, Action codeToExecute)
+        {
+            object __projectSpecificLock = ProjectDownloadLock.GetOrAdd(projectIdentifier, new object());
+            lock (__projectSpecificLock)
+            {
+                codeToExecute();
             }
+
+            // Try to remove the created lock object
+            ProjectDownloadLock.TryRemove(projectIdentifier, out __projectSpecificLock);
         }
 
         private ProjectItem GetContentFromPath(string username, string project, string projectSourceCodePath, string path)
         {
-            var repositoryDirectory = new DirectoryInfo(projectSourceCodePath);
-            DirectoryInfo applicationRoot = repositoryDirectory.GetDirectories()[0];
+            DirectoryInfo applicationRoot = new DirectoryInfo(projectSourceCodePath);
             string currentDirectoryName = "root";
 
             if (!string.IsNullOrEmpty(path))
@@ -208,12 +239,66 @@ private void ExtractZipBall(string zipFileToExtract, string destinationDirectory
             //Clean up the existing repository
             if (Directory.Exists(destinationDirectory))
             {
-                Directory.Delete(destinationDirectory, true);
+                DirectoryInfo directory = new DirectoryInfo(destinationDirectory);
+                foreach (FileInfo file in directory.GetFiles()) file.Delete();
+                foreach (System.IO.DirectoryInfo subDirectory in directory.GetDirectories()) subDirectory.Delete(true);
+            }
+            else
+            {
+                Directory.CreateDirectory(destinationDirectory);
             }
 
-            using (var zipFile = ZipFile.Read(zipFileToExtract))
+            //using (var zipFile = ZipFile.Read(zipFileToExtract))
+            //{
+            //    zipFile.ExtractAll(destinationDirectory, ExtractExistingFileAction.OverwriteSilently);
+            //}
+            
+            using (ZipInputStream zipStream = new ZipInputStream(zipFileToExtract))
+            {
+                string zipRootDirectoryName = string.Empty;
+                ZipEntry zipEntry = zipStream.GetNextEntry();
+                if (zipEntry == null)
+                {
+                    return;
+                }
+                else
+                {
+                    if (zipEntry.IsDirectory)
+                    {
+                        zipRootDirectoryName = zipEntry.FileName;
+                    }
+                }
+
+                while ((zipEntry = zipStream.GetNextEntry()) != null)
+                {
+                    string zipEntryPath = zipEntry.FileName;
+                    if (!string.IsNullOrEmpty(zipRootDirectoryName))
+                    {
+                        zipEntryPath = zipEntryPath.Replace(zipRootDirectoryName, string.Empty);
+                    }
+
+                    if (zipEntry.IsDirectory)
+                    {
+                        Directory.CreateDirectory(Path.Combine(destinationDirectory, zipEntryPath));
+                        continue;
+                    }
+
+                    string filename = Path.Combine(destinationDirectory, zipEntryPath);
+                    using (var fileStream = File.OpenWrite(filename))
+                    {
+                        CopyStream(zipStream, fileStream);
+                    }                    
+                }
+            }
+        }
+
+        private static void CopyStream(Stream input, Stream output)
+        {
+            byte[] buffer = new byte[8 * 1024];
+            int len;
+            while ((len = input.Read(buffer, 0, buffer.Length)) > 0)
             {
-                zipFile.ExtractAll(destinationDirectory, ExtractExistingFileAction.OverwriteSilently);
+                output.Write(buffer, 0, len);
             }
         }