forked from opensearch-project/security
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Run the same tests for both new style and legacy authz code paths
Signed-off-by: Craig Perkins <[email protected]>
- Loading branch information
Showing
5 changed files
with
230 additions
and
234 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
192 changes: 192 additions & 0 deletions
192
src/integrationTest/java/org/opensearch/security/systemindex/AbstractSystemIndexTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| * | ||
| */ | ||
| package org.opensearch.security.systemindex; | ||
|
|
||
| import com.carrotsearch.randomizedtesting.annotations.ThreadLeakScope; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| import org.opensearch.core.rest.RestStatus; | ||
| import org.opensearch.test.framework.cluster.LocalCluster; | ||
| import org.opensearch.test.framework.cluster.TestRestClient; | ||
| import org.opensearch.test.framework.cluster.TestRestClient.HttpResponse; | ||
| import org.opensearch.test.framework.matcher.RestMatchers; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.containsString; | ||
| import static org.hamcrest.Matchers.equalTo; | ||
| import static org.opensearch.security.systemindex.sampleplugin.SystemIndexPlugin1.SYSTEM_INDEX_1; | ||
| import static org.opensearch.security.systemindex.sampleplugin.SystemIndexPlugin2.SYSTEM_INDEX_2; | ||
| import static org.opensearch.test.framework.TestSecurityConfig.User.USER_ADMIN; | ||
|
|
||
| @RunWith(com.carrotsearch.randomizedtesting.RandomizedRunner.class) | ||
| @ThreadLeakScope(ThreadLeakScope.Scope.NONE) | ||
| public class AbstractSystemIndexTests { | ||
|
|
||
| private final LocalCluster cluster; | ||
|
|
||
| protected AbstractSystemIndexTests(LocalCluster cluster) { | ||
| this.cluster = cluster; | ||
| } | ||
|
|
||
| @Before | ||
| public void setup() { | ||
| try (TestRestClient client = cluster.getRestClient(cluster.getAdminCertificate())) { | ||
| client.delete(".system-index1"); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void adminShouldNotBeAbleToDeleteSecurityIndex() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.delete(".opendistro_security"); | ||
|
|
||
| assertThat(response.getStatusCode(), equalTo(RestStatus.FORBIDDEN.getStatus())); | ||
|
|
||
| // Create regular index | ||
| client.put("test-index"); | ||
|
|
||
| // regular user can delete non-system index | ||
| HttpResponse response2 = client.delete("test-index"); | ||
|
|
||
| assertThat(response2.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
|
|
||
| // regular use can create system index | ||
| HttpResponse response3 = client.put(".system-index1"); | ||
|
|
||
| assertThat(response3.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
|
|
||
| // regular user cannot delete system index | ||
| HttpResponse response4 = client.delete(".system-index1"); | ||
|
|
||
| assertThat(response4.getStatusCode(), equalTo(RestStatus.FORBIDDEN.getStatus())); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldBeAbleToIndexDocumentIntoItsSystemIndex() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.put("try-create-and-index/" + SYSTEM_INDEX_1); | ||
|
|
||
| assertThat(response.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| assertThat(response.getBody(), containsString("{\"acknowledged\":true}")); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldNotBeAbleToIndexDocumentIntoSystemIndexRegisteredByOtherPlugin() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.put("try-create-and-index/" + SYSTEM_INDEX_2); | ||
|
|
||
| assertThat( | ||
| response, | ||
| RestMatchers.isForbidden( | ||
| "/error/root_cause/0/reason", | ||
| "no permissions for [] and User [name=plugin:org.opensearch.security.systemindex.sampleplugin.SystemIndexPlugin1" | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldBeAbleToCreateSystemIndexButUserShouldNotBeAbleToIndex() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.put("try-create-and-index/" + SYSTEM_INDEX_1 + "?runAs=user"); | ||
|
|
||
| assertThat(response, RestMatchers.isForbidden("/error/root_cause/0/reason", "no permissions for [] and User [name=admin")); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldNotBeAbleToRunClusterActions() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.get("try-cluster-health/plugin"); | ||
|
|
||
| assertThat( | ||
| response, | ||
| RestMatchers.isForbidden( | ||
| "/error/root_cause/0/reason", | ||
| "no permissions for [cluster:monitor/health] and User [name=plugin:org.opensearch.security.systemindex.sampleplugin.SystemIndexPlugin1" | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testAdminUserShouldBeAbleToRunClusterActions() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.get("try-cluster-health/user"); | ||
|
|
||
| assertThat(response.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testAuthenticatedUserShouldBeAbleToRunClusterActions() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.get("try-cluster-health/default"); | ||
|
|
||
| assertThat(response.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldBeAbleToBulkIndexDocumentIntoItsSystemIndex() { | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.put("try-create-and-bulk-index/" + SYSTEM_INDEX_1); | ||
|
|
||
| assertThat(response.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPluginShouldNotBeAbleToBulkIndexDocumentIntoMixOfSystemIndexWhereAtLeastOneDoesNotBelongToPlugin() { | ||
| try (TestRestClient client = cluster.getRestClient(cluster.getAdminCertificate())) { | ||
| client.put(".system-index1"); | ||
| client.put(".system-index2"); | ||
| } | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| HttpResponse response = client.put("try-create-and-bulk-mixed-index"); | ||
|
|
||
| assertThat( | ||
| response.getBody(), | ||
| containsString( | ||
| "no permissions for [] and User [name=plugin:org.opensearch.security.systemindex.sampleplugin.SystemIndexPlugin1" | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void regularUserShouldGetNoResultsWhenSearchingSystemIndex() { | ||
| // Create system index and index a dummy document as the super admin user, data returned to super admin | ||
| try (TestRestClient client = cluster.getRestClient(cluster.getAdminCertificate())) { | ||
| HttpResponse response1 = client.put(".system-index1"); | ||
|
|
||
| assertThat(response1.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| String doc = "{\"field\":\"value\"}"; | ||
| HttpResponse adminPostResponse = client.postJson(".system-index1/_doc/1?refresh=true", doc); | ||
| assertThat(adminPostResponse.getStatusCode(), equalTo(RestStatus.CREATED.getStatus())); | ||
| HttpResponse response2 = client.get(".system-index1/_search"); | ||
|
|
||
| assertThat(response2.getStatusCode(), equalTo(RestStatus.OK.getStatus())); | ||
| assertThat(response2.getBody(), response2.getBody().contains("\"hits\":{\"total\":{\"value\":1,\"relation\":\"eq\"}")); | ||
| } | ||
|
|
||
| // Regular users should not be able to read it | ||
| try (TestRestClient client = cluster.getRestClient(USER_ADMIN)) { | ||
| // regular user cannot read system index | ||
| HttpResponse response1 = client.get(".system-index1/_search"); | ||
|
|
||
| assertThat(response1.getBody(), response1.getBody().contains("\"hits\":{\"total\":{\"value\":0,\"relation\":\"eq\"}")); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.