Skip to content

Commit db43112

Browse files
committed
Add opentsdb to CI
1 parent 048db39 commit db43112

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ jobs:
4848
docker ps | grep opentsdb
4949
5050
- name: Execute tests
51-
run: vendor/bin/phpunit
51+
run: APP_ENV=ci ./vendor/bin/phpunit

docker-compose.yml

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ services:
5858
- WAITSECS=30 # Give time for hbase to shut down, otherwise data corruption may result
5959
ports:
6060
- 4242:4242
61-
- 60030:60030
6261
networks:
6362
- php-opentsdb-client-lib
6463
volumes:

phpunit.xml.dist

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
</testsuite>
1515
</testsuites>
1616
<php>
17-
<server name="APP_ENV" value="testing"/>
17+
<env name="APP_ENV" value="testing"/>
1818
</php>
1919
</phpunit>

test/Integration/OpenTsdbClientTest.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ final class OpenTsdbClientTest extends TestCase
2222
{
2323
public function testSuccess(): void
2424
{
25-
// $this->markTestSkipped('Only for development environment. Need to pull opentsdb container to GitHub.');
25+
if ($_ENV['APP_ENV'] === 'ci') {
26+
$this->markTestSkipped('Only for development environment. Need to pull opentsdb container to GitHub.');
27+
}
2628

2729
$dataPointList[] = new DataPoint(
2830
metric: 'temperature',

0 commit comments

Comments
 (0)