Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation support? #4

Open
fodi opened this issue Dec 29, 2020 · 4 comments
Open

Translation support? #4

fodi opened this issue Dec 29, 2020 · 4 comments

Comments

@fodi
Copy link

fodi commented Dec 29, 2020

I absolutely love the adaptation! Are there any plans to support languages other than English? I'd be happy to provide a Hungarian translation for the UI and the spectrum cards.

@cynicaloptimist
Copy link
Owner

I'm happy to support multiple languages, although I haven't built in any localization infrastructure yet. If you'd like to take a crack at that, alongside Hungarian translation files, please submit a PR!

@rfuehrer
Copy link
Contributor

Hi @cynicaloptimist & @fodi , I came across the project earlier this week. I played the online version in our team and we are thrilled.

I would like to show my appreciation and contribute a German translation. However, that wouldn't help others, so I dabbled in React/TS and implemented a prototype for an I18n ;)

However, I am not completely satisfied with my approach, as it works completely but has more of a prototype character in terms of UI/UX.

What will be included?

  • Translation (hopefully) of all text passages
  • Support of any languages (because of i18next)
  • Support of placeholders in translations

What will not be included:

  • Appropriate integration of language selection in the UI
  • Selection of the language for the maps via the UI (different from the UI language)

Would you still be interested in the PR?

@rfuehrer
Copy link
Contributor

@fodi translation support is implemented in upstream project, feel free to be part of it ;)

@fodi
Copy link
Author

fodi commented Mar 14, 2021

@rfuehrer Great news, I'll add the Hungarian translation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants