You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would allow Cytoscape users to use modern theme definitions within their cytoscape environment. I'm not sure how complicated that might be, and maybe it's just not possible, but if it is, I think it would help to modernise Cytoscape.js usage
For reviewers
Reviewers should ensure that the following tasks are carried out for incorporated issues:
Ensure that the reporter has adequately described their idea. If not, elicit more information about the use case. You should iteratively build a spec together.
Ensure that the issue is a good fit for the core library. Some things are best done in extensions (e.g. UI-related features that aren't style-related). Some things are best done by app authors themselves -- instead of in Cytoscape libraries.
The issue has been associated with a corresponding milestone.
The commits have been incorporated into the unstable branch via pull request. The corresponding pull request is cross-referenced.
The text was updated successfully, but these errors were encountered:
Since everything in Cytoscape.js has access to JS, you can use functions. It isn't advisable to use function mappers for everything, especially for performance. However, you could use a top-level function that returns a stylesheet conditionally based on the dark mode.
Again, because you have access to JS, variables can just be variables, e.g. 'background-color': myRedColour
A dark mode function would make a great extension.
Description of new feature
It would be awesome to be able to support css color-mix() and light-dark() function for colours.
e.g. being able to use those css variables within the style definition:
Motivation for new feature
This would allow Cytoscape users to use modern theme definitions within their cytoscape environment. I'm not sure how complicated that might be, and maybe it's just not possible, but if it is, I think it would help to modernise Cytoscape.js usage
For reviewers
Reviewers should ensure that the following tasks are carried out for incorporated issues:
unstable
branch via pull request. The corresponding pull request is cross-referenced.The text was updated successfully, but these errors were encountered: