Skip to content

Commit

Permalink
Remove unnecessary dtor
Browse files Browse the repository at this point in the history
  • Loading branch information
cziter15 committed Feb 14, 2025
1 parent 5562fbc commit 1225202
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 36 deletions.
2 changes: 0 additions & 2 deletions src/ksf/comp/ksMqttConnector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ using namespace std::placeholders;

namespace ksf::comps
{
ksMqttConnector::~ksMqttConnector() = default;

ksMqttConnector::ksMqttConnector(bool sendConnectionStatus, bool usePersistentSession)
: reconnectTimer(KSF_MQTT_RECONNECT_DELAY_MS)
{
Expand Down
5 changes: 0 additions & 5 deletions src/ksf/comp/ksMqttConnector.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,5 @@ namespace ksf::comps
@param fingerprint MQTT broker certificate fingerprint - if empty, secure connection won't be used
*/
void setupConnection(const std::string broker, const std::string& port, std::string login, std::string password, std::string prefix, const std::string& fingerprint);

/*!
@brief Destructor (for uniqueptr purposes).
*/
virtual ~ksMqttConnector();
};
}
2 changes: 0 additions & 2 deletions src/ksf/ksApplication.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

namespace ksf
{
ksApplication::~ksApplication() = default;

bool ksApplication::loop()
{
/* This call will keep millis64 on track (handles rollover). */
Expand Down
4 changes: 0 additions & 4 deletions src/ksf/ksApplication.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,5 @@ namespace ksf
*/
void setLogCallback(AppLogCallbackFunc_t logCallback);
#endif
/*!
@brief Destructs application.
*/
virtual ~ksApplication();
};
}
2 changes: 0 additions & 2 deletions src/ksf/ksComponent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@

namespace ksf
{
ksComponent::~ksComponent() = default;

bool ksComponent::init(ksApplication* app)
{
return true;
Expand Down
5 changes: 0 additions & 5 deletions src/ksf/ksComponent.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,5 @@ namespace ksf
@return True on success, false on fail.
*/
virtual bool postInit(ksApplication* app);

/*!
@brief Virtual destructor to ensure proper cleanup of derived classes
*/
virtual ~ksComponent();
};
}
2 changes: 0 additions & 2 deletions src/ksf/ksRtti.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ namespace ksf
class ksRtti
{
public:
virtual ~ksRtti() = default;

/*!
@brief Retrieves type ID of the object.
@return Object type ID.
Expand Down
2 changes: 0 additions & 2 deletions src/ksf/misc/ksDomainQuery.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ namespace ksf::misc
udp->write(static_cast<uint8_t>(value & 0xFF));
}

ksDomainQuery::~ksDomainQuery() = default;

ksDomainQuery::ksDomainQuery() : ksDomainQuery(KSF_DOMAIN_QUERY_DNS_SERVER) {}

ksDomainQuery::ksDomainQuery(IPAddress dnsServer)
Expand Down
5 changes: 0 additions & 5 deletions src/ksf/misc/ksDomainQuery.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,5 @@ namespace ksf::misc
@brief Handles resolver tasks, such as sending queries and receiving responses.
*/
void process();

/*!
@brief Destructor.
*/
virtual ~ksDomainQuery();
};
}
2 changes: 0 additions & 2 deletions src/ksf/misc/ksSimpleTimer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

namespace ksf::misc
{
ksSimpleTimer::~ksSimpleTimer() = default;

ksSimpleTimer::ksSimpleTimer(uint32_t intervalMs)
{
setInterval(intervalMs);
Expand Down
5 changes: 0 additions & 5 deletions src/ksf/misc/ksSimpleTimer.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,5 @@ namespace ksf::misc
@return True if timer interval just passed, otherwise false.
*/
bool hasTimePassed() const;

/*!
@brief Destructor.
*/
virtual ~ksSimpleTimer();
};
}

0 comments on commit 1225202

Please sign in to comment.