From 1225202f6fce28636e9982cb777884ea75cbe53a Mon Sep 17 00:00:00 2001
From: cziter15 <chris.streh@gmail.com>
Date: Sat, 15 Feb 2025 00:34:54 +0100
Subject: [PATCH] Remove unnecessary dtor

---
 src/ksf/comp/ksMqttConnector.cpp | 2 --
 src/ksf/comp/ksMqttConnector.h   | 5 -----
 src/ksf/ksApplication.cpp        | 2 --
 src/ksf/ksApplication.h          | 4 ----
 src/ksf/ksComponent.cpp          | 2 --
 src/ksf/ksComponent.h            | 5 -----
 src/ksf/ksRtti.h                 | 2 --
 src/ksf/misc/ksDomainQuery.cpp   | 2 --
 src/ksf/misc/ksDomainQuery.h     | 5 -----
 src/ksf/misc/ksSimpleTimer.cpp   | 2 --
 src/ksf/misc/ksSimpleTimer.h     | 5 -----
 11 files changed, 36 deletions(-)

diff --git a/src/ksf/comp/ksMqttConnector.cpp b/src/ksf/comp/ksMqttConnector.cpp
index a892a9d9..d18c5b41 100644
--- a/src/ksf/comp/ksMqttConnector.cpp
+++ b/src/ksf/comp/ksMqttConnector.cpp
@@ -32,8 +32,6 @@ using namespace std::placeholders;
 
 namespace ksf::comps
 {
-	ksMqttConnector::~ksMqttConnector() = default;
-
 	ksMqttConnector::ksMqttConnector(bool sendConnectionStatus, bool usePersistentSession)
 		: reconnectTimer(KSF_MQTT_RECONNECT_DELAY_MS)
 	{
diff --git a/src/ksf/comp/ksMqttConnector.h b/src/ksf/comp/ksMqttConnector.h
index 92718e2f..34675edf 100644
--- a/src/ksf/comp/ksMqttConnector.h
+++ b/src/ksf/comp/ksMqttConnector.h
@@ -195,10 +195,5 @@ namespace ksf::comps
 				@param fingerprint MQTT broker certificate fingerprint - if empty, secure connection won't be used
 			*/
 			void setupConnection(const std::string broker, const std::string& port, std::string login, std::string password, std::string prefix, const std::string& fingerprint);
-	
-			/*!
-				@brief Destructor (for uniqueptr purposes).
-			*/
-			virtual ~ksMqttConnector();
 	};
 }
\ No newline at end of file
diff --git a/src/ksf/ksApplication.cpp b/src/ksf/ksApplication.cpp
index 7ce32d9b..3170dc23 100644
--- a/src/ksf/ksApplication.cpp
+++ b/src/ksf/ksApplication.cpp
@@ -13,8 +13,6 @@
 
 namespace ksf
 {
-	ksApplication::~ksApplication() = default;
-
 	bool ksApplication::loop()
 	{
 		/* This call will keep millis64 on track (handles rollover). */
diff --git a/src/ksf/ksApplication.h b/src/ksf/ksApplication.h
index 0d44d656..97b0cf3a 100644
--- a/src/ksf/ksApplication.h
+++ b/src/ksf/ksApplication.h
@@ -143,9 +143,5 @@ namespace ksf
 			*/
 			void setLogCallback(AppLogCallbackFunc_t logCallback);
 #endif
-			/*!
-				@brief Destructs application.
-			*/
-			virtual ~ksApplication();
 	};
 }
diff --git a/src/ksf/ksComponent.cpp b/src/ksf/ksComponent.cpp
index 5a1f514f..b5ebd2fc 100644
--- a/src/ksf/ksComponent.cpp
+++ b/src/ksf/ksComponent.cpp
@@ -11,8 +11,6 @@
 
 namespace ksf 
 {
-	ksComponent::~ksComponent() = default;
-	
 	bool ksComponent::init(ksApplication* app)
 	{
 		return true;
diff --git a/src/ksf/ksComponent.h b/src/ksf/ksComponent.h
index 9ea59233..ff226499 100644
--- a/src/ksf/ksComponent.h
+++ b/src/ksf/ksComponent.h
@@ -77,10 +77,5 @@ namespace ksf
 				@return True on success, false on fail.
 			*/
 			virtual bool postInit(ksApplication* app);
-
-			/*!
-				@brief Virtual destructor to ensure proper cleanup of derived classes
-			*/
-			virtual ~ksComponent();
 	};
 }
diff --git a/src/ksf/ksRtti.h b/src/ksf/ksRtti.h
index 6518ec15..7a3df7b7 100644
--- a/src/ksf/ksRtti.h
+++ b/src/ksf/ksRtti.h
@@ -25,8 +25,6 @@ namespace ksf
 	class ksRtti
 	{
 		public:
-			virtual ~ksRtti() = default;
-			
 			/*!
 				@brief Retrieves type ID of the object.
 				@return Object type ID.
diff --git a/src/ksf/misc/ksDomainQuery.cpp b/src/ksf/misc/ksDomainQuery.cpp
index cad55799..78aeca2c 100644
--- a/src/ksf/misc/ksDomainQuery.cpp
+++ b/src/ksf/misc/ksDomainQuery.cpp
@@ -26,8 +26,6 @@ namespace ksf::misc
 		udp->write(static_cast<uint8_t>(value & 0xFF));
 	}
 
-	ksDomainQuery::~ksDomainQuery() = default;
-
 	ksDomainQuery::ksDomainQuery() : ksDomainQuery(KSF_DOMAIN_QUERY_DNS_SERVER) {}
 
 	ksDomainQuery::ksDomainQuery(IPAddress dnsServer)
diff --git a/src/ksf/misc/ksDomainQuery.h b/src/ksf/misc/ksDomainQuery.h
index 4070b195..3aa7587c 100644
--- a/src/ksf/misc/ksDomainQuery.h
+++ b/src/ksf/misc/ksDomainQuery.h
@@ -91,10 +91,5 @@ namespace ksf::misc
 				@brief Handles resolver tasks, such as sending queries and receiving responses.
 			*/
 			void process();
-			
-			/*! 
-				@brief Destructor.
-			*/
-			virtual ~ksDomainQuery();
 	};
 }
\ No newline at end of file
diff --git a/src/ksf/misc/ksSimpleTimer.cpp b/src/ksf/misc/ksSimpleTimer.cpp
index e795575c..8112e3c0 100644
--- a/src/ksf/misc/ksSimpleTimer.cpp
+++ b/src/ksf/misc/ksSimpleTimer.cpp
@@ -13,8 +13,6 @@
 
 namespace ksf::misc
 {
-	ksSimpleTimer::~ksSimpleTimer() = default;
-
 	ksSimpleTimer::ksSimpleTimer(uint32_t intervalMs) 
 	{
 		setInterval(intervalMs);
diff --git a/src/ksf/misc/ksSimpleTimer.h b/src/ksf/misc/ksSimpleTimer.h
index 13a81e55..4f3f9667 100644
--- a/src/ksf/misc/ksSimpleTimer.h
+++ b/src/ksf/misc/ksSimpleTimer.h
@@ -60,10 +60,5 @@ namespace ksf::misc
 				@return	True if timer interval just passed, otherwise false.
 			*/
 			bool hasTimePassed() const;
-
-			/*!
-				@brief Destructor.
-			*/
-			virtual ~ksSimpleTimer();
 	};
 }