From e7a3d0742eed3b820292fddec2186ee5c6de9d0f Mon Sep 17 00:00:00 2001 From: dadav <33197631+dadav@users.noreply.github.com> Date: Mon, 4 Mar 2024 17:35:27 +0100 Subject: [PATCH] fix: Adjust code --- cmd/serve.go | 3 +++ internal/middleware/cache.go | 2 +- internal/v3/api/module.go | 3 --- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/serve.go b/cmd/serve.go index e69b96e..5a22ce6 100644 --- a/cmd/serve.go +++ b/cmd/serve.go @@ -62,6 +62,9 @@ You can also enable the caching functionality to speed things up.`, r := chi.NewRouter() + // Logger should come before any middleware that modifies the response + r.Use(middleware.Logger) + // Recoverer should also be pretty high in the middleware stack r.Use(middleware.Recoverer) r.Use(middleware.RealIP) r.Use(customMiddleware.RequireUserAgent) diff --git a/internal/middleware/cache.go b/internal/middleware/cache.go index c554cf3..0d8760c 100644 --- a/internal/middleware/cache.go +++ b/internal/middleware/cache.go @@ -31,7 +31,7 @@ func CacheMiddleware(prefixes []string, cacheDir string) func(next http.Handler) } } - if !matched { + if !matched || r.Method != "GET" { next.ServeHTTP(w, r) return } diff --git a/internal/v3/api/module.go b/internal/v3/api/module.go index f8ae470..5ba2360 100644 --- a/internal/v3/api/module.go +++ b/internal/v3/api/module.go @@ -24,9 +24,6 @@ func NewModuleOperationsApi() *ModuleOperationsApi { // DeleteModule - Delete module func (s *ModuleOperationsApi) DeleteModule(ctx context.Context, moduleSlug string, reason string) (gen.ImplResponse, error) { - // TODO - update DeleteModule with the required logic for this service method. - // Add api_module_operations_service.go to the .openapi-generator-ignore to avoid overwriting this service implementation when updating open api generation. - // TODO: Uncomment the next line to return response Response(204, {}) or use other options such as http.Ok ... // return Response(204, nil),nil