Skip to content

Commit 3f22451

Browse files
committed
Remove event listener when component destoryed
1 parent 956148d commit 3f22451

File tree

2 files changed

+21
-13
lines changed

2 files changed

+21
-13
lines changed

upload-1.vue

+12-8
Original file line numberDiff line numberDiff line change
@@ -879,14 +879,18 @@ export default {
879879
);
880880
}
881881
},
882-
created(){
883-
// 绑定按键esc隐藏此插件事件
884-
document.addEventListener('keyup', (e)=>{
885-
if(this.value && (e.key == 'Escape' || e.keyCode == 27)){
886-
this.off();
887-
}
888-
})
889-
}
882+
handleEscClose(e){
883+
if(this.value && (e.key == 'Escape' || e.keyCode == 27)){
884+
this.off();
885+
}
886+
},
887+
created(){
888+
// 绑定按键esc隐藏此插件事件
889+
document.addEventListener('keyup', this.handleEscClose )
890+
},
891+
beforeDestroy(){
892+
document.removeEventListener('keyup', this.handleEscClose )
893+
}
890894
}
891895
892896
</script>

upload-2.vue

+9-5
Original file line numberDiff line numberDiff line change
@@ -873,13 +873,17 @@ export default {
873873
);
874874
}
875875
},
876+
handleEscClose(e){
877+
if(this.value && (e.key == 'Escape' || e.keyCode == 27)){
878+
this.off();
879+
}
880+
},
876881
created(){
877882
// 绑定按键esc隐藏此插件事件
878-
document.addEventListener('keyup', (e)=>{
879-
if(this.value && (e.key == 'Escape' || e.keyCode == 27)){
880-
this.off();
881-
}
882-
})
883+
document.addEventListener('keyup', this.handleEscClose )
884+
},
885+
beforeDestroy(){
886+
document.removeEventListener('keyup', this.handleEscClose )
883887
}
884888
}
885889

0 commit comments

Comments
 (0)