[Bug?] Component cache retention causes unexpected behaviors

[oznogon]

Discord thread

Given:

debris=Asteroid():setPosition(0,2000):setRadarTraceIcon("blip.png"):setRadarTraceColor(200,200,200):setDescriptions("Debris. Scan for more info","Explosive"):setScanningParameters(1,1)               
debris:setModel("ammo_box")

The scale of the ammo box is 120x of what's expected.

@GinjaNinja32:

due to 924102c, your asteroid having mesh_render.scale = random(110,130) doesn't get overridden back to default when the component gets overwritten by setModel()

it gets overridden if the model specifies a scale, but not if it doesn't

so you end up with models expecting to inherit scale=1 but instead getting scale=120 or so and ending up a lot bigger than they should be

[daid]

Guess a fix here would be to give the model data a default scale?

[GinjaNinja32]

it would fix that instance, but there will be many many more, and the retain-existing-data-on-set doesn't actually fix the problem it was intended to fix. easier to revert that and fix the real issue properly.

[daid]

Yes, I agree (sometimes a night of sleep can do good) assignment should be assignment not update. There are some issues with losing cached state and erasing C++ data that we do not want erased, but that can be solved by splitting the component into two. As assigning nil and then re-creating the component will do that as well.

It might also be nice to have a components.component.update({property: value, property2: value2}) style function in case you want to bulk set a bunch of properties without assigning each individually (this would be higher performance as well then assigning each individually)