fix: properly update fire risk for empty house

dalerank · dalerank · commit 9ef35955efdb · 2025-03-03T18:47:38.000+01:00
diff --git a/src/building/building_house.cpp b/src/building/building_house.cpp
@@ -211,7 +211,11 @@ void building_house::bind_dynamic(io_buffer *iob, size_t version) {
 }
 
 int building_house::get_fire_risk(int value) const {
-    return (house_level() == BUILDING_HOUSE_VACANT_LOT && is_vacant_lot()) ? value : 0;
+    if (house_level() == BUILDING_HOUSE_VACANT_LOT && is_vacant_lot()) {
+        return 0;
+    }
+
+    return value;
 }
 
 void building_house::highlight_waypoints() {

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,11 @@ void building_house::bind_dynamic(io_buffer *iob, size_t version) {`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`int building_house::get_fire_risk(int value) const {`
`214`		`- return (house_level() == BUILDING_HOUSE_VACANT_LOT && is_vacant_lot()) ? value : 0;`
	`214`	`+ if (house_level() == BUILDING_HOUSE_VACANT_LOT && is_vacant_lot()) {`
	`215`	`+ return 0;`
	`216`	`+ }`
	`217`	`+`
	`218`	`+ return value;`
`215`	`219`	`}`
`216`	`220`
`217`	`221`	`void building_house::highlight_waypoints() {`