ui: fill_employment_details() not fill workers_desc label now

Author: dalerank

src/window/window_building_info.cpp

@@ -94,21 +94,15 @@ void building_info_window::common_info_background(object_info& c) {
     ui["warning_text"] = ui::str(reason.first, reason.second);
     ui["workers_desc"] = ui::str(workers.first, workers.second);
 
-    fill_employment_details(c, -1);
+    fill_employment_details(c);
 }
 
 void building_info_window::fill_employment_details(object_info &c, int text_id) {
     building *b = building_get(c);
 
     int laborers = model_get_building(b->type)->laborers;
     ui["workers_text"].text_var("%d %s (%d %s", b->num_workers, ui::str(8, 12), laborers, ui::str(69, 0));
-    if (text_id < 0) {
-        text_id = get_employment_info_text_id(&c, b, 1);
-    }
-
-    if (text_id > 0) {
-        ui["workers_desc"] = ui::str(69, text_id);
-    }
+    text_id = get_employment_info_text_id(&c, b, 1);
 }
 
 void building_info_window::window_info_background(object_info &c) {

src/window/window_info_storageyard_orders.cpp

@@ -25,7 +25,7 @@ void info_window_storageyard_orders::draw_background(object_info *c) {
 void info_window_storageyard_orders::draw_foreground(object_info *c) {
     building_info_window::window_info_background(*c);
 
-    resource_list resources = city_resource_get_available();
+    const resource_list resources = city_resource_get_available();
     auto &data = g_window_building_distribution;
 
     auto *b = c->building_get();

src/window/window_resource_settings.cpp

@@ -216,7 +216,7 @@ static void handle_input(const mouse* m, const hotkeys* h) {
 }
 
 void window_resource_settings_show(e_resource resource) {
-    window_type window = {
+    static window_type window = {
         WINDOW_RESOURCE_SETTINGS,
         draw_background,
         draw_foreground,