Make version scripts properly abort on error

Author: danielsaidi

Tests/SwiftUIKitTests/Bundle/Bundle+InformationTests.swift

@@ -20,11 +20,11 @@ final class Bundle_InformationTests: XCTestCase {
     }
 }
 
-private class MyBundle: Bundle {
+private class MyBundle: Bundle, @unchecked Sendable {
 
     override var infoDictionary: [String: Any]? {
         [
-            String(kCFBundleVersionKey): "123",
+            String(kCFBundleVersionKey): "1234",
             "CFBundleDisplayName": "SwiftUIKit Tests",
             "CFBundleShortVersionString": "1.2.3"
         ]

scripts/test.sh

@@ -40,7 +40,7 @@ test_platform() {
 
     # Define a local $PLATFORM variable
     local PLATFORM="${1//_/ }"
-
+    
     # Define the destination, based on the $PLATFORM
     case $PLATFORM in
         "iOS")
@@ -66,10 +66,16 @@ test_platform() {
 
     # Test $TARGET for the $DESTINATION
     echo "Testing $TARGET for $PLATFORM..."
-    xcodebuild test -scheme $TARGET -derivedDataPath .build -destination "$DESTINATION" -enableCodeCoverage YES;
+    xcodebuild test -scheme $TARGET -derivedDataPath .build -destination "$DESTINATION" -enableCodeCoverage YES
+    local TEST_RESULT=$?
+    
+    if [[ $TEST_RESULT -ne 0 ]]; then
+        return $TEST_RESULT
+    fi
 
     # Complete successfully
     echo "Successfully tested $TARGET for $PLATFORM"
+    return 0
 }
 
 # Loop through all platforms and call the test function
@@ -82,4 +88,4 @@ done
 # Complete successfully
 echo ""
 echo "Testing $TARGET completed successfully!"
-echo ""
+echo ""

scripts/version_validate_git.sh

@@ -26,6 +26,11 @@ fi
 # Create local argument variables.
 BRANCH=$1
 
+# Start script
+echo ""
+echo "Validating git repository..."
+echo ""
+
 # Check if the current directory is a Git repository
 if ! git rev-parse --is-inside-work-tree > /dev/null 2>&1; then
     echo "Error: Not a Git repository"
@@ -38,11 +43,6 @@ if [ -n "$(git status --porcelain)" ]; then
     exit 1
 fi
 
-# Start script
-echo ""
-echo "Validating git repository..."
-echo ""
-
 # Verify that we're on the correct branch
 current_branch=$(git rev-parse --abbrev-ref HEAD)
 if [ "$current_branch" != "$BRANCH" ]; then

scripts/version_validate_target.sh

@@ -63,7 +63,10 @@ echo ""
 
 # Run SwiftLint
 echo "Running SwiftLint"
-swiftlint
+if ! swiftlint --strict; then
+    echo "Error: SwiftLint failed"
+    exit 1
+fi
 
 # Run unit tests
 echo "Testing..."